From 9a13393ce367a06258f0ee2b155b02493632d472 Mon Sep 17 00:00:00 2001 From: Christoph Pojer Date: Fri, 18 Apr 2014 12:47:51 -0700 Subject: [PATCH] Remove function wrappers in DOMSelection There is no point in doing the feature detection on every call, unless there is an IE bug where it is not sure about which support for selection it has (totally plausible). --- src/browser/ui/ReactDOMSelection.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/browser/ui/ReactDOMSelection.js b/src/browser/ui/ReactDOMSelection.js index ed4cd701b3..87f1109c76 100644 --- a/src/browser/ui/ReactDOMSelection.js +++ b/src/browser/ui/ReactDOMSelection.js @@ -171,19 +171,13 @@ var ReactDOMSelection = { /** * @param {DOMElement} node */ - getOffsets: function(node) { - var getOffsets = document.selection ? getIEOffsets : getModernOffsets; - return getOffsets(node); - }, + getOffsets: document.selection ? getIEOffsets : getModernOffsets, /** * @param {DOMElement|DOMTextNode} node * @param {object} offsets */ - setOffsets: function(node, offsets) { - var setOffsets = document.selection ? setIEOffsets : setModernOffsets; - setOffsets(node, offsets); - } + setOffsets: document.selection ? setIEOffsets : setModernOffsets }; module.exports = ReactDOMSelection;