diff --git a/src/isomorphic/classic/element/ReactElementValidator.js b/src/isomorphic/classic/element/ReactElementValidator.js
index 2b7e9da3d5..2afbb8cb32 100644
--- a/src/isomorphic/classic/element/ReactElementValidator.js
+++ b/src/isomorphic/classic/element/ReactElementValidator.js
@@ -19,7 +19,7 @@
'use strict';
var ReactCurrentOwner = require('ReactCurrentOwner');
-var ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
+var ReactComponentTreeHook = require('ReactComponentTreeHook');
var ReactElement = require('ReactElement');
var ReactPropTypeLocations = require('ReactPropTypeLocations');
@@ -104,7 +104,7 @@ function validateExplicitKey(element, parentType) {
'%s%s See https://fb.me/react-warning-keys for more information.%s',
currentComponentErrorInfo,
childOwner,
- ReactComponentTreeDevtool.getCurrentStackAddendum(element)
+ ReactComponentTreeHook.getCurrentStackAddendum(element)
);
}
diff --git a/src/isomorphic/classic/types/checkReactTypeSpec.js b/src/isomorphic/classic/types/checkReactTypeSpec.js
index 84211727fa..3a91e8327a 100644
--- a/src/isomorphic/classic/types/checkReactTypeSpec.js
+++ b/src/isomorphic/classic/types/checkReactTypeSpec.js
@@ -17,7 +17,7 @@ var ReactPropTypesSecret = require('ReactPropTypesSecret');
var invariant = require('invariant');
var warning = require('warning');
-var ReactComponentTreeDevtool;
+var ReactComponentTreeHook;
if (
typeof process !== 'undefined' &&
@@ -29,7 +29,7 @@ if (
// https://github.com/facebook/react/issues/7240
// Remove the inline requires when we don't need them anymore:
// https://github.com/facebook/react/pull/7178
- ReactComponentTreeDevtool = require('ReactComponentTreeDevtool')
+ ReactComponentTreeHook = require('ReactComponentTreeHook')
}
var loggedTypeFailures = {};
@@ -88,13 +88,13 @@ function checkReactTypeSpec(typeSpecs, values, location, componentName, element,
var componentStackInfo = '';
if (__DEV__) {
- if (!ReactComponentTreeDevtool) {
- ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
+ if (!ReactComponentTreeHook) {
+ ReactComponentTreeHook = require('ReactComponentTreeHook');
}
if (debugID !== null) {
- componentStackInfo = ReactComponentTreeDevtool.getStackAddendumByID(debugID);
+ componentStackInfo = ReactComponentTreeHook.getStackAddendumByID(debugID);
} else if (element !== null) {
- componentStackInfo = ReactComponentTreeDevtool.getCurrentStackAddendum(element);
+ componentStackInfo = ReactComponentTreeHook.getCurrentStackAddendum(element);
}
}
diff --git a/src/isomorphic/hooks/ReactComponentTreeDevtool.js b/src/isomorphic/hooks/ReactComponentTreeDevtool.js
new file mode 100644
index 0000000000..8e9898e3c1
--- /dev/null
+++ b/src/isomorphic/hooks/ReactComponentTreeDevtool.js
@@ -0,0 +1,14 @@
+/**
+ * Copyright 2016-present, Facebook, Inc.
+ * All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree. An additional grant
+ * of patent rights can be found in the PATENTS file in the same directory.
+ *
+ * @providesModule ReactComponentTreeDevtool
+ */
+'use strict';
+
+// TODO remove this proxy when RN/www gets updated
+module.exports = require('ReactComponentTreeHook');
diff --git a/src/isomorphic/devtools/ReactComponentTreeDevtool.js b/src/isomorphic/hooks/ReactComponentTreeHook.js
similarity index 89%
rename from src/isomorphic/devtools/ReactComponentTreeDevtool.js
rename to src/isomorphic/hooks/ReactComponentTreeHook.js
index 622bad9847..97aa9fa23b 100644
--- a/src/isomorphic/devtools/ReactComponentTreeDevtool.js
+++ b/src/isomorphic/hooks/ReactComponentTreeHook.js
@@ -6,7 +6,7 @@
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
- * @providesModule ReactComponentTreeDevtool
+ * @providesModule ReactComponentTreeHook
*/
'use strict';
@@ -57,23 +57,23 @@ function describeComponentFrame(name, source, ownerName) {
}
function describeID(id) {
- var name = ReactComponentTreeDevtool.getDisplayName(id);
- var element = ReactComponentTreeDevtool.getElement(id);
- var ownerID = ReactComponentTreeDevtool.getOwnerID(id);
+ var name = ReactComponentTreeHook.getDisplayName(id);
+ var element = ReactComponentTreeHook.getElement(id);
+ var ownerID = ReactComponentTreeHook.getOwnerID(id);
var ownerName;
if (ownerID) {
- ownerName = ReactComponentTreeDevtool.getDisplayName(ownerID);
+ ownerName = ReactComponentTreeHook.getDisplayName(ownerID);
}
warning(
element,
- 'ReactComponentTreeDevtool: Missing React element for debugID %s when ' +
+ 'ReactComponentTreeHook: Missing React element for debugID %s when ' +
'building stack',
id
);
return describeComponentFrame(name, element && element._source, ownerName);
}
-var ReactComponentTreeDevtool = {
+var ReactComponentTreeHook = {
onSetDisplayName(id, displayName) {
updateTree(id, item => item.displayName = displayName);
},
@@ -86,7 +86,7 @@ var ReactComponentTreeDevtool = {
var nextChild = tree[nextChildID];
invariant(
nextChild,
- 'Expected devtool events to fire for the child ' +
+ 'Expected hook events to fire for the child ' +
'before its parent includes it in onSetChildren().'
);
invariant(
@@ -161,7 +161,7 @@ var ReactComponentTreeDevtool = {
},
purgeUnmountedComponents() {
- if (ReactComponentTreeDevtool._preventPurging) {
+ if (ReactComponentTreeHook._preventPurging) {
// Should only be used for testing.
return;
}
@@ -195,7 +195,7 @@ var ReactComponentTreeDevtool = {
var currentOwner = ReactCurrentOwner.current;
var id = currentOwner && currentOwner._debugID;
- info += ReactComponentTreeDevtool.getStackAddendumByID(id);
+ info += ReactComponentTreeHook.getStackAddendumByID(id);
return info;
},
@@ -203,7 +203,7 @@ var ReactComponentTreeDevtool = {
var info = '';
while (id) {
info += describeID(id);
- id = ReactComponentTreeDevtool.getParentID(id);
+ id = ReactComponentTreeHook.getParentID(id);
}
return info;
},
@@ -259,4 +259,4 @@ var ReactComponentTreeDevtool = {
},
};
-module.exports = ReactComponentTreeDevtool;
+module.exports = ReactComponentTreeHook;
diff --git a/src/renderers/dom/client/ReactMount.js b/src/renderers/dom/client/ReactMount.js
index 9a0d15ba27..42c4a676f9 100644
--- a/src/renderers/dom/client/ReactMount.js
+++ b/src/renderers/dom/client/ReactMount.js
@@ -302,7 +302,7 @@ var ReactMount = {
},
/**
- * Render a new component into the DOM. Hooked by devtools!
+ * Render a new component into the DOM. Hooked by hooks!
*
* @param {ReactElement} nextElement element to render
* @param {DOMElement} container container to render into
diff --git a/src/renderers/dom/shared/ReactDOMDebugTool.js b/src/renderers/dom/shared/ReactDOMDebugTool.js
index aae63af916..dbbd5a1a79 100644
--- a/src/renderers/dom/shared/ReactDOMDebugTool.js
+++ b/src/renderers/dom/shared/ReactDOMDebugTool.js
@@ -11,8 +11,8 @@
'use strict';
-var ReactDOMNullInputValuePropDevtool = require('ReactDOMNullInputValuePropDevtool');
-var ReactDOMUnknownPropertyDevtool = require('ReactDOMUnknownPropertyDevtool');
+var ReactDOMNullInputValuePropHook = require('ReactDOMNullInputValuePropHook');
+var ReactDOMUnknownPropertyHook = require('ReactDOMUnknownPropertyHook');
var ReactDebugTool = require('ReactDebugTool');
var warning = require('warning');
@@ -29,7 +29,7 @@ function emitEvent(handlerFunctionName, arg1, arg2, arg3, arg4, arg5) {
} catch (e) {
warning(
handlerDoesThrowForEvent[handlerFunctionName],
- 'exception thrown by devtool while handling %s: %s',
+ 'exception thrown by hook while handling %s: %s',
handlerFunctionName,
e + '\n' + e.stack
);
@@ -39,14 +39,14 @@ function emitEvent(handlerFunctionName, arg1, arg2, arg3, arg4, arg5) {
}
var ReactDOMDebugTool = {
- addDevtool(devtool) {
- ReactDebugTool.addDevtool(devtool);
- eventHandlers.push(devtool);
+ addHook(hook) {
+ ReactDebugTool.addHook(hook);
+ eventHandlers.push(hook);
},
- removeDevtool(devtool) {
- ReactDebugTool.removeDevtool(devtool);
+ removeHook(hook) {
+ ReactDebugTool.removeHook(hook);
for (var i = 0; i < eventHandlers.length; i++) {
- if (eventHandlers[i] === devtool) {
+ if (eventHandlers[i] === hook) {
eventHandlers.splice(i, 1);
i--;
}
@@ -66,7 +66,7 @@ var ReactDOMDebugTool = {
},
};
-ReactDOMDebugTool.addDevtool(ReactDOMUnknownPropertyDevtool);
-ReactDOMDebugTool.addDevtool(ReactDOMNullInputValuePropDevtool);
+ReactDOMDebugTool.addHook(ReactDOMUnknownPropertyHook);
+ReactDOMDebugTool.addHook(ReactDOMNullInputValuePropHook);
module.exports = ReactDOMDebugTool;
diff --git a/src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js b/src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js
index a8fdd92175..3e60e2807d 100644
--- a/src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js
+++ b/src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js
@@ -19,13 +19,13 @@ describe('ReactDOMDebugTool', function() {
ReactDOMDebugTool = require('ReactDOMDebugTool');
});
- it('should add and remove devtools', () => {
+ it('should add and remove hooks', () => {
var handler1 = jasmine.createSpy('spy');
var handler2 = jasmine.createSpy('spy');
- var devtool1 = {onTestEvent: handler1};
- var devtool2 = {onTestEvent: handler2};
+ var hook1 = {onTestEvent: handler1};
+ var hook2 = {onTestEvent: handler2};
- ReactDOMDebugTool.addDevtool(devtool1);
+ ReactDOMDebugTool.addHook(hook1);
ReactDOMDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(1);
expect(handler2.calls.count()).toBe(0);
@@ -34,7 +34,7 @@ describe('ReactDOMDebugTool', function() {
expect(handler1.calls.count()).toBe(2);
expect(handler2.calls.count()).toBe(0);
- ReactDOMDebugTool.addDevtool(devtool2);
+ ReactDOMDebugTool.addHook(hook2);
ReactDOMDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(3);
expect(handler2.calls.count()).toBe(1);
@@ -43,20 +43,20 @@ describe('ReactDOMDebugTool', function() {
expect(handler1.calls.count()).toBe(4);
expect(handler2.calls.count()).toBe(2);
- ReactDOMDebugTool.removeDevtool(devtool1);
+ ReactDOMDebugTool.removeHook(hook1);
ReactDOMDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(4);
expect(handler2.calls.count()).toBe(3);
- ReactDOMDebugTool.removeDevtool(devtool2);
+ ReactDOMDebugTool.removeHook(hook2);
ReactDOMDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(4);
expect(handler2.calls.count()).toBe(3);
});
- it('warns once when an error is thrown in devtool', () => {
+ it('warns once when an error is thrown in hook', () => {
spyOn(console, 'error');
- ReactDOMDebugTool.addDevtool({
+ ReactDOMDebugTool.addHook({
onTestEvent() {
throw new Error('Hi.');
},
@@ -65,7 +65,7 @@ describe('ReactDOMDebugTool', function() {
ReactDOMDebugTool.onTestEvent();
expect(console.error.calls.count()).toBe(1);
expect(console.error.calls.argsFor(0)[0]).toContain(
- 'exception thrown by devtool while handling ' +
+ 'exception thrown by hook while handling ' +
'onTestEvent: Error: Hi.'
);
diff --git a/src/renderers/dom/shared/devtools/ReactDOMNullInputValuePropDevtool.js b/src/renderers/dom/shared/hooks/ReactDOMNullInputValuePropHook.js
similarity index 80%
rename from src/renderers/dom/shared/devtools/ReactDOMNullInputValuePropDevtool.js
rename to src/renderers/dom/shared/hooks/ReactDOMNullInputValuePropHook.js
index ffaa86d5de..959db6bf26 100644
--- a/src/renderers/dom/shared/devtools/ReactDOMNullInputValuePropDevtool.js
+++ b/src/renderers/dom/shared/hooks/ReactDOMNullInputValuePropHook.js
@@ -6,12 +6,12 @@
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
- * @providesModule ReactDOMNullInputValuePropDevtool
+ * @providesModule ReactDOMNullInputValuePropHook
*/
'use strict';
-var ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
+var ReactComponentTreeHook = require('ReactComponentTreeHook');
var warning = require('warning');
@@ -31,14 +31,14 @@ function handleElement(debugID, element) {
'Consider using the empty string to clear the component or `undefined` ' +
'for uncontrolled components.%s',
element.type,
- ReactComponentTreeDevtool.getStackAddendumByID(debugID)
+ ReactComponentTreeHook.getStackAddendumByID(debugID)
);
didWarnValueNull = true;
}
}
-var ReactDOMUnknownPropertyDevtool = {
+var ReactDOMNullInputValuePropHook = {
onBeforeMountComponent(debugID, element) {
handleElement(debugID, element);
},
@@ -47,4 +47,4 @@ var ReactDOMUnknownPropertyDevtool = {
},
};
-module.exports = ReactDOMUnknownPropertyDevtool;
+module.exports = ReactDOMNullInputValuePropHook;
diff --git a/src/renderers/dom/shared/devtools/ReactDOMUnknownPropertyDevtool.js b/src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
similarity index 89%
rename from src/renderers/dom/shared/devtools/ReactDOMUnknownPropertyDevtool.js
rename to src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
index e37be4a257..6df617e261 100644
--- a/src/renderers/dom/shared/devtools/ReactDOMUnknownPropertyDevtool.js
+++ b/src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
@@ -6,14 +6,14 @@
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
- * @providesModule ReactDOMUnknownPropertyDevtool
+ * @providesModule ReactDOMUnknownPropertyHook
*/
'use strict';
var DOMProperty = require('DOMProperty');
var EventPluginRegistry = require('EventPluginRegistry');
-var ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
+var ReactComponentTreeHook = require('ReactComponentTreeHook');
var warning = require('warning');
@@ -73,7 +73,7 @@ if (__DEV__) {
'Unknown DOM property %s. Did you mean %s?%s',
name,
standardName,
- ReactComponentTreeDevtool.getStackAddendumByID(debugID)
+ ReactComponentTreeHook.getStackAddendumByID(debugID)
);
return true;
} else if (registrationName != null) {
@@ -82,7 +82,7 @@ if (__DEV__) {
'Unknown event handler property %s. Did you mean `%s`?%s',
name,
registrationName,
- ReactComponentTreeDevtool.getStackAddendumByID(debugID)
+ ReactComponentTreeHook.getStackAddendumByID(debugID)
);
return true;
} else {
@@ -115,7 +115,7 @@ var warnUnknownProperties = function(debugID, element) {
'For details, see https://fb.me/react-unknown-prop%s',
unknownPropString,
element.type,
- ReactComponentTreeDevtool.getStackAddendumByID(debugID)
+ ReactComponentTreeHook.getStackAddendumByID(debugID)
);
} else if (unknownProps.length > 1) {
warning(
@@ -124,7 +124,7 @@ var warnUnknownProperties = function(debugID, element) {
'For details, see https://fb.me/react-unknown-prop%s',
unknownPropString,
element.type,
- ReactComponentTreeDevtool.getStackAddendumByID(debugID)
+ ReactComponentTreeHook.getStackAddendumByID(debugID)
);
}
};
@@ -139,7 +139,7 @@ function handleElement(debugID, element) {
warnUnknownProperties(debugID, element);
}
-var ReactDOMUnknownPropertyDevtool = {
+var ReactDOMUnknownPropertyHook = {
onBeforeMountComponent(debugID, element) {
handleElement(debugID, element);
},
@@ -148,4 +148,4 @@ var ReactDOMUnknownPropertyDevtool = {
},
};
-module.exports = ReactDOMUnknownPropertyDevtool;
+module.exports = ReactDOMUnknownPropertyHook;
diff --git a/src/renderers/shared/ReactDebugTool.js b/src/renderers/shared/ReactDebugTool.js
index e8c5d2f16d..4882f47a20 100644
--- a/src/renderers/shared/ReactDebugTool.js
+++ b/src/renderers/shared/ReactDebugTool.js
@@ -11,10 +11,10 @@
'use strict';
-var ReactInvalidSetStateWarningDevTool = require('ReactInvalidSetStateWarningDevTool');
-var ReactHostOperationHistoryDevtool = require('ReactHostOperationHistoryDevtool');
-var ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
-var ReactChildrenMutationWarningDevtool = require('ReactChildrenMutationWarningDevtool');
+var ReactInvalidSetStateWarningHook = require('ReactInvalidSetStateWarningHook');
+var ReactHostOperationHistoryHook = require('ReactHostOperationHistoryHook');
+var ReactComponentTreeHook = require('ReactComponentTreeHook');
+var ReactChildrenMutationWarningHook = require('ReactChildrenMutationWarningHook');
var ExecutionEnvironment = require('ExecutionEnvironment');
var performanceNow = require('performanceNow');
@@ -32,7 +32,7 @@ function emitEvent(handlerFunctionName, arg1, arg2, arg3, arg4, arg5) {
} catch (e) {
warning(
handlerDoesThrowForEvent[handlerFunctionName],
- 'exception thrown by devtool while handling %s: %s',
+ 'exception thrown by hook while handling %s: %s',
handlerFunctionName,
e + '\n' + e.stack
);
@@ -55,21 +55,21 @@ var currentTimerType = null;
var lifeCycleTimerHasWarned = false;
function clearHistory() {
- ReactComponentTreeDevtool.purgeUnmountedComponents();
- ReactHostOperationHistoryDevtool.clearHistory();
+ ReactComponentTreeHook.purgeUnmountedComponents();
+ ReactHostOperationHistoryHook.clearHistory();
}
function getTreeSnapshot(registeredIDs) {
return registeredIDs.reduce((tree, id) => {
- var ownerID = ReactComponentTreeDevtool.getOwnerID(id);
- var parentID = ReactComponentTreeDevtool.getParentID(id);
+ var ownerID = ReactComponentTreeHook.getOwnerID(id);
+ var parentID = ReactComponentTreeHook.getParentID(id);
tree[id] = {
- displayName: ReactComponentTreeDevtool.getDisplayName(id),
- text: ReactComponentTreeDevtool.getText(id),
- updateCount: ReactComponentTreeDevtool.getUpdateCount(id),
- childIDs: ReactComponentTreeDevtool.getChildIDs(id),
+ displayName: ReactComponentTreeHook.getDisplayName(id),
+ text: ReactComponentTreeHook.getText(id),
+ updateCount: ReactComponentTreeHook.getUpdateCount(id),
+ childIDs: ReactComponentTreeHook.getChildIDs(id),
// Text nodes don't have owners but this is close enough.
- ownerID: ownerID || ReactComponentTreeDevtool.getOwnerID(parentID),
+ ownerID: ownerID || ReactComponentTreeHook.getOwnerID(parentID),
parentID,
};
return tree;
@@ -79,7 +79,7 @@ function getTreeSnapshot(registeredIDs) {
function resetMeasurements() {
var previousStartTime = currentFlushStartTime;
var previousMeasurements = currentFlushMeasurements || [];
- var previousOperations = ReactHostOperationHistoryDevtool.getHistory();
+ var previousOperations = ReactHostOperationHistoryHook.getHistory();
if (currentFlushNesting === 0) {
currentFlushStartTime = null;
@@ -89,7 +89,7 @@ function resetMeasurements() {
}
if (previousMeasurements.length || previousOperations.length) {
- var registeredIDs = ReactComponentTreeDevtool.getRegisteredIDs();
+ var registeredIDs = ReactComponentTreeHook.getRegisteredIDs();
flushHistory.push({
duration: performanceNow() - previousStartTime,
measurements: previousMeasurements || [],
@@ -182,12 +182,12 @@ function resumeCurrentLifeCycleTimer() {
}
var ReactDebugTool = {
- addDevtool(devtool) {
- eventHandlers.push(devtool);
+ addHook(hook) {
+ eventHandlers.push(hook);
},
- removeDevtool(devtool) {
+ removeHook(hook) {
for (var i = 0; i < eventHandlers.length; i++) {
- if (eventHandlers[i] === devtool) {
+ if (eventHandlers[i] === hook) {
eventHandlers.splice(i, 1);
i--;
}
@@ -204,7 +204,7 @@ var ReactDebugTool = {
isProfiling = true;
flushHistory.length = 0;
resetMeasurements();
- ReactDebugTool.addDevtool(ReactHostOperationHistoryDevtool);
+ ReactDebugTool.addHook(ReactHostOperationHistoryHook);
},
endProfiling() {
if (!isProfiling) {
@@ -213,7 +213,7 @@ var ReactDebugTool = {
isProfiling = false;
resetMeasurements();
- ReactDebugTool.removeDevtool(ReactHostOperationHistoryDevtool);
+ ReactDebugTool.removeHook(ReactHostOperationHistoryHook);
},
getFlushHistory() {
return flushHistory;
@@ -325,9 +325,13 @@ var ReactDebugTool = {
},
};
-ReactDebugTool.addDevtool(ReactInvalidSetStateWarningDevTool);
-ReactDebugTool.addDevtool(ReactComponentTreeDevtool);
-ReactDebugTool.addDevtool(ReactChildrenMutationWarningDevtool);
+// TODO remove these when RN/www gets updated
+ReactDebugTool.addDevtool = ReactDebugTool.addHook;
+ReactDebugTool.removeDevtool = ReactDebugTool.removeHook;
+
+ReactDebugTool.addHook(ReactInvalidSetStateWarningHook);
+ReactDebugTool.addHook(ReactComponentTreeHook);
+ReactDebugTool.addHook(ReactChildrenMutationWarningHook);
var url = (ExecutionEnvironment.canUseDOM && window.location.href) || '';
if ((/[?&]react_perf\b/).test(url)) {
ReactDebugTool.beginProfiling();
diff --git a/src/renderers/shared/__tests__/ReactDebugTool-test.js b/src/renderers/shared/__tests__/ReactDebugTool-test.js
index 15efcb5d1e..0eb809cdbc 100644
--- a/src/renderers/shared/__tests__/ReactDebugTool-test.js
+++ b/src/renderers/shared/__tests__/ReactDebugTool-test.js
@@ -19,13 +19,13 @@ describe('ReactDebugTool', function() {
ReactDebugTool = require('ReactDebugTool');
});
- it('should add and remove devtools', () => {
+ it('should add and remove hooks', () => {
var handler1 = jasmine.createSpy('spy');
var handler2 = jasmine.createSpy('spy');
- var devtool1 = {onTestEvent: handler1};
- var devtool2 = {onTestEvent: handler2};
+ var hook1 = {onTestEvent: handler1};
+ var hook2 = {onTestEvent: handler2};
- ReactDebugTool.addDevtool(devtool1);
+ ReactDebugTool.addHook(hook1);
ReactDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(1);
expect(handler2.calls.count()).toBe(0);
@@ -34,7 +34,7 @@ describe('ReactDebugTool', function() {
expect(handler1.calls.count()).toBe(2);
expect(handler2.calls.count()).toBe(0);
- ReactDebugTool.addDevtool(devtool2);
+ ReactDebugTool.addHook(hook2);
ReactDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(3);
expect(handler2.calls.count()).toBe(1);
@@ -43,20 +43,20 @@ describe('ReactDebugTool', function() {
expect(handler1.calls.count()).toBe(4);
expect(handler2.calls.count()).toBe(2);
- ReactDebugTool.removeDevtool(devtool1);
+ ReactDebugTool.removeHook(hook1);
ReactDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(4);
expect(handler2.calls.count()).toBe(3);
- ReactDebugTool.removeDevtool(devtool2);
+ ReactDebugTool.removeHook(hook2);
ReactDebugTool.onTestEvent();
expect(handler1.calls.count()).toBe(4);
expect(handler2.calls.count()).toBe(3);
});
- it('warns once when an error is thrown in devtool', () => {
+ it('warns once when an error is thrown in hook', () => {
spyOn(console, 'error');
- ReactDebugTool.addDevtool({
+ ReactDebugTool.addHook({
onTestEvent() {
throw new Error('Hi.');
},
@@ -65,7 +65,7 @@ describe('ReactDebugTool', function() {
ReactDebugTool.onTestEvent();
expect(console.error.calls.count()).toBe(1);
expect(console.error.calls.argsFor(0)[0]).toContain(
- 'exception thrown by devtool while handling ' +
+ 'exception thrown by hook while handling ' +
'onTestEvent: Error: Hi.'
);
diff --git a/src/renderers/shared/devtools/ReactChildrenMutationWarningDevtool.js b/src/renderers/shared/hooks/ReactChildrenMutationWarningHook.js
similarity index 84%
rename from src/renderers/shared/devtools/ReactChildrenMutationWarningDevtool.js
rename to src/renderers/shared/hooks/ReactChildrenMutationWarningHook.js
index 9cde836a27..fccc153854 100644
--- a/src/renderers/shared/devtools/ReactChildrenMutationWarningDevtool.js
+++ b/src/renderers/shared/hooks/ReactChildrenMutationWarningHook.js
@@ -6,12 +6,12 @@
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
- * @providesModule ReactChildrenMutationWarningDevtool
+ * @providesModule ReactChildrenMutationWarningHook
*/
'use strict';
-var ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
+var ReactComponentTreeHook = require('ReactComponentTreeHook');
var warning = require('warning');
@@ -42,11 +42,11 @@ function handleElement(debugID, element) {
warning(
Array.isArray(element._shadowChildren) && !isMutated,
'Component\'s children should not be mutated.%s',
- ReactComponentTreeDevtool.getStackAddendumByID(debugID),
+ ReactComponentTreeHook.getStackAddendumByID(debugID),
);
}
-var ReactDOMUnknownPropertyDevtool = {
+var ReactDOMUnknownPropertyHook = {
onBeforeMountComponent(debugID, element) {
elements[debugID] = element;
},
@@ -63,4 +63,4 @@ var ReactDOMUnknownPropertyDevtool = {
},
};
-module.exports = ReactDOMUnknownPropertyDevtool;
+module.exports = ReactDOMUnknownPropertyHook;
diff --git a/src/renderers/shared/devtools/ReactHostOperationHistoryDevtool.js b/src/renderers/shared/hooks/ReactHostOperationHistoryHook.js
similarity index 75%
rename from src/renderers/shared/devtools/ReactHostOperationHistoryDevtool.js
rename to src/renderers/shared/hooks/ReactHostOperationHistoryHook.js
index 475f1bace8..48456caea9 100644
--- a/src/renderers/shared/devtools/ReactHostOperationHistoryDevtool.js
+++ b/src/renderers/shared/hooks/ReactHostOperationHistoryHook.js
@@ -6,14 +6,14 @@
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
- * @providesModule ReactHostOperationHistoryDevtool
+ * @providesModule ReactHostOperationHistoryHook
*/
'use strict';
var history = [];
-var ReactHostOperationHistoryDevtool = {
+var ReactHostOperationHistoryHook = {
onHostOperation(debugID, type, payload) {
history.push({
instanceID: debugID,
@@ -23,7 +23,7 @@ var ReactHostOperationHistoryDevtool = {
},
clearHistory() {
- if (ReactHostOperationHistoryDevtool._preventClearing) {
+ if (ReactHostOperationHistoryHook._preventClearing) {
// Should only be used for tests.
return;
}
@@ -36,4 +36,4 @@ var ReactHostOperationHistoryDevtool = {
},
};
-module.exports = ReactHostOperationHistoryDevtool;
+module.exports = ReactHostOperationHistoryHook;
diff --git a/src/renderers/shared/devtools/ReactInvalidSetStateWarningDevTool.js b/src/renderers/shared/hooks/ReactInvalidSetStateWarningHook.js
similarity index 84%
rename from src/renderers/shared/devtools/ReactInvalidSetStateWarningDevTool.js
rename to src/renderers/shared/hooks/ReactInvalidSetStateWarningHook.js
index 74275187cb..4e47ced0d4 100644
--- a/src/renderers/shared/devtools/ReactInvalidSetStateWarningDevTool.js
+++ b/src/renderers/shared/hooks/ReactInvalidSetStateWarningHook.js
@@ -6,7 +6,7 @@
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
- * @providesModule ReactInvalidSetStateWarningDevTool
+ * @providesModule ReactInvalidSetStateWarningHook
*/
'use strict';
@@ -24,7 +24,7 @@ if (__DEV__) {
};
}
-var ReactInvalidSetStateWarningDevTool = {
+var ReactInvalidSetStateWarningHook = {
onBeginProcessingChildContext() {
processingChildContext = true;
},
@@ -36,4 +36,4 @@ var ReactInvalidSetStateWarningDevTool = {
},
};
-module.exports = ReactInvalidSetStateWarningDevTool;
+module.exports = ReactInvalidSetStateWarningHook;
diff --git a/src/renderers/shared/devtools/__tests__/ReactComponentTreeDevtool-test.js b/src/renderers/shared/hooks/__tests__/ReactComponentTreeHook-test.js
similarity index 96%
rename from src/renderers/shared/devtools/__tests__/ReactComponentTreeDevtool-test.js
rename to src/renderers/shared/hooks/__tests__/ReactComponentTreeHook-test.js
index 9df5410652..28f3d931a1 100644
--- a/src/renderers/shared/devtools/__tests__/ReactComponentTreeDevtool-test.js
+++ b/src/renderers/shared/hooks/__tests__/ReactComponentTreeHook-test.js
@@ -11,12 +11,12 @@
'use strict';
-describe('ReactComponentTreeDevtool', () => {
+describe('ReactComponentTreeHook', () => {
var React;
var ReactDOM;
var ReactDOMServer;
var ReactInstanceMap;
- var ReactComponentTreeDevtool;
+ var ReactComponentTreeHook;
var ReactComponentTreeTestUtils;
beforeEach(() => {
@@ -26,7 +26,7 @@ describe('ReactComponentTreeDevtool', () => {
ReactDOM = require('ReactDOM');
ReactDOMServer = require('ReactDOMServer');
ReactInstanceMap = require('ReactInstanceMap');
- ReactComponentTreeDevtool = require('ReactComponentTreeDevtool');
+ ReactComponentTreeHook = require('ReactComponentTreeHook');
ReactComponentTreeTestUtils = require('ReactComponentTreeTestUtils');
});
@@ -68,7 +68,7 @@ describe('ReactComponentTreeDevtool', () => {
// Purging should have no effect
// on the tree we expect to see.
- ReactComponentTreeDevtool.purgeUnmountedComponents();
+ ReactComponentTreeHook.purgeUnmountedComponents();
expectWrapperTreeToEqual(expectedTree);
});
@@ -87,16 +87,16 @@ describe('ReactComponentTreeDevtool', () => {
ReactDOMServer.renderToString(
Hi.