Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename this tip to be less confusing

Browse Source 
Using props to initialize state is completely fine; the issue is using state as a "cache" for values calculated based off of props. This title makes it more clear.
This commit is contained in:
Jared Forsyth
2013-12-23 06:11:03 +01:00
committed by Vjeux
parent 38d68fd1c5
commit 9686487e3a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/tips/10-props-in-getInitialState-as-anti-pattern.md
+2 -2
View File
@@ -1,6 +1,6 @@
--- ---
id: props-in-getInitialState-as-anti-pattern id: props-in-getInitialState-as-anti-pattern
title: Props in getInitialState Is an Anti-Pattern title: Using state to cache calculations is an antipattern
layout: tips layout: tips
permalink: props-in-getInitialState-as-anti-pattern.html permalink: props-in-getInitialState-as-anti-pattern.html
prev: componentWillReceiveProps-not-triggered-after-mounting.html prev: componentWillReceiveProps-not-triggered-after-mounting.html
@@ -11,7 +11,7 @@ next: dom-event-listeners.html
> >
> This isn't really a React-specific tip, as such anti-patterns often occur in code in general; in this case, React simply points them out more clearly. > This isn't really a React-specific tip, as such anti-patterns often occur in code in general; in this case, React simply points them out more clearly.
Using props, passed down from parent, to generate state in `getInitialState` often leads to duplication of "source of truth", i.e. where the real data is. Whenever possible, compute values on-the-fly to ensure that they don't get out of sync later on and cause maintenance trouble. Using state to cache values calculated from props (for example in `getInitialState`) often leads to duplication of "source of truth", i.e. where the real data is. Whenever possible, compute values on-the-fly to ensure that they don't get out of sync later on and cause maintenance trouble.
Bad example: Bad example: