From 94aab74253142b4468f38253178c2d7ca80f1a15 Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Thu, 14 Feb 2019 08:13:35 -0800 Subject: [PATCH] Avoid NPE in Agent if renderer can't be found for an ID --- src/backend/agent.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/backend/agent.js b/src/backend/agent.js index 93af405785..b23ff86d75 100644 --- a/src/backend/agent.js +++ b/src/backend/agent.js @@ -73,16 +73,18 @@ export default class Agent extends EventEmitter { const renderer = this._rendererInterfaces[rendererID]; if (renderer == null) { console.warn(`Invalid renderer id "${rendererID}" for element "${id}"`); + } else { + this._bridge.send('inspectedElement', renderer.inspectElement(id)); } - this._bridge.send('inspectedElement', renderer.inspectElement(id)); }; selectElement = ({ id, rendererID }: { id: number, rendererID: number }) => { const renderer = this._rendererInterfaces[rendererID]; if (renderer == null) { console.warn(`Invalid renderer id "${rendererID}" for element "${id}"`); + } else { + this._bridge.send('selectElement', renderer.selectElement(id)); } - this._bridge.send('selectElement', renderer.selectElement(id)); }; setRendererInterface(