From 8f998bf93fdc417ea9e8f99dedfe3a7c3d6e5bbc Mon Sep 17 00:00:00 2001 From: Matt Carroll <7158882+mattcarrollcode@users.noreply.github.com> Date: Fri, 26 Jan 2024 13:17:44 -0800 Subject: [PATCH] Convert SyntheticEvent-test.js to createRoot (#28118) --- .../events/__tests__/SyntheticEvent-test.js | 32 ++++++++++++++----- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/packages/react-dom/src/events/__tests__/SyntheticEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticEvent-test.js index 6ff89d742f..c6ca1d1733 100644 --- a/packages/react-dom/src/events/__tests__/SyntheticEvent-test.js +++ b/packages/react-dom/src/events/__tests__/SyntheticEvent-test.js @@ -10,16 +10,20 @@ 'use strict'; let React; -let ReactDOM; +let ReactDOMClient; +let act; describe('SyntheticEvent', () => { let container; + let root; beforeEach(() => { React = require('react'); - ReactDOM = require('react-dom'); + ReactDOMClient = require('react-dom/client'); + act = require('internal-test-utils').act; container = document.createElement('div'); + root = ReactDOMClient.createRoot(container); document.body.appendChild(container); }); @@ -28,7 +32,7 @@ describe('SyntheticEvent', () => { container = null; }); - it('should be able to `preventDefault`', () => { + it('should be able to `preventDefault`', async () => { let expectedCount = 0; const eventHandler = syntheticEvent => { @@ -39,7 +43,11 @@ describe('SyntheticEvent', () => { expectedCount++; }; - const node = ReactDOM.render(
, container); + const nodeRef = React.createRef(); + await act(async () => { + root.render(); + }); + const node = nodeRef.current; const event = document.createEvent('Event'); event.initEvent('click', true, true); @@ -48,7 +56,7 @@ describe('SyntheticEvent', () => { expect(expectedCount).toBe(1); }); - it('should be prevented if nativeEvent is prevented', () => { + it('should be prevented if nativeEvent is prevented', async () => { let expectedCount = 0; const eventHandler = syntheticEvent => { @@ -56,7 +64,11 @@ describe('SyntheticEvent', () => { expectedCount++; }; - const node = ReactDOM.render(, container); + const nodeRef = React.createRef(); + await act(async () => { + root.render(); + }); + const node = nodeRef.current; let event; event = document.createEvent('Event'); @@ -80,7 +92,7 @@ describe('SyntheticEvent', () => { expect(expectedCount).toBe(2); }); - it('should be able to `stopPropagation`', () => { + it('should be able to `stopPropagation`', async () => { let expectedCount = 0; const eventHandler = syntheticEvent => { @@ -90,7 +102,11 @@ describe('SyntheticEvent', () => { expectedCount++; }; - const node = ReactDOM.render(, container); + const nodeRef = React.createRef(); + await act(async () => { + root.render(); + }); + const node = nodeRef.current; const event = document.createEvent('Event'); event.initEvent('click', true, true);