From 8890db707bd9cf535ccb5cbbfa87a7f4564fe399 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Wed, 2 Aug 2017 20:04:49 +0100 Subject: [PATCH] Don't suggest downloading React DevTools inside Chrome extension (#10359) --- src/renderers/dom/fiber/ReactDOMFiberEntry.js | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/renderers/dom/fiber/ReactDOMFiberEntry.js b/src/renderers/dom/fiber/ReactDOMFiberEntry.js index 98a19eb957..b9af1b9ea4 100644 --- a/src/renderers/dom/fiber/ReactDOMFiberEntry.js +++ b/src/renderers/dom/fiber/ReactDOMFiberEntry.js @@ -825,17 +825,20 @@ if (__DEV__) { navigator.userAgent.indexOf('Edge') === -1) || navigator.userAgent.indexOf('Firefox') > -1 ) { - var showFileUrlMessage = window.location.protocol.indexOf('http') === -1; - console.info( - '%cDownload the React DevTools ' + - 'for a better development experience: ' + - 'https://fb.me/react-devtools' + - (showFileUrlMessage - ? '\nYou might need to use a local HTTP server (instead of file://): ' + - 'https://fb.me/react-devtools-faq' - : ''), - 'font-weight:bold', - ); + const protocol = window.location.protocol; + // Don't warn in exotic cases like chrome-extension://. + if (/^(https?|file):$/.test(protocol)) { + console.info( + '%cDownload the React DevTools ' + + 'for a better development experience: ' + + 'https://fb.me/react-devtools' + + (protocol === 'file:' + ? '\nYou might need to use a local HTTP server (instead of file://): ' + + 'https://fb.me/react-devtools-faq' + : ''), + 'font-weight:bold', + ); + } } } }