mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Fix typo in dangerfile.js which results in an unreachable code path… (#32277)
## Summary Fix typo in dangerfile.js which results in an unreachable code path which ought to be hit when there is no matching base artifact during DangerCI automated code review. See: https://github.com/facebook/react/blob/221f3002caa2314cba0a62950da6fb92b453d1d0/dangerfile.js#L73 Compare: https://github.com/facebook/react/blob/221f3002caa2314cba0a62950da6fb92b453d1d0/dangerfile.js#L171 And the case which should hit this code path: https://github.com/facebook/react/blob/221f3002caa2314cba0a62950da6fb92b453d1d0/dangerfile.js#L160 Given the above context, the condition `Number === Infinity` is clearly meant to be `decimal === Infinity`, which it will be if the `catch` statement triggers when there is no matching base artifact. Without this fix, the primitive value `Infinity` is passed to `percentFormatter.format(decimal)`, resulting in the string `'+∞%'`. With this fix, the resulting string will be the intended `'New file'`. ## [Resolves issue 32278](https://github.com/facebook/react/issues/32278)
This commit is contained in:
committed by
GitHub
parent
221f3002ca
commit
87c03a0a13
+1
-1
@@ -70,7 +70,7 @@ const percentFormatter = new Intl.NumberFormat('en', {
|
||||
});
|
||||
|
||||
function change(decimal) {
|
||||
if (Number === Infinity) {
|
||||
if (decimal === Infinity) {
|
||||
return 'New file';
|
||||
}
|
||||
if (decimal === -1) {
|
||||
|
||||
Reference in New Issue
Block a user