From 810dff656e3ef01a19c60feb692a342f248ba90f Mon Sep 17 00:00:00 2001 From: sebmarkbage Date: Mon, 10 Jun 2024 22:46:48 +0000 Subject: [PATCH] Remove Warning: prefix and toString on console Arguments (#29839) Basically make `console.error` and `console.warn` behave like normal - when a component stack isn't appended. I need this because I need to be able to print rich logs with the component stack option and to be able to disable instrumentation completely in `console.createTask` environments that don't need it. Currently we can't print logs with richer objects because they're toString:ed first. In practice, pretty much all arguments we log are already toString:ed so it's not necessary anyway. Some might be like a number. So it would only be a problem if some environment can't handle proper consoles but then it's up to that environment to toString it before logging. The `Warning: ` prefix is historic and is both noisy and confusing. It's mostly unnecessary since the UI surrounding `console.error` and `console.warn` tend to have visual treatment around it anyway. However, it's actively misleading when `console.error` gets prefixed with a Warning that we consider an error level. There's an argument to be made that some of our `console.error` don't make the bar for an error but then the argument is to downgrade each of those to `console.warn` - not to brand all our actual error logging with `Warning: `. Apparently something needs to change in React Native before landing this because it depends on the prefix somehow which probably doesn't make sense already. DiffTrain build for commit https://github.com/facebook/react/commit/277420803947724b43c47bbc47d3a353553868f1. --- compiled-rn/VERSION_NATIVE_FB | 2 +- .../cjs/ReactTestRenderer-dev.js | 15 ++++-------- .../cjs/ReactTestRenderer-prod.js | 6 ++--- .../cjs/ReactTestRenderer-profiling.js | 6 ++--- .../react/react/cjs/JSXDEVRuntime-dev.js | 23 ++++++------------- .../vendor/react/react/cjs/JSXRuntime-dev.js | 23 ++++++------------- .../vendor/react/react/cjs/React-dev.js | 13 +++-------- .../vendor/react/react/cjs/React-prod.js | 4 ++-- .../vendor/react/react/cjs/React-profiling.js | 4 ++-- .../Libraries/Renderer/REVISION | 2 +- .../implementations/ReactFabric-dev.fb.js | 15 ++++-------- .../implementations/ReactFabric-prod.fb.js | 6 ++--- .../ReactFabric-profiling.fb.js | 6 ++--- .../ReactNativeRenderer-dev.fb.js | 21 ++++++----------- .../ReactNativeRenderer-prod.fb.js | 10 ++++---- .../ReactNativeRenderer-profiling.fb.js | 10 ++++---- 16 files changed, 60 insertions(+), 106 deletions(-) diff --git a/compiled-rn/VERSION_NATIVE_FB b/compiled-rn/VERSION_NATIVE_FB index 52e196fe83..c095a997fb 100644 --- a/compiled-rn/VERSION_NATIVE_FB +++ b/compiled-rn/VERSION_NATIVE_FB @@ -1 +1 @@ -19.0.0-native-fb-bf1bb2e5e5-20240610 \ No newline at end of file +19.0.0-native-fb-2774208039-20240610 \ No newline at end of file diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js index 636b4c72e8..22de67b6bf 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<> */ "use strict"; @@ -152,18 +152,11 @@ __DEV__ && printWarning("error", format, args, Error("react-stack-top-frame")); } function printWarning(level, format, args, currentStack) { - var isErrorLogger = - "%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format; ReactSharedInternals.getCurrentStack && ((currentStack = ReactSharedInternals.getCurrentStack(currentStack)), "" !== currentStack && ((format += "%s"), (args = args.concat([currentStack])))); - isErrorLogger - ? args.unshift(format) - : ((args = args.map(function (item) { - return String(item); - })), - args.unshift("Warning: " + format)); + args.unshift(format); Function.prototype.apply.call(console[level], console, args); } function _defineProperties(target, props) { @@ -15049,14 +15042,14 @@ __DEV__ && scheduleRoot: scheduleRoot, setRefreshHandler: setRefreshHandler, getCurrentFiber: getCurrentFiberForDevTools, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }); })({ findFiberByHostInstance: function () { throw Error("TestRenderer does not support findFiberByHostInstance()"); }, bundleType: 1, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-test-renderer" }); exports._Scheduler = Scheduler; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js index 8332e64d63..d97cfaf9e7 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<9920f84659406d21dcf5429e76df93eb>> + * @generated SignedSource<> */ "use strict"; @@ -9336,7 +9336,7 @@ var devToolsConfig$jscomp$inline_1048 = { throw Error("TestRenderer does not support findFiberByHostInstance()"); }, bundleType: 0, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-test-renderer" }; var internals$jscomp$inline_1235 = { @@ -9367,7 +9367,7 @@ var internals$jscomp$inline_1235 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js index a8cf08171b..f26afac05e 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<8346d33fcde7920e58c0769c267354c4>> + * @generated SignedSource<> */ "use strict"; @@ -9958,7 +9958,7 @@ var devToolsConfig$jscomp$inline_1131 = { throw Error("TestRenderer does not support findFiberByHostInstance()"); }, bundleType: 0, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-test-renderer" }; (function (internals) { @@ -10002,7 +10002,7 @@ var devToolsConfig$jscomp$inline_1131 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }); exports._Scheduler = Scheduler; exports.act = act; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXDEVRuntime-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXDEVRuntime-dev.js index 8fc49461ea..da423f57b7 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXDEVRuntime-dev.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXDEVRuntime-dev.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<9e2dad0789cdb57b65878831989d6b55>> + * @generated SignedSource<> */ "use strict"; @@ -22,22 +22,13 @@ __DEV__ && _key2++ ) args[_key2 - 1] = arguments[_key2]; - printWarning("error", format, args, Error("react-stack-top-frame")); - } - function printWarning(level, format, args, currentStack) { - var isErrorLogger = - "%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format; + _len2 = format; + _key2 = Error("react-stack-top-frame"); ReactSharedInternals.getCurrentStack && - ((currentStack = ReactSharedInternals.getCurrentStack(currentStack)), - "" !== currentStack && - ((format += "%s"), (args = args.concat([currentStack])))); - isErrorLogger - ? args.unshift(format) - : ((args = args.map(function (item) { - return String(item); - })), - args.unshift("Warning: " + format)); - Function.prototype.apply.call(console[level], console, args); + ((_key2 = ReactSharedInternals.getCurrentStack(_key2)), + "" !== _key2 && ((_len2 += "%s"), (args = args.concat([_key2])))); + args.unshift(_len2); + Function.prototype.apply.call(console.error, console, args); } function getComponentNameFromType(type) { if (null == type) return null; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXRuntime-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXRuntime-dev.js index 8110a981a1..e786b8452d 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXRuntime-dev.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXRuntime-dev.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<4d095073d7f6f1a36d5b981e9c2a52aa>> + * @generated SignedSource<<1e831dc318079da75149235e0e09d92d>> */ "use strict"; @@ -22,22 +22,13 @@ __DEV__ && _key2++ ) args[_key2 - 1] = arguments[_key2]; - printWarning("error", format, args, Error("react-stack-top-frame")); - } - function printWarning(level, format, args, currentStack) { - var isErrorLogger = - "%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format; + _len2 = format; + _key2 = Error("react-stack-top-frame"); ReactSharedInternals.getCurrentStack && - ((currentStack = ReactSharedInternals.getCurrentStack(currentStack)), - "" !== currentStack && - ((format += "%s"), (args = args.concat([currentStack])))); - isErrorLogger - ? args.unshift(format) - : ((args = args.map(function (item) { - return String(item); - })), - args.unshift("Warning: " + format)); - Function.prototype.apply.call(console[level], console, args); + ((_key2 = ReactSharedInternals.getCurrentStack(_key2)), + "" !== _key2 && ((_len2 += "%s"), (args = args.concat([_key2])))); + args.unshift(_len2); + Function.prototype.apply.call(console.error, console, args); } function getComponentNameFromType(type) { if (null == type) return null; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js index b9aaafe4ce..900aa16a5f 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<<4e0e4b457140b7f25071b271f8f187d2>> */ "use strict"; @@ -55,18 +55,11 @@ __DEV__ && printWarning("error", format, args, Error("react-stack-top-frame")); } function printWarning(level, format, args, currentStack) { - var isErrorLogger = - "%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format; ReactSharedInternals.getCurrentStack && ((currentStack = ReactSharedInternals.getCurrentStack(currentStack)), "" !== currentStack && ((format += "%s"), (args = args.concat([currentStack])))); - isErrorLogger - ? args.unshift(format) - : ((args = args.map(function (item) { - return String(item); - })), - args.unshift("Warning: " + format)); + args.unshift(format); Function.prototype.apply.call(console[level], console, args); } function warnNoop(publicInstance, callerName) { @@ -1748,7 +1741,7 @@ __DEV__ && exports.useTransition = function () { return resolveDispatcher().useTransition(); }; - exports.version = "19.0.0-native-fb-bf1bb2e5e5-20240610"; + exports.version = "19.0.0-native-fb-2774208039-20240610"; "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ && "function" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop && diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js index 6e76d39e81..c9fe92e5e6 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<2c83bccf84bb8a9740b77d55bf1f96ca>> + * @generated SignedSource<<138668c29d55fc3ae4dbdcec9581ff7b>> */ "use strict"; @@ -604,4 +604,4 @@ exports.useSyncExternalStore = function ( exports.useTransition = function () { return ReactSharedInternals.H.useTransition(); }; -exports.version = "19.0.0-native-fb-bf1bb2e5e5-20240610"; +exports.version = "19.0.0-native-fb-2774208039-20240610"; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js index ecb211cbef..a21cb24c13 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<2d729030ac0bf8fa0eb464bb2f16e724>> + * @generated SignedSource<<540135ee9c1a9fde97799dda98a4b743>> */ "use strict"; @@ -608,7 +608,7 @@ exports.useSyncExternalStore = function ( exports.useTransition = function () { return ReactSharedInternals.H.useTransition(); }; -exports.version = "19.0.0-native-fb-bf1bb2e5e5-20240610"; +exports.version = "19.0.0-native-fb-2774208039-20240610"; "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ && "function" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop && diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION index a050b9ec3b..cc1790e980 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION @@ -1 +1 @@ -bf1bb2e5e52733a9577848f2913d06edcf24df14 +277420803947724b43c47bbc47d3a353553868f1 diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js index 031786bf77..28cc88265a 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<50de4ae8b3ee39790e8c9b7e11f89ad9>> + * @generated SignedSource<> */ "use strict"; @@ -156,18 +156,11 @@ __DEV__ && } } function printWarning(level, format, args, currentStack) { - var isErrorLogger = - "%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format; ReactSharedInternals.getCurrentStack && ((currentStack = ReactSharedInternals.getCurrentStack(currentStack)), "" !== currentStack && ((format += "%s"), (args = args.concat([currentStack])))); - isErrorLogger - ? args.unshift(format) - : ((args = args.map(function (item) { - return String(item); - })), - args.unshift("Warning: " + format)); + args.unshift(format); Function.prototype.apply.call(console[level], console, args); } function validateEventDispatches(event) { @@ -16681,12 +16674,12 @@ __DEV__ && scheduleRoot: scheduleRoot, setRefreshHandler: setRefreshHandler, getCurrentFiber: getCurrentFiberForDevTools, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }); })({ findFiberByHostInstance: getInstanceFromNode, bundleType: 1, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js index 6b7690aa2d..a17d5f5645 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<1dd48ba25960696fbbef43b558b17207>> + * @generated SignedSource<<1619271d414b4256cd58ad54d07e0b4a>> */ "use strict"; @@ -10591,7 +10591,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1125 = { findFiberByHostInstance: getInstanceFromNode, bundleType: 0, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -10634,7 +10634,7 @@ var internals$jscomp$inline_1351 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1352 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js index a9f7e26d96..d0b80563f5 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<> */ "use strict"; @@ -11297,7 +11297,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1206 = { findFiberByHostInstance: getInstanceFromNode, bundleType: 0, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -11353,7 +11353,7 @@ var roots = new Map(), scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }); exports.createPortal = function (children, containerTag) { return createPortal$1( diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js index 9dccd39df2..9416e7f04b 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<7faf4baf7672a196e4363c40fd86f64a>> + * @generated SignedSource<<3f15f53fe07104640c18ca42c6b3b13a>> */ "use strict"; @@ -156,18 +156,11 @@ __DEV__ && } } function printWarning(level, format, args, currentStack) { - var isErrorLogger = - "%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format; ReactSharedInternals.getCurrentStack && ((currentStack = ReactSharedInternals.getCurrentStack(currentStack)), "" !== currentStack && ((format += "%s"), (args = args.concat([currentStack])))); - isErrorLogger - ? args.unshift(format) - : ((args = args.map(function (item) { - return String(item); - })), - args.unshift("Warning: " + format)); + args.unshift(format); Function.prototype.apply.call(console[level], console, args); } function validateEventDispatches(event) { @@ -15060,7 +15053,7 @@ __DEV__ && (relativeNode = relativeToNativeNode._nativeTag); null == relativeNode ? error$jscomp$0( - "Warning: ref.measureLayout must be called with a node handle or a ref to a native component." + "ref.measureLayout must be called with a node handle or a ref to a native component." ) : ReactNativePrivateInterface.UIManager.measureLayout( this._nativeTag, @@ -16870,11 +16863,11 @@ __DEV__ && var emptyObject = {}; Object.freeze(emptyObject); var isomorphicReactPackageVersion = React.version; - if ("19.0.0-native-fb-bf1bb2e5e5-20240610" !== isomorphicReactPackageVersion) + if ("19.0.0-native-fb-2774208039-20240610" !== isomorphicReactPackageVersion) throw Error( 'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' + (isomorphicReactPackageVersion + - "\n - react-native-renderer: 19.0.0-native-fb-bf1bb2e5e5-20240610\nLearn more: https://react.dev/warnings/version-mismatch") + "\n - react-native-renderer: 19.0.0-native-fb-2774208039-20240610\nLearn more: https://react.dev/warnings/version-mismatch") ); if ( "function" !== @@ -16922,12 +16915,12 @@ __DEV__ && scheduleRoot: scheduleRoot, setRefreshHandler: setRefreshHandler, getCurrentFiber: getCurrentFiberForDevTools, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }); })({ findFiberByHostInstance: getInstanceFromTag, bundleType: 1, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js index 038b34fe7c..bcaad6fe61 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<> */ "use strict"; @@ -10734,11 +10734,11 @@ function traverseOwnerTreeUp(hierarchy, instance) { traverseOwnerTreeUp(hierarchy, instance); } var isomorphicReactPackageVersion = React.version; -if ("19.0.0-native-fb-bf1bb2e5e5-20240610" !== isomorphicReactPackageVersion) +if ("19.0.0-native-fb-2774208039-20240610" !== isomorphicReactPackageVersion) throw Error( 'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' + (isomorphicReactPackageVersion + - "\n - react-native-renderer: 19.0.0-native-fb-bf1bb2e5e5-20240610\nLearn more: https://react.dev/warnings/version-mismatch") + "\n - react-native-renderer: 19.0.0-native-fb-2774208039-20240610\nLearn more: https://react.dev/warnings/version-mismatch") ); if ( "function" !== @@ -10788,7 +10788,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1193 = { findFiberByHostInstance: getInstanceFromTag, bundleType: 0, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -10831,7 +10831,7 @@ var internals$jscomp$inline_1440 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1441 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js index 529bb9e729..5f66a5ba2e 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<<26bd930784bf9d12f1a5933e0204451c>> */ "use strict"; @@ -11441,11 +11441,11 @@ function traverseOwnerTreeUp(hierarchy, instance) { traverseOwnerTreeUp(hierarchy, instance); } var isomorphicReactPackageVersion = React.version; -if ("19.0.0-native-fb-bf1bb2e5e5-20240610" !== isomorphicReactPackageVersion) +if ("19.0.0-native-fb-2774208039-20240610" !== isomorphicReactPackageVersion) throw Error( 'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' + (isomorphicReactPackageVersion + - "\n - react-native-renderer: 19.0.0-native-fb-bf1bb2e5e5-20240610\nLearn more: https://react.dev/warnings/version-mismatch") + "\n - react-native-renderer: 19.0.0-native-fb-2774208039-20240610\nLearn more: https://react.dev/warnings/version-mismatch") ); if ( "function" !== @@ -11495,7 +11495,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1274 = { findFiberByHostInstance: getInstanceFromTag, bundleType: 0, - version: "19.0.0-native-fb-bf1bb2e5e5-20240610", + version: "19.0.0-native-fb-2774208039-20240610", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -11551,7 +11551,7 @@ var roots = new Map(), scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610" + reconcilerVersion: "19.0.0-native-fb-2774208039-20240610" }); exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = { computeComponentStackForErrorReporting: function (reactTag) {