From 7aecd58d818de7fb3dde9122be25f9c7f44eeebe Mon Sep 17 00:00:00 2001 From: Dan Date: Mon, 8 Apr 2019 23:28:31 +0100 Subject: [PATCH] Nits --- shells/browser/shared/src/main.js | 2 +- src/backend/agent.js | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/shells/browser/shared/src/main.js b/shells/browser/shared/src/main.js index 36adb1db37..d723c4cec2 100644 --- a/shells/browser/shared/src/main.js +++ b/shells/browser/shared/src/main.js @@ -184,7 +184,7 @@ function createPanelIfReactLoaded() { if (error) { console.error(error); } else if (didChangeSelection) { - bridge.send('syncSelectionFromBrowserTools'); + bridge.send('syncSelectionFromNativeElementsPanel'); } } ); diff --git a/src/backend/agent.js b/src/backend/agent.js index dae3392b56..b097578e90 100644 --- a/src/backend/agent.js +++ b/src/backend/agent.js @@ -88,8 +88,8 @@ export default class Agent extends EventEmitter { bridge.addListener('stopInspectingDOM', this.stopInspectingDOM); bridge.addListener('stopProfiling', this.stopProfiling); bridge.addListener( - 'syncSelectionFromBrowserTools', - this.syncSelectionFromBrowserTools + 'syncSelectionFromNativeElementsPanel', + this.syncSelectionFromNativeElementsPanel ); bridge.addListener('shutdown', this.shutdown); bridge.addListener('viewElementSource', this.viewElementSource); @@ -299,8 +299,7 @@ export default class Agent extends EventEmitter { // Update the active DOM node on the global hook object. // The content script will read this to update window.$0 // when we switch tabs. - let node: HTMLElement | null = null; - node = ((renderer.findNativeByFiberID(id): any): HTMLElement); + const node = ((renderer.findNativeByFiberID(id): any): HTMLElement); if (node !== null) { window.__REACT_DEVTOOLS_GLOBAL_HOOK__.$0 = node; } @@ -375,7 +374,7 @@ export default class Agent extends EventEmitter { } } - syncSelectionFromBrowserTools = () => { + syncSelectionFromNativeElementsPanel = () => { const target = window.__REACT_DEVTOOLS_GLOBAL_HOOK__.$0; if (target == null) { return;