From 78c71bc545bf5c0fdeedc023b69fafe05d988067 Mon Sep 17 00:00:00 2001 From: Ruslan Lesiutin Date: Thu, 9 Nov 2023 16:11:17 +0000 Subject: [PATCH] refactor[ci/build]: dont generate sourcemaps for BROWSER_SCRIPT bundles (#27665) Instead of https://github.com/facebook/react/pull/27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in https://github.com/facebook/react/pull/27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier. --- scripts/rollup/build.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js index 1ee8328f02..0a2a584c5a 100644 --- a/scripts/rollup/build.js +++ b/scripts/rollup/build.js @@ -406,6 +406,10 @@ function getPlugins( // UMD builds are rarely used and not worth having sourcemaps. const needsSourcemaps = needsMinifiedByClosure && + // This will only exclude `unstable_server-external-runtime.js` artifact + // To start generating sourcemaps for it, we should stop manually copying it to `facebook-www` + // and force `react-dom` to include .map files in npm-package at the root level + bundleType !== BROWSER_SCRIPT && !isUMDBundle && !sourcemapPackageExcludes.includes(entry) && !shouldStayReadable;