mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
fix[devtools/inspectElement]: dont pause initial inspectElement call when user switches tabs (#27488)
There are not so many changes, most of them are changing imports, because I've moved types for UI in a single file. In https://github.com/facebook/react/pull/27357 I've added support for pausing polling events: when user inspects an element, we start polling React DevTools backend for updates in props / state. If user switches tabs, extension's service worker can be killed by browser and this polling will start spamming errors. What I've missed is that we also have a separate call for this API, but which is executed only once when user selects an element. We don't handle promise rejection here and this can lead to some errors when user selects an element and switches tabs right after it. The only change here is that this API now has `shouldListenToPauseEvents` param, which is `true` for polling, so we will pause polling once user switches tabs. It is `false` by default, so we won't pause initial call by accident. https://github.com/hoxyq/react/blob/af8beeebf63b5824497fcd0bb35b7c0ac8fe60a0/packages/react-devtools-shared/src/backendAPI.js#L96
This commit is contained in:
1 parent
151e75a128
commit
77ec61885f
58 files changed
+305
-282
No files matched your search
+2
-2
@@ -11,11 +11,11 @@ import {__DEBUG__} from 'react-devtools-shared/src/constants';
|
||||
|
||||
import type {HooksTree} from 'react-debug-tools/src/ReactDebugHooks';
|
||||
import type {Thenable, Wakeable} from 'shared/ReactTypes';
|
||||
import type {Element} from './devtools/views/Components/types';
|
||||
import type {
|
||||
Element,
|
||||
HookNames,
|
||||
HookSourceLocationKey,
|
||||
} from 'react-devtools-shared/src/types';
|
||||
} from 'react-devtools-shared/src/frontend/types';
|
||||
import type {HookSource} from 'react-debug-tools/src/ReactDebugHooks';
|
||||
import type {FetchFileWithCaching} from 'react-devtools-shared/src/devtools/views/Components/FetchFileWithCachingContext';
|
||||
import {withCallbackPerfMeasurements} from './PerformanceLoggingUtils';
|
||||
|
||||
Reference in new issue
Block a user