From 77ebeb1b09221d031c776f18b5134bd33d600c07 Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Mon, 16 Apr 2018 09:46:39 -0700 Subject: [PATCH] Don't git commit noop-renderer unless package deps change (#12623) --- .../update-noop-renderer-dependencies.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/scripts/release/build-commands/update-noop-renderer-dependencies.js b/scripts/release/build-commands/update-noop-renderer-dependencies.js index a000a508f7..e0bee71961 100644 --- a/scripts/release/build-commands/update-noop-renderer-dependencies.js +++ b/scripts/release/build-commands/update-noop-renderer-dependencies.js @@ -5,7 +5,7 @@ const {readJson, writeJson} = require('fs-extra'); const {join} = require('path'); const semver = require('semver'); -const {execUnlessDry, logPromise} = require('../utils'); +const {execRead, execUnlessDry, logPromise} = require('../utils'); const getReactReconcilerVersion = async cwd => { const path = join(cwd, 'packages', 'react-reconciler', 'package.json'); @@ -33,10 +33,13 @@ const update = async ({cwd, dry}) => { await writeJson(path, json, {spaces: 2}); - await execUnlessDry( - `git commit -am "Updating dependencies for react-noop-renderer"`, - {cwd, dry} - ); + const status = await execRead('git status -s', {cwd}); + if (status) { + await execUnlessDry( + `git commit -am "Updating dependencies for react-noop-renderer"`, + {cwd, dry} + ); + } }; module.exports = async params => {