From 731aa8ead11d2e8d787585a7d3aaaffa830d0a81 Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Tue, 11 Jun 2013 19:02:35 -0700 Subject: [PATCH] internalPropNames isn't necessary, so remove it Perhaps we'll bring it back as a future perf optimization if that appears useful. --- src/core/ReactComponent.js | 12 ------------ src/core/ReactNativeComponent.js | 4 ---- 2 files changed, 16 deletions(-) diff --git a/src/core/ReactComponent.js b/src/core/ReactComponent.js index 949f82f805..fe704dfbbf 100644 --- a/src/core/ReactComponent.js +++ b/src/core/ReactComponent.js @@ -35,13 +35,6 @@ var merge = require('merge'); */ var OWNER = '{owner}'; -/** - * Internal properties that shouldn't be considered when modifying node - * attributes. - */ -var internalPropNames = {children: true}; -internalPropNames[OWNER] = true; - /** * Every React component is in one of these life cycles. */ @@ -138,11 +131,6 @@ function appendNestedChildren(parentKey, sourceArray, targetArray) { */ var ReactComponent = { - /** - * @internal - */ - internalPropNames: internalPropNames, - /** * @param {?object} object * @return {boolean} True if `object` is a valid component. diff --git a/src/core/ReactNativeComponent.js b/src/core/ReactNativeComponent.js index 15f614beb1..588f414fa2 100644 --- a/src/core/ReactNativeComponent.js +++ b/src/core/ReactNativeComponent.js @@ -32,8 +32,6 @@ var keyOf = require('keyOf'); var merge = require('merge'); var mixInto = require('mixInto'); -var internalPropNames = ReactComponent.internalPropNames; - var putListener = ReactEventEmitter.putListener; var deleteListener = ReactEventEmitter.deleteListener; var registrationNames = ReactEventEmitter.registrationNames; @@ -236,7 +234,6 @@ ReactNativeComponent.Mixin = { this._rootNodeID, '' ); - } else if (internalPropNames[propKey]) { } else if (registrationNames[propKey]) { deleteListener(this._rootNodeID, propKey); } else { @@ -291,7 +288,6 @@ ReactNativeComponent.Mixin = { this._rootNodeID, '' + nextProp ); - } else if (internalPropNames[propKey]) { } else if (registrationNames[propKey]) { putListener(this._rootNodeID, propKey, nextProp); } else {