From 72b6f1ba56ad4feedc7afc3bd89f577957fe8fe6 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Fri, 1 Nov 2024 15:05:45 -0400 Subject: [PATCH] No need to spread a filtered array --- .../src/Inference/InferEffectDependencies.ts | 6 +----- .../fixtures/compiler/infer-effect-dependencies.expect.md | 2 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/compiler/packages/babel-plugin-react-compiler/src/Inference/InferEffectDependencies.ts b/compiler/packages/babel-plugin-react-compiler/src/Inference/InferEffectDependencies.ts index 37b47ae3c4..367883254d 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/Inference/InferEffectDependencies.ts +++ b/compiler/packages/babel-plugin-react-compiler/src/Inference/InferEffectDependencies.ts @@ -43,11 +43,7 @@ export function inferEffectDependencies( if (fnExpr != null) { const deps: ArrayExpression = { kind: 'ArrayExpression', - elements: [ - ...fnExpr.loweredFunc.dependencies.filter( - place => place.reactive, - ), - ], + elements: fnExpr.loweredFunc.dependencies.filter(place => place.reactive), loc: GeneratedSource, }; diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies.expect.md b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies.expect.md index da3284df31..edb1b252de 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies.expect.md +++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/infer-effect-dependencies.expect.md @@ -14,7 +14,6 @@ function Component({foo, bar}) { console.log(localNonreactive); console.log(globalValue); }); - // Optional chains and property accesses // TODO: we may be able to save bytes by omitting property accesses if the @@ -22,7 +21,6 @@ function Component({foo, bar}) { useEffect(() => { console.log(bar?.baz); console.log(bar.qux); - }); function f() {