From 6daf600609e7699106673b37b507097bc2ea5139 Mon Sep 17 00:00:00 2001 From: Luna Ruan Date: Mon, 18 Jul 2022 13:22:47 -0400 Subject: [PATCH] add transistion callbacks to hydrateRoot (#24937) This PR adds transition callbacks to hydrateRoot. --- packages/react-dom/src/client/ReactDOMRoot.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/react-dom/src/client/ReactDOMRoot.js b/packages/react-dom/src/client/ReactDOMRoot.js index ed3faa9381..c522d91f21 100644 --- a/packages/react-dom/src/client/ReactDOMRoot.js +++ b/packages/react-dom/src/client/ReactDOMRoot.js @@ -40,6 +40,7 @@ export type HydrateRootOptions = { // Options for all roots unstable_strictMode?: boolean, unstable_concurrentUpdatesByDefault?: boolean, + unstable_transitionCallbacks?: TransitionTracingCallbacks, identifierPrefix?: string, onRecoverableError?: (error: mixed) => void, ... @@ -282,6 +283,7 @@ export function hydrateRoot( let concurrentUpdatesByDefaultOverride = false; let identifierPrefix = ''; let onRecoverableError = defaultOnRecoverableError; + let transitionCallbacks = null; if (options !== null && options !== undefined) { if (options.unstable_strictMode === true) { isStrictMode = true; @@ -298,6 +300,9 @@ export function hydrateRoot( if (options.onRecoverableError !== undefined) { onRecoverableError = options.onRecoverableError; } + if (options.unstable_transitionCallbacks !== undefined) { + transitionCallbacks = options.unstable_transitionCallbacks; + } } const root = createHydrationContainer( @@ -310,8 +315,7 @@ export function hydrateRoot( concurrentUpdatesByDefaultOverride, identifierPrefix, onRecoverableError, - // TODO(luna) Support hydration later - null, + transitionCallbacks, ); markContainerAsRoot(root.current, container); // This can't be a comment node since hydration doesn't work on comment nodes anyway.