From 6baff7ac763c475087ab5ebf7eef5d0b9f4436df Mon Sep 17 00:00:00 2001 From: Hendrik Liebau Date: Fri, 16 Jan 2026 18:42:09 +0100 Subject: [PATCH] [Flight] Allow cyclic references to be serialized when unwrapping lazy elements (#35471) When `renderModelDestructive` unwraps a lazy element and subsequently calls `renderModelDestructive` again with the resolved model, we should preserve the parent connection so that cyclic references can be serialized properly. This can occur in an advanced scenario where the result from the Flight Client is serialized again with the Flight Server, e.g. for slicing a precomputed payload into multiple parts. Note: The added test only fails when run with `--prod`. In dev mode, the component info outlining prevents the issue from occurring. --- .../src/__tests__/ReactFlightDOMEdge-test.js | 68 +++++++++++++++++++ .../react-server/src/ReactFlightServer.js | 4 +- 2 files changed, 70 insertions(+), 2 deletions(-) diff --git a/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMEdge-test.js b/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMEdge-test.js index 995f0da37e..940e6c3374 100644 --- a/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMEdge-test.js +++ b/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMEdge-test.js @@ -321,6 +321,74 @@ describe('ReactFlightDOMEdge', () => { expect(result).toEqual('Client Component'); }); + it('should resolve cyclic references in client component props after two rounds of serialization and deserialization', async () => { + const ClientComponent = clientExports(function ClientComponent({data}) { + return ( +
{data.self === data ? 'Cycle resolved' : 'Cycle broken'}
+ ); + }); + const clientModuleMetadata = webpackMap[ClientComponent.$$id]; + const consumerModuleId = 'consumer-' + clientModuleMetadata.id; + const clientReference = Object.defineProperties(ClientComponent, { + $$typeof: {value: Symbol.for('react.client.reference')}, + $$id: {value: ClientComponent.$$id}, + }); + webpackModules[consumerModuleId] = clientReference; + + const cyclic = {self: null}; + cyclic.self = cyclic; + + const stream1 = ReactServerDOMServer.renderToReadableStream( + + + , + webpackMap, + ); + + const promise = ReactServerDOMClient.createFromReadableStream(stream1, { + serverConsumerManifest: { + moduleMap: { + [clientModuleMetadata.id]: { + '*': { + id: consumerModuleId, + chunks: [], + name: '*', + }, + }, + }, + moduleLoading: webpackModuleLoading, + serverModuleMap: null, + }, + }); + + const errors = []; + const stream2 = await serverAct(() => + ReactServerDOMServer.renderToReadableStream(promise, webpackMap, { + onError(error) { + errors.push(error); + }, + }), + ); + + expect(errors).toEqual([]); + + const element = await serverAct(() => + ReactServerDOMClient.createFromReadableStream(stream2, { + serverConsumerManifest: { + moduleMap: null, + moduleLoading: null, + }, + }), + ); + + const ssrStream = await serverAct(() => + ReactDOMServer.renderToReadableStream(element), + ); + const result = await readResult(ssrStream); + + expect(result).toBe('
Cycle resolved
'); + }); + it('should be able to load a server reference on a consuming server if a mapping exists', async () => { function greet(name) { return 'hi, ' + name; diff --git a/packages/react-server/src/ReactFlightServer.js b/packages/react-server/src/ReactFlightServer.js index 021913636b..1f9bb0a77f 100644 --- a/packages/react-server/src/ReactFlightServer.js +++ b/packages/react-server/src/ReactFlightServer.js @@ -3622,8 +3622,8 @@ function renderModelDestructive( return renderModelDestructive( request, task, - emptyRoot, - '', + parent, + parentPropertyName, resolvedModel, ); }