From 6af3256fe3771fb4ddda445dfe7510f63e6336de Mon Sep 17 00:00:00 2001
From: Mike Vitousek <mmvitousek@gmail.com>
Date: Thu, 18 Jul 2024 16:14:19 -0700
Subject: [PATCH] Update base for Update on "[compiler] Add wrapper functions
 to wrap change-detection storage and loading from the memo cache"

Summary: We may wish to perform some additional computation on values when they enter or exit the memo cache in change detection mode (e.g. make a deep copy, restore the original value). This builds support for doing so.

In addition, it drops the "ForDebugging" part of the flag name and makes it compatible with "disableMemoization": if memoization is disabled, we implement that by not restoring the old version of the value unless we're in a source-level memo block.

[ghstack-poisoned]
---
 .../fixtures/compiler/change-detect.expect.md    | 16 +---------------
 .../__tests__/fixtures/compiler/change-detect.js |  6 ------
 compiler/packages/snap/src/SproutTodoFilter.ts   |  1 +
 3 files changed, 2 insertions(+), 21 deletions(-)

diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.expect.md b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.expect.md
index fdeb7f42c6..d18ea302b0 100644
--- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.expect.md
+++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.expect.md
@@ -19,12 +19,6 @@ function Component(props) {
   );
 }
 
-export const FIXTURE_ENTRYPOINT = {
-  fn: Component,
-  params: [{ x: 1, y: { b: 2, c: 3, d: 4 } }],
-  isComponent: true,
-};
-
 ```
 
 ## Code
@@ -141,13 +135,5 @@ function Component(props) {
   return t3;
 }
 
-export const FIXTURE_ENTRYPOINT = {
-  fn: Component,
-  params: [{ x: 1, y: { b: 2, c: 3, d: 4 } }],
-  isComponent: true,
-};
-
 ```
-      
-### Eval output
-(kind: ok) <div>1231</div>
\ No newline at end of file
+      
\ No newline at end of file
diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.js b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.js
index 02a391613c..37b6a49c53 100644
--- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.js
+++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/change-detect.js
@@ -14,9 +14,3 @@ function Component(props) {
     </div>
   );
 }
-
-export const FIXTURE_ENTRYPOINT = {
-  fn: Component,
-  params: [{ x: 1, y: { b: 2, c: 3, d: 4 } }],
-  isComponent: true,
-};
diff --git a/compiler/packages/snap/src/SproutTodoFilter.ts b/compiler/packages/snap/src/SproutTodoFilter.ts
index 85f7413534..becbab8c03 100644
--- a/compiler/packages/snap/src/SproutTodoFilter.ts
+++ b/compiler/packages/snap/src/SproutTodoFilter.ts
@@ -497,6 +497,7 @@ const skipFilter = new Set([
   "useState-unpruned-dependency",
   "useState-and-other-hook-unpruned-dependency",
   "change-detect-reassign",
+  "change-detect",
 
   // needs to be executed as a module
   "meta-property",