Add unknown property warning for use of (#6461)

This commit is contained in:
hkal
2016-09-03 18:48:23 -05:00
committed by Brandon Dail
parent a09d158a7c
commit 6a525fdc4c
2 changed files with 19 additions and 1 deletions
@@ -41,7 +41,7 @@ var HTMLDOMPropertyConfig = {
async: HAS_BOOLEAN_VALUE,
autoComplete: 0,
// autoFocus is polyfilled/normalized by AutoFocusUtils
// autoFocus: HAS_BOOLEAN_VALUE,
autoFocus: HAS_BOOLEAN_VALUE,
autoPlay: HAS_BOOLEAN_VALUE,
capture: HAS_BOOLEAN_VALUE,
cellPadding: 0,
@@ -205,6 +205,7 @@ var HTMLDOMPropertyConfig = {
},
DOMAttributeNames: {
acceptCharset: 'accept-charset',
autoFocus: 'autofocus',
className: 'class',
htmlFor: 'for',
httpEquiv: 'http-equiv',
@@ -1495,5 +1495,22 @@ describe('ReactDOMComponent', function() {
//since hard coding the line number would make test too brittle
expect(parseInt(previousLine, 10) + 12).toBe(parseInt(currentLine, 10));
});
it('should suggest property name if available', () => {
spyOn(console, 'error');
ReactTestUtils.renderIntoDocument(React.createElement('label', {for: 'test'}));
ReactTestUtils.renderIntoDocument(React.createElement('input', {type: 'text', autofocus: true}));
expect(console.error.calls.count()).toBe(2);
expect(console.error.calls.argsFor(0)[0]).toBe(
'Warning: Unknown DOM property for. Did you mean htmlFor?\n in label'
);
expect(console.error.calls.argsFor(1)[0]).toBe(
'Warning: Unknown DOM property autofocus. Did you mean autoFocus?\n in input'
);
});
});
});