From 66bae80b0896456e54c2358aacb22bb331eebad2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Tue, 14 Feb 2017 11:10:59 -0800 Subject: [PATCH] Move validation calls behind DEV blocks (#8999) This was done for Fiber but not Stack, causing these to throw in prod. --- .../shared/stack/reconciler/ReactUpdateQueue.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js b/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js index 3fbdf6c741..5a3a5e4288 100644 --- a/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js +++ b/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js @@ -145,7 +145,9 @@ var ReactUpdateQueue = { if (callback) { callback = callback === undefined ? null : callback; - warnOnInvalidCallback(callback, callerName); + if (__DEV__) { + warnOnInvalidCallback(callback, callerName); + } if (internalInstance._pendingCallbacks) { internalInstance._pendingCallbacks.push(callback); } else { @@ -186,7 +188,9 @@ var ReactUpdateQueue = { if (callback) { callback = callback === undefined ? null : callback; - warnOnInvalidCallback(callback, callerName); + if (__DEV__) { + warnOnInvalidCallback(callback, callerName); + } if (internalInstance._pendingCallbacks) { internalInstance._pendingCallbacks.push(callback); } else { @@ -235,7 +239,9 @@ var ReactUpdateQueue = { if (callback) { callback = callback === undefined ? null : callback; - warnOnInvalidCallback(callback, callerName); + if (__DEV__) { + warnOnInvalidCallback(callback, callerName); + } if (internalInstance._pendingCallbacks) { internalInstance._pendingCallbacks.push(callback); } else {