From 5becbe3f08f5286b8db772519144bf9f1e832d2b Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Thu, 15 Oct 2015 15:51:18 -0700 Subject: [PATCH] Remove obsolete tests with new tree-walking --- .../dom/client/__tests__/ReactMount-test.js | 25 -------- .../__tests__/ReactMultiChild-test.js | 58 ------------------- 2 files changed, 83 deletions(-) diff --git a/src/renderers/dom/client/__tests__/ReactMount-test.js b/src/renderers/dom/client/__tests__/ReactMount-test.js index 6328a06092..4e5915c034 100644 --- a/src/renderers/dom/client/__tests__/ReactMount-test.js +++ b/src/renderers/dom/client/__tests__/ReactMount-test.js @@ -196,31 +196,6 @@ describe('ReactMount', function() { }); } - it('warns when using two copies of React before throwing', function() { - jest.resetModuleRegistry(); - var RD1 = require('ReactDOM'); - jest.resetModuleRegistry(); - var RD2 = require('ReactDOM'); - - var X = React.createClass({ - render: function() { - return
; - }, - }); - - var container = document.createElement('div'); - spyOn(console, 'error'); - var component = RD1.render(, container); - expect(console.error.argsForCall.length).toBe(0); - - // This fails but logs a warning first - expect(function() { - RD2.findDOMNode(component); - }).toThrow(); - expect(console.error.argsForCall.length).toBe(1); - expect(console.error.argsForCall[0][0]).toContain('two copies of React'); - }); - it('should warn if render removes React-rendered children', function() { var container = document.createElement('container'); var Component = React.createClass({ diff --git a/src/renderers/shared/reconciler/__tests__/ReactMultiChild-test.js b/src/renderers/shared/reconciler/__tests__/ReactMultiChild-test.js index fbe46a69f2..f06e242f2e 100644 --- a/src/renderers/shared/reconciler/__tests__/ReactMultiChild-test.js +++ b/src/renderers/shared/reconciler/__tests__/ReactMultiChild-test.js @@ -149,62 +149,4 @@ describe('ReactMultiChild', function() { expect(mockUnmount.mock.calls.length).toBe(1); }); }); - - describe('innerHTML', function() { - var setInnerHTML; - - // Only run this suite if `Element.prototype.innerHTML` can be spied on. - var innerHTMLDescriptor = Object.getOwnPropertyDescriptor( - Element.prototype, - 'innerHTML' - ); - if (!innerHTMLDescriptor) { - return; - } - - beforeEach(function() { - var ReactDOMFeatureFlags = require('ReactDOMFeatureFlags'); - ReactDOMFeatureFlags.useCreateElement = false; - - Object.defineProperty(Element.prototype, 'innerHTML', { - set: setInnerHTML = jasmine.createSpy().andCallFake( - innerHTMLDescriptor.set - ), - }); - }); - - it('should only set `innerHTML` once on update', function() { - var container = document.createElement('div'); - - ReactDOM.render( -
-

-

-

-
, - container - ); - // Warm the cache used by `getMarkupWrap`. - ReactDOM.render( -
-

-

-

-
, - container - ); - expect(setInnerHTML).toHaveBeenCalled(); - var callCountOnMount = setInnerHTML.calls.length; - - ReactDOM.render( -
-

-

-

-
, - container - ); - expect(setInnerHTML.calls.length).toBe(callCountOnMount + 1); - }); - }); });