diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.expect.md index a48e57083e..e12aabc376 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.expect.md +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.expect.md @@ -3,15 +3,21 @@ ```javascript import fbt from "fbt"; +import { identity } from "shared-runtime"; function Component(props) { const text = fbt( - `Hello, ${fbt.param("(key) name", capitalize(props.name))}!`, + `Hello, ${fbt.param("(key) name", identity(props.name))}!`, "(description) Greeting" ); return
{text}
; } +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ name: "Sathya" }], +}; + ``` ## Code @@ -19,6 +25,7 @@ function Component(props) { ```javascript import { unstable_useMemoCache as useMemoCache } from "react"; import fbt from "fbt"; +import { identity } from "shared-runtime"; function Component(props) { const $ = useMemoCache(4); @@ -26,7 +33,7 @@ function Component(props) { if ($[0] !== props.name) { t0 = fbt._( "Hello, {(key) name}!", - [fbt._param("(key) name", capitalize(props.name))], + [fbt._param("(key) name", identity(props.name))], { hk: "2sOsn5" } ); $[0] = props.name; @@ -46,5 +53,10 @@ function Component(props) { return t1; } +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ name: "Sathya" }], +}; + ``` \ No newline at end of file diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.js index 0683c1aa53..564d0326b2 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.js +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call-complex-param-value.js @@ -1,9 +1,15 @@ import fbt from "fbt"; +import { identity } from "shared-runtime"; function Component(props) { const text = fbt( - `Hello, ${fbt.param("(key) name", capitalize(props.name))}!`, + `Hello, ${fbt.param("(key) name", identity(props.name))}!`, "(description) Greeting" ); return
{text}
; } + +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ name: "Sathya" }], +}; diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.expect.md index daa927ea24..2d4360ed3c 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.expect.md +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.expect.md @@ -12,6 +12,11 @@ function Component(props) { return
{text}
; } +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ count: 2 }], +}; + ``` ## Code @@ -46,5 +51,10 @@ function Component(props) { return t1; } +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ count: 2 }], +}; + ``` \ No newline at end of file diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.js index f0719d10f7..87d111179a 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.js +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-call.js @@ -7,3 +7,8 @@ function Component(props) { ); return
{text}
; } + +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ count: 2 }], +}; diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.expect.md index 4e4a7c2225..b8639fdde0 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.expect.md +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.expect.md @@ -3,6 +3,7 @@ ```javascript import fbt from "fbt"; +import { Stringify } from "shared-runtime"; export function Component(props) { let count = 0; @@ -10,16 +11,21 @@ export function Component(props) { count = props.items.length; } return ( - + {fbt( `for ${fbt.param("count", count)} experiences`, `Label for the number of items`, { project: "public" } )} - + ); } +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ items: [1, 2, 3] }], +}; + ``` ## Code @@ -27,6 +33,7 @@ export function Component(props) { ```javascript import { unstable_useMemoCache as useMemoCache } from "react"; import fbt from "fbt"; +import { Stringify } from "shared-runtime"; export function Component(props) { const $ = useMemoCache(4); @@ -46,7 +53,7 @@ export function Component(props) { } let t1; if ($[2] !== t0) { - t1 = {t0}; + t1 = {t0}; $[2] = t0; $[3] = t1; } else { @@ -55,5 +62,10 @@ export function Component(props) { return t1; } +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ items: [1, 2, 3] }], +}; + ``` \ No newline at end of file diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.js index 09c531c33b..1b99662b2d 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.js +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/fbt-template-string-same-scope.js @@ -1,4 +1,5 @@ import fbt from "fbt"; +import { Stringify } from "shared-runtime"; export function Component(props) { let count = 0; @@ -6,12 +7,17 @@ export function Component(props) { count = props.items.length; } return ( - + {fbt( `for ${fbt.param("count", count)} experiences`, `Label for the number of items`, { project: "public" } )} - + ); } + +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ items: [1, 2, 3] }], +}; diff --git a/compiler/packages/sprout/src/SproutTodoFilter.ts b/compiler/packages/sprout/src/SproutTodoFilter.ts index 63f97e7bd3..d9acb43bf2 100644 --- a/compiler/packages/sprout/src/SproutTodoFilter.ts +++ b/compiler/packages/sprout/src/SproutTodoFilter.ts @@ -415,9 +415,6 @@ const skipFilter = new Set([ "multi-arrow-expr-export-default-gating-test", // TODO: we should be able to support these - "fbt-call", - "fbt-call-complex-param-value", - "fbt-template-string-same-scope", "component-declaration-basic.flow", "nested-function-with-param-as-captured-dep", "readonly-object-method-calls",