From 59b32f0813fae57908029d4b3e2003e82a87a0f0 Mon Sep 17 00:00:00 2001 From: Joe Savona Date: Mon, 11 Dec 2023 11:34:27 -0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=8C=B2=20Property/Computed=20load=20from?= =?UTF-8?q?=20props=20is=20a=20signal?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Extends the previous analysis to work for PropertyLoad and ComputedLoad, so that if the object is a prop we track the resulting value as a signal. We also disallow PropertyLoad/ComputedLoad outside of a reactive scope where the object is a signal (since that would drop reactivity). --- compiler/packages/sprout/src/SproutTodoFilter.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/compiler/packages/sprout/src/SproutTodoFilter.ts b/compiler/packages/sprout/src/SproutTodoFilter.ts index c3e91bd76e..aadb901a88 100644 --- a/compiler/packages/sprout/src/SproutTodoFilter.ts +++ b/compiler/packages/sprout/src/SproutTodoFilter.ts @@ -422,8 +422,11 @@ const skipFilter = new Set([ "readonly-object-method-calls-mutable-lambda", // TODO: 🌲 - "forest-basic", - "forest-basic-jsx", + "forest/forest-basic", + "forest/forest-basic-jsx", + "forest/forest-primitive-operations", + "forest/computed-load-props", + "forest/property-load-props", // TODO: we probably want to always skip these "rules-of-hooks/rules-of-hooks-0592bd574811",