diff --git a/src/addons/ReactComponentWithPureRenderMixin.js b/src/addons/ReactComponentWithPureRenderMixin.js index 87cfd2b2c0..d057ac71a4 100644 --- a/src/addons/ReactComponentWithPureRenderMixin.js +++ b/src/addons/ReactComponentWithPureRenderMixin.js @@ -9,7 +9,7 @@ * @providesModule ReactComponentWithPureRenderMixin */ -"use strict"; +'use strict'; var shallowEqual = require('shallowEqual'); diff --git a/src/addons/ReactRAFBatchingStrategy.js b/src/addons/ReactRAFBatchingStrategy.js index a95dcab4d1..1d3df579a7 100644 --- a/src/addons/ReactRAFBatchingStrategy.js +++ b/src/addons/ReactRAFBatchingStrategy.js @@ -10,7 +10,9 @@ * @typechecks static-only */ -"use strict"; +/* global requestAnimationFrame:true */ + +'use strict'; var ExecutionEnvironment = require('ExecutionEnvironment'); var ReactUpdates = require('ReactUpdates'); diff --git a/src/addons/__tests__/update-test.js b/src/addons/__tests__/update-test.js index 3c5dda7752..be2cb3a0e6 100644 --- a/src/addons/__tests__/update-test.js +++ b/src/addons/__tests__/update-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var update = require('update'); diff --git a/src/addons/link/LinkedStateMixin.js b/src/addons/link/LinkedStateMixin.js index 2afcd512fe..350bfa594b 100644 --- a/src/addons/link/LinkedStateMixin.js +++ b/src/addons/link/LinkedStateMixin.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var ReactLink = require('ReactLink'); var ReactStateSetters = require('ReactStateSetters'); diff --git a/src/addons/link/ReactLink.js b/src/addons/link/ReactLink.js index 4ca505126b..8d803c7ffd 100644 --- a/src/addons/link/ReactLink.js +++ b/src/addons/link/ReactLink.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; /** * ReactLink encapsulates a common pattern in which a component wants to modify diff --git a/src/addons/link/__tests__/LinkedStateMixin-test.js b/src/addons/link/__tests__/LinkedStateMixin-test.js index 524ba41a8b..3a4bee13d7 100644 --- a/src/addons/link/__tests__/LinkedStateMixin-test.js +++ b/src/addons/link/__tests__/LinkedStateMixin-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; /*jshint evil:true */ diff --git a/src/addons/link/__tests__/ReactLinkPropTypes-test.js b/src/addons/link/__tests__/ReactLinkPropTypes-test.js index b5f55b42e3..76dadd39e8 100644 --- a/src/addons/link/__tests__/ReactLinkPropTypes-test.js +++ b/src/addons/link/__tests__/ReactLinkPropTypes-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var emptyFunction = require('emptyFunction'); var LinkPropTypes = require('ReactLink').PropTypes; @@ -40,7 +40,7 @@ function typeCheckPass(declaration, value) { 'testComponent', ReactPropTypeLocations.prop ); - expect(error).toBe(undefined); + expect(error).toBe(null); } describe('ReactLink', function() { diff --git a/src/addons/transitions/ReactCSSTransitionGroup.js b/src/addons/transitions/ReactCSSTransitionGroup.js index dd481eef6b..ea45de4e4c 100644 --- a/src/addons/transitions/ReactCSSTransitionGroup.js +++ b/src/addons/transitions/ReactCSSTransitionGroup.js @@ -10,7 +10,7 @@ * @providesModule ReactCSSTransitionGroup */ -"use strict"; +'use strict'; var React = require('React'); diff --git a/src/addons/transitions/ReactCSSTransitionGroupChild.js b/src/addons/transitions/ReactCSSTransitionGroupChild.js index 6bdcf90e16..e85ee2c585 100644 --- a/src/addons/transitions/ReactCSSTransitionGroupChild.js +++ b/src/addons/transitions/ReactCSSTransitionGroupChild.js @@ -10,7 +10,7 @@ * @providesModule ReactCSSTransitionGroupChild */ -"use strict"; +'use strict'; var React = require('React'); @@ -64,7 +64,9 @@ var ReactCSSTransitionGroupChild = React.createClass({ // Usually this optional callback is used for informing an owner of // a leave animation and telling it to remove the child. - finishCallback && finishCallback(); + if (finishCallback) { + finishCallback(); + } }; ReactTransitionEvents.addEndEventListener(node, endListener); diff --git a/src/addons/transitions/ReactTransitionChildMapping.js b/src/addons/transitions/ReactTransitionChildMapping.js index 63fd96527e..1621fb1e7b 100644 --- a/src/addons/transitions/ReactTransitionChildMapping.js +++ b/src/addons/transitions/ReactTransitionChildMapping.js @@ -10,7 +10,7 @@ * @providesModule ReactTransitionChildMapping */ -"use strict"; +'use strict'; var ReactChildren = require('ReactChildren'); diff --git a/src/addons/transitions/ReactTransitionEvents.js b/src/addons/transitions/ReactTransitionEvents.js index 9dd32ca3e3..cdf8abfc88 100644 --- a/src/addons/transitions/ReactTransitionEvents.js +++ b/src/addons/transitions/ReactTransitionEvents.js @@ -9,7 +9,7 @@ * @providesModule ReactTransitionEvents */ -"use strict"; +'use strict'; var ExecutionEnvironment = require('ExecutionEnvironment'); diff --git a/src/addons/transitions/ReactTransitionGroup.js b/src/addons/transitions/ReactTransitionGroup.js index 80296e4e48..7fe408ce7c 100644 --- a/src/addons/transitions/ReactTransitionGroup.js +++ b/src/addons/transitions/ReactTransitionGroup.js @@ -9,7 +9,7 @@ * @providesModule ReactTransitionGroup */ -"use strict"; +'use strict'; var React = require('React'); var ReactTransitionChildMapping = require('ReactTransitionChildMapping'); diff --git a/src/addons/transitions/__tests__/ReactCSSTransitionGroup-test.js b/src/addons/transitions/__tests__/ReactCSSTransitionGroup-test.js index 67c7be0b49..dabd3c5819 100644 --- a/src/addons/transitions/__tests__/ReactCSSTransitionGroup-test.js +++ b/src/addons/transitions/__tests__/ReactCSSTransitionGroup-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var React; var ReactCSSTransitionGroup; diff --git a/src/addons/transitions/__tests__/ReactTransitionChildMapping-test.js b/src/addons/transitions/__tests__/ReactTransitionChildMapping-test.js index 1e7653508d..bc701cb9a3 100644 --- a/src/addons/transitions/__tests__/ReactTransitionChildMapping-test.js +++ b/src/addons/transitions/__tests__/ReactTransitionChildMapping-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var React; var ReactTransitionChildMapping; diff --git a/src/addons/transitions/__tests__/ReactTransitionGroup-test.js b/src/addons/transitions/__tests__/ReactTransitionGroup-test.js index 1a4b23fc25..0f50c160d2 100644 --- a/src/addons/transitions/__tests__/ReactTransitionGroup-test.js +++ b/src/addons/transitions/__tests__/ReactTransitionGroup-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var React; var ReactTransitionGroup; diff --git a/src/addons/update.js b/src/addons/update.js index 34e078b20e..dd03d714d4 100644 --- a/src/addons/update.js +++ b/src/addons/update.js @@ -9,7 +9,7 @@ * @providesModule update */ -"use strict"; +'use strict'; var assign = require('Object.assign'); var keyOf = require('keyOf'); diff --git a/src/browser/ClientReactRootIndex.js b/src/browser/ClientReactRootIndex.js index 2a4633b031..0db7f33b69 100644 --- a/src/browser/ClientReactRootIndex.js +++ b/src/browser/ClientReactRootIndex.js @@ -10,7 +10,7 @@ * @typechecks */ -"use strict"; +'use strict'; var nextReactRootIndex = 0; diff --git a/src/browser/ReactBrowserEventEmitter.js b/src/browser/ReactBrowserEventEmitter.js index f2c4a5dd78..a3fa84f73e 100644 --- a/src/browser/ReactBrowserEventEmitter.js +++ b/src/browser/ReactBrowserEventEmitter.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPluginHub = require('EventPluginHub'); @@ -126,7 +126,7 @@ var topEventMapping = { /** * To ensure no conflicts with other potential React instances on the page */ -var topListenersIDKey = "_reactListenersID" + String(Math.random()).slice(2); +var topListenersIDKey = '_reactListenersID' + String(Math.random()).slice(2); function getListeningForDocument(mountAt) { // In IE8, `mountAt` is a host object and doesn't have `hasOwnProperty` diff --git a/src/browser/ReactDOM.js b/src/browser/ReactDOM.js index d4b1303b44..c3e77d040c 100644 --- a/src/browser/ReactDOM.js +++ b/src/browser/ReactDOM.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var ReactElement = require('ReactElement'); var ReactElementValidator = require('ReactElementValidator'); diff --git a/src/browser/ReactPutListenerQueue.js b/src/browser/ReactPutListenerQueue.js index e47b6edcfe..50361fdc1d 100644 --- a/src/browser/ReactPutListenerQueue.js +++ b/src/browser/ReactPutListenerQueue.js @@ -9,7 +9,7 @@ * @providesModule ReactPutListenerQueue */ -"use strict"; +'use strict'; var PooledClass = require('PooledClass'); var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter'); diff --git a/src/browser/ReactReconcileTransaction.js b/src/browser/ReactReconcileTransaction.js index 008890a256..257493e9da 100644 --- a/src/browser/ReactReconcileTransaction.js +++ b/src/browser/ReactReconcileTransaction.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var CallbackQueue = require('CallbackQueue'); var PooledClass = require('PooledClass'); diff --git a/src/browser/ReactWithAddons.js b/src/browser/ReactWithAddons.js index 25d98f8b45..cb0b5931ba 100644 --- a/src/browser/ReactWithAddons.js +++ b/src/browser/ReactWithAddons.js @@ -16,7 +16,7 @@ * place to live inside React core. */ -"use strict"; +'use strict'; var LinkedStateMixin = require('LinkedStateMixin'); var React = require('React'); diff --git a/src/browser/__tests__/ReactBrowserEventEmitter-test.js b/src/browser/__tests__/ReactBrowserEventEmitter-test.js index 39b6feb627..b70fd61e81 100644 --- a/src/browser/__tests__/ReactBrowserEventEmitter-test.js +++ b/src/browser/__tests__/ReactBrowserEventEmitter-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; require('mock-modules') .dontMock('EventPluginHub') diff --git a/src/browser/__tests__/ReactDOM-test.js b/src/browser/__tests__/ReactDOM-test.js index 24fd941f67..71649cb931 100644 --- a/src/browser/__tests__/ReactDOM-test.js +++ b/src/browser/__tests__/ReactDOM-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; var React = require('React'); var ReactTestUtils = require('ReactTestUtils'); diff --git a/src/browser/__tests__/ReactWebWorker-test.js b/src/browser/__tests__/ReactWebWorker-test.js index 5acdcbc928..9f7c9bc543 100644 --- a/src/browser/__tests__/ReactWebWorker-test.js +++ b/src/browser/__tests__/ReactWebWorker-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; describe('ReactWebWorker', function() { ;(typeof Worker == 'undefined' ? xit : it)('can run React in a web worker', function() { diff --git a/src/browser/__tests__/findDOMNode-test.js b/src/browser/__tests__/findDOMNode-test.js index 7cb2f4fd8f..464c67df06 100644 --- a/src/browser/__tests__/findDOMNode-test.js +++ b/src/browser/__tests__/findDOMNode-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var React = require('React'); var ReactTestUtils = require('ReactTestUtils'); @@ -48,4 +48,3 @@ describe('findDOMNode', function() { }); }); - diff --git a/src/browser/eventPlugins/AnalyticsEventPluginFactory.js b/src/browser/eventPlugins/AnalyticsEventPluginFactory.js index e4ec0fe55e..858e3d5525 100644 --- a/src/browser/eventPlugins/AnalyticsEventPluginFactory.js +++ b/src/browser/eventPlugins/AnalyticsEventPluginFactory.js @@ -74,7 +74,7 @@ * usage. */ -"use strict"; +'use strict'; var ExecutionEnvironment = require('ExecutionEnvironment'); @@ -152,7 +152,7 @@ function extractEvents( return null; } - var analyticsEventsArr = analyticsEventsStr.split(","); + var analyticsEventsArr = analyticsEventsStr.split(','); if (!analyticsData.hasOwnProperty(analyticsID)) { initAnalyticsDataForID(analyticsID, analyticsEventsArr); } diff --git a/src/browser/eventPlugins/BeforeInputEventPlugin.js b/src/browser/eventPlugins/BeforeInputEventPlugin.js index 449aa5cf48..0441c57d0e 100644 --- a/src/browser/eventPlugins/BeforeInputEventPlugin.js +++ b/src/browser/eventPlugins/BeforeInputEventPlugin.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPropagators = require('EventPropagators'); @@ -256,7 +256,7 @@ function extractCompositionEvent( } if (!eventType) { - return; + return null; } if (useFallbackCompositionData) { @@ -427,7 +427,7 @@ function extractBeforeInputEvent( // If no characters are being inserted, no BeforeInput event should // be fired. if (!chars) { - return; + return null; } var event = SyntheticInputEvent.getPooled( @@ -490,7 +490,7 @@ var BeforeInputEventPlugin = { topLevelTarget, topLevelTargetID, nativeEvent - ), + ) ]; } }; diff --git a/src/browser/eventPlugins/ChangeEventPlugin.js b/src/browser/eventPlugins/ChangeEventPlugin.js index cc2243a359..92271602d1 100644 --- a/src/browser/eventPlugins/ChangeEventPlugin.js +++ b/src/browser/eventPlugins/ChangeEventPlugin.js @@ -9,7 +9,7 @@ * @providesModule ChangeEventPlugin */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPluginHub = require('EventPluginHub'); diff --git a/src/browser/eventPlugins/DefaultEventPluginOrder.js b/src/browser/eventPlugins/DefaultEventPluginOrder.js index f61748ef26..e0f5b16316 100644 --- a/src/browser/eventPlugins/DefaultEventPluginOrder.js +++ b/src/browser/eventPlugins/DefaultEventPluginOrder.js @@ -9,7 +9,7 @@ * @providesModule DefaultEventPluginOrder */ -"use strict"; +'use strict'; var keyOf = require('keyOf'); diff --git a/src/browser/eventPlugins/EnterLeaveEventPlugin.js b/src/browser/eventPlugins/EnterLeaveEventPlugin.js index bef0d4221b..1ec6d02b09 100644 --- a/src/browser/eventPlugins/EnterLeaveEventPlugin.js +++ b/src/browser/eventPlugins/EnterLeaveEventPlugin.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPropagators = require('EventPropagators'); diff --git a/src/browser/eventPlugins/FallbackCompositionState.js b/src/browser/eventPlugins/FallbackCompositionState.js index f557aef465..44ea12b3d2 100644 --- a/src/browser/eventPlugins/FallbackCompositionState.js +++ b/src/browser/eventPlugins/FallbackCompositionState.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var PooledClass = require('PooledClass'); @@ -58,19 +58,21 @@ assign(FallbackCompositionState.prototype, { return this._fallbackText; } - var endValue = this.getText(); + var start; var startValue = this._startText; var startLength = startValue.length; + var end; + var endValue = this.getText(); var endLength = endValue.length; - for (var start = 0; start < startLength; start++) { + for (start = 0; start < startLength; start++) { if (startValue[start] !== endValue[start]) { break; } } var minEnd = startLength - start; - for (var end = 1; end <= minEnd; end++) { + for (end = 1; end <= minEnd; end++) { if (startValue[startLength - end] !== endValue[endLength - end]) { break; } diff --git a/src/browser/eventPlugins/MobileSafariClickEventPlugin.js b/src/browser/eventPlugins/MobileSafariClickEventPlugin.js index 9d695167db..774860a4fd 100644 --- a/src/browser/eventPlugins/MobileSafariClickEventPlugin.js +++ b/src/browser/eventPlugins/MobileSafariClickEventPlugin.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); diff --git a/src/browser/eventPlugins/ResponderEventPlugin.js b/src/browser/eventPlugins/ResponderEventPlugin.js index 44d322af7d..dde77d6cf6 100644 --- a/src/browser/eventPlugins/ResponderEventPlugin.js +++ b/src/browser/eventPlugins/ResponderEventPlugin.js @@ -9,7 +9,7 @@ * @providesModule ResponderEventPlugin */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPluginUtils = require('EventPluginUtils'); diff --git a/src/browser/eventPlugins/SelectEventPlugin.js b/src/browser/eventPlugins/SelectEventPlugin.js index 7fa54c0602..7a93798c42 100644 --- a/src/browser/eventPlugins/SelectEventPlugin.js +++ b/src/browser/eventPlugins/SelectEventPlugin.js @@ -9,7 +9,7 @@ * @providesModule SelectEventPlugin */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPropagators = require('EventPropagators'); @@ -94,8 +94,8 @@ function constructSelectEvent(nativeEvent) { // won't dispatch. if (mouseDown || activeElement == null || - activeElement != getActiveElement()) { - return; + activeElement !== getActiveElement()) { + return null; } // Only fire when selection has actually changed. diff --git a/src/browser/eventPlugins/SimpleEventPlugin.js b/src/browser/eventPlugins/SimpleEventPlugin.js index f3d5743fcf..d0d2d23a9f 100644 --- a/src/browser/eventPlugins/SimpleEventPlugin.js +++ b/src/browser/eventPlugins/SimpleEventPlugin.js @@ -9,7 +9,7 @@ * @providesModule SimpleEventPlugin */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPluginUtils = require('EventPluginUtils'); diff --git a/src/browser/eventPlugins/TapEventPlugin.js b/src/browser/eventPlugins/TapEventPlugin.js index 788b3513aa..fe43085f2d 100644 --- a/src/browser/eventPlugins/TapEventPlugin.js +++ b/src/browser/eventPlugins/TapEventPlugin.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var EventConstants = require('EventConstants'); var EventPluginUtils = require('EventPluginUtils'); @@ -117,7 +117,7 @@ var TapEventPlugin = { usedTouchTime = Date.now(); } else { if (usedTouch && (Date.now() - usedTouchTime < TOUCH_DELAY)) { - return; + return null; } } var event = null; diff --git a/src/browser/eventPlugins/__tests__/AnalyticsEventPlugin-test.js b/src/browser/eventPlugins/__tests__/AnalyticsEventPlugin-test.js index cc5f9902ef..ff717f3973 100644 --- a/src/browser/eventPlugins/__tests__/AnalyticsEventPlugin-test.js +++ b/src/browser/eventPlugins/__tests__/AnalyticsEventPlugin-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var mocks = require('mocks'); diff --git a/src/browser/eventPlugins/__tests__/EnterLeaveEventPlugin-test.js b/src/browser/eventPlugins/__tests__/EnterLeaveEventPlugin-test.js index 365a5965c8..721ea4bd1e 100644 --- a/src/browser/eventPlugins/__tests__/EnterLeaveEventPlugin-test.js +++ b/src/browser/eventPlugins/__tests__/EnterLeaveEventPlugin-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; var EnterLeaveEventPlugin; var EventConstants; diff --git a/src/browser/eventPlugins/__tests__/FallbackCompositionState-test.js b/src/browser/eventPlugins/__tests__/FallbackCompositionState-test.js index 893e8ef858..935debaa30 100644 --- a/src/browser/eventPlugins/__tests__/FallbackCompositionState-test.js +++ b/src/browser/eventPlugins/__tests__/FallbackCompositionState-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; describe('FallbackCompositionState', function() { var FallbackCompositionState; diff --git a/src/browser/eventPlugins/__tests__/ResponderEventPlugin-test.js b/src/browser/eventPlugins/__tests__/ResponderEventPlugin-test.js index d480efcbe1..e849779fdf 100644 --- a/src/browser/eventPlugins/__tests__/ResponderEventPlugin-test.js +++ b/src/browser/eventPlugins/__tests__/ResponderEventPlugin-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var EventPluginHub; var EventConstants; diff --git a/src/browser/findDOMNode.js b/src/browser/findDOMNode.js index 32f7c46f6d..501bb3f82a 100644 --- a/src/browser/findDOMNode.js +++ b/src/browser/findDOMNode.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var ReactInstanceMap = require('ReactInstanceMap'); var ReactMount = require('ReactMount'); @@ -35,9 +35,9 @@ function findDOMNode(componentOrElement) { } invariant( componentOrElement.render == null || - typeof(componentOrElement.render) !== 'function', - 'Component (with keys: %s) contains `render` method ' - +'but is not mounted in the DOM', + typeof componentOrElement.render !== 'function', + 'Component (with keys: %s) contains `render` method ' + + 'but is not mounted in the DOM', Object.keys(componentOrElement) ); invariant( diff --git a/src/browser/server/ReactMarkupChecksum.js b/src/browser/server/ReactMarkupChecksum.js index 1cfb1e97d3..d3b248a4ce 100644 --- a/src/browser/server/ReactMarkupChecksum.js +++ b/src/browser/server/ReactMarkupChecksum.js @@ -9,7 +9,7 @@ * @providesModule ReactMarkupChecksum */ -"use strict"; +'use strict'; var adler32 = require('adler32'); diff --git a/src/browser/server/ReactServerRendering.js b/src/browser/server/ReactServerRendering.js index 670d752412..c5e291e9e6 100644 --- a/src/browser/server/ReactServerRendering.js +++ b/src/browser/server/ReactServerRendering.js @@ -9,7 +9,7 @@ * @typechecks static-only * @providesModule ReactServerRendering */ -"use strict"; +'use strict'; var ReactElement = require('ReactElement'); var ReactInstanceHandles = require('ReactInstanceHandles'); @@ -38,7 +38,8 @@ function renderToString(element) { return transaction.perform(function() { var componentInstance = instantiateReactComponent(element, null); - var markup = componentInstance.mountComponent(id, transaction, emptyObject); + var markup = + componentInstance.mountComponent(id, transaction, emptyObject); return ReactMarkupChecksum.addChecksumToMarkup(markup); }, null); } finally { diff --git a/src/browser/server/ReactServerRenderingTransaction.js b/src/browser/server/ReactServerRenderingTransaction.js index 7833b58831..e9fea07b04 100644 --- a/src/browser/server/ReactServerRenderingTransaction.js +++ b/src/browser/server/ReactServerRenderingTransaction.js @@ -10,7 +10,7 @@ * @typechecks */ -"use strict"; +'use strict'; var PooledClass = require('PooledClass'); var CallbackQueue = require('CallbackQueue'); diff --git a/src/browser/server/ServerReactRootIndex.js b/src/browser/server/ServerReactRootIndex.js index 1329fe7485..b8b6f98fab 100644 --- a/src/browser/server/ServerReactRootIndex.js +++ b/src/browser/server/ServerReactRootIndex.js @@ -10,7 +10,7 @@ * @typechecks */ -"use strict"; +'use strict'; /** * Size of the reactRoot ID space. We generate random numbers for React root diff --git a/src/browser/server/__tests__/ReactServerRendering-test.js b/src/browser/server/__tests__/ReactServerRendering-test.js index d6b9a5c593..cee8ba19e8 100644 --- a/src/browser/server/__tests__/ReactServerRendering-test.js +++ b/src/browser/server/__tests__/ReactServerRendering-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; require('mock-modules') .dontMock('ExecutionEnvironment') diff --git a/src/browser/syntheticEvents/SyntheticClipboardEvent.js b/src/browser/syntheticEvents/SyntheticClipboardEvent.js index 167ff4e495..2f459413a9 100644 --- a/src/browser/syntheticEvents/SyntheticClipboardEvent.js +++ b/src/browser/syntheticEvents/SyntheticClipboardEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticEvent = require('SyntheticEvent'); @@ -41,4 +41,3 @@ function SyntheticClipboardEvent(dispatchConfig, dispatchMarker, nativeEvent) { SyntheticEvent.augmentClass(SyntheticClipboardEvent, ClipboardEventInterface); module.exports = SyntheticClipboardEvent; - diff --git a/src/browser/syntheticEvents/SyntheticCompositionEvent.js b/src/browser/syntheticEvents/SyntheticCompositionEvent.js index cde736b247..0636f6e981 100644 --- a/src/browser/syntheticEvents/SyntheticCompositionEvent.js +++ b/src/browser/syntheticEvents/SyntheticCompositionEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticEvent = require('SyntheticEvent'); @@ -41,4 +41,3 @@ SyntheticEvent.augmentClass( ); module.exports = SyntheticCompositionEvent; - diff --git a/src/browser/syntheticEvents/SyntheticDragEvent.js b/src/browser/syntheticEvents/SyntheticDragEvent.js index 7568327294..9234591c58 100644 --- a/src/browser/syntheticEvents/SyntheticDragEvent.js +++ b/src/browser/syntheticEvents/SyntheticDragEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticMouseEvent = require('SyntheticMouseEvent'); diff --git a/src/browser/syntheticEvents/SyntheticEvent.js b/src/browser/syntheticEvents/SyntheticEvent.js index 2d17e6cf9d..dd8b3dcd3c 100644 --- a/src/browser/syntheticEvents/SyntheticEvent.js +++ b/src/browser/syntheticEvents/SyntheticEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var PooledClass = require('PooledClass'); @@ -88,13 +88,21 @@ assign(SyntheticEvent.prototype, { preventDefault: function() { this.defaultPrevented = true; var event = this.nativeEvent; - event.preventDefault ? event.preventDefault() : event.returnValue = false; + if (event.preventDefault) { + event.preventDefault(); + } else { + event.returnValue = false; + } this.isDefaultPrevented = emptyFunction.thatReturnsTrue; }, stopPropagation: function() { var event = this.nativeEvent; - event.stopPropagation ? event.stopPropagation() : event.cancelBubble = true; + if (event.stopPropagation) { + event.stopPropagation(); + } else { + event.cancelBubble = true; + } this.isPropagationStopped = emptyFunction.thatReturnsTrue; }, diff --git a/src/browser/syntheticEvents/SyntheticFocusEvent.js b/src/browser/syntheticEvents/SyntheticFocusEvent.js index ea96a02c0a..d8e9b3fd8e 100644 --- a/src/browser/syntheticEvents/SyntheticFocusEvent.js +++ b/src/browser/syntheticEvents/SyntheticFocusEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticUIEvent = require('SyntheticUIEvent'); diff --git a/src/browser/syntheticEvents/SyntheticInputEvent.js b/src/browser/syntheticEvents/SyntheticInputEvent.js index e0153139b2..8aeb37c199 100644 --- a/src/browser/syntheticEvents/SyntheticInputEvent.js +++ b/src/browser/syntheticEvents/SyntheticInputEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticEvent = require('SyntheticEvent'); @@ -42,4 +42,3 @@ SyntheticEvent.augmentClass( ); module.exports = SyntheticInputEvent; - diff --git a/src/browser/syntheticEvents/SyntheticKeyboardEvent.js b/src/browser/syntheticEvents/SyntheticKeyboardEvent.js index 4969a20f5c..fec450021d 100644 --- a/src/browser/syntheticEvents/SyntheticKeyboardEvent.js +++ b/src/browser/syntheticEvents/SyntheticKeyboardEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticUIEvent = require('SyntheticUIEvent'); diff --git a/src/browser/syntheticEvents/SyntheticMouseEvent.js b/src/browser/syntheticEvents/SyntheticMouseEvent.js index 67ee558e96..86cfd17914 100644 --- a/src/browser/syntheticEvents/SyntheticMouseEvent.js +++ b/src/browser/syntheticEvents/SyntheticMouseEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticUIEvent = require('SyntheticUIEvent'); var ViewportMetrics = require('ViewportMetrics'); diff --git a/src/browser/syntheticEvents/SyntheticTouchEvent.js b/src/browser/syntheticEvents/SyntheticTouchEvent.js index 8f48a5cb9a..f645945b0a 100644 --- a/src/browser/syntheticEvents/SyntheticTouchEvent.js +++ b/src/browser/syntheticEvents/SyntheticTouchEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticUIEvent = require('SyntheticUIEvent'); diff --git a/src/browser/syntheticEvents/SyntheticUIEvent.js b/src/browser/syntheticEvents/SyntheticUIEvent.js index 1966070722..bcbcd55b5f 100644 --- a/src/browser/syntheticEvents/SyntheticUIEvent.js +++ b/src/browser/syntheticEvents/SyntheticUIEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticEvent = require('SyntheticEvent'); diff --git a/src/browser/syntheticEvents/SyntheticWheelEvent.js b/src/browser/syntheticEvents/SyntheticWheelEvent.js index 49c874b163..d89be0a5c9 100644 --- a/src/browser/syntheticEvents/SyntheticWheelEvent.js +++ b/src/browser/syntheticEvents/SyntheticWheelEvent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var SyntheticMouseEvent = require('SyntheticMouseEvent'); diff --git a/src/browser/syntheticEvents/__tests__/SyntheticEvent-test.js b/src/browser/syntheticEvents/__tests__/SyntheticEvent-test.js index 0b95a5abe5..545dea44b5 100644 --- a/src/browser/syntheticEvents/__tests__/SyntheticEvent-test.js +++ b/src/browser/syntheticEvents/__tests__/SyntheticEvent-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var SyntheticEvent; diff --git a/src/browser/syntheticEvents/__tests__/SyntheticWheelEvent-test.js b/src/browser/syntheticEvents/__tests__/SyntheticWheelEvent-test.js index b7a97b6baa..9a871da175 100644 --- a/src/browser/syntheticEvents/__tests__/SyntheticWheelEvent-test.js +++ b/src/browser/syntheticEvents/__tests__/SyntheticWheelEvent-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var SyntheticWheelEvent; diff --git a/src/browser/ui/React.js b/src/browser/ui/React.js index 5cbc45fa96..977d4689df 100644 --- a/src/browser/ui/React.js +++ b/src/browser/ui/React.js @@ -11,7 +11,7 @@ /* globals __REACT_DEVTOOLS_GLOBAL_HOOK__*/ -"use strict"; +'use strict'; var DOMPropertyOperations = require('DOMPropertyOperations'); var EventPluginUtils = require('EventPluginUtils'); diff --git a/src/browser/ui/ReactBrowserComponentMixin.js b/src/browser/ui/ReactBrowserComponentMixin.js index ba3dc2a4f3..eaed83f5d2 100644 --- a/src/browser/ui/ReactBrowserComponentMixin.js +++ b/src/browser/ui/ReactBrowserComponentMixin.js @@ -9,7 +9,7 @@ * @providesModule ReactBrowserComponentMixin */ -"use strict"; +'use strict'; var findDOMNode = require('findDOMNode'); diff --git a/src/browser/ui/ReactComponentBrowserEnvironment.js b/src/browser/ui/ReactComponentBrowserEnvironment.js index e5b3bbd116..ee9e540f5f 100644 --- a/src/browser/ui/ReactComponentBrowserEnvironment.js +++ b/src/browser/ui/ReactComponentBrowserEnvironment.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; var ReactDOMIDOperations = require('ReactDOMIDOperations'); var ReactMount = require('ReactMount'); diff --git a/src/browser/ui/ReactDOMComponent.js b/src/browser/ui/ReactDOMComponent.js index 3d7031f13b..033aa977bc 100644 --- a/src/browser/ui/ReactDOMComponent.js +++ b/src/browser/ui/ReactDOMComponent.js @@ -10,7 +10,9 @@ * @typechecks static-only */ -"use strict"; +/* global hasOwnProperty:true */ + +'use strict'; var CSSPropertyOperations = require('CSSPropertyOperations'); var DOMProperty = require('DOMProperty'); @@ -73,9 +75,9 @@ function assertValidProps(props) { if (props.contentEditable && props.children != null) { console.warn( 'A component is `contentEditable` and contains `children` managed by ' + - 'React. It is now your responsibility to guarantee that none of those '+ - 'nodes are unexpectedly modified or duplicated. This is probably not ' + - 'intentional.' + 'React. It is now your responsibility to guarantee that none of ' + + 'those nodes are unexpectedly modified or duplicated. This is ' + + 'probably not intentional.' ); } } diff --git a/src/browser/ui/ReactDOMIDOperations.js b/src/browser/ui/ReactDOMIDOperations.js index 6705433e48..1586ac880d 100644 --- a/src/browser/ui/ReactDOMIDOperations.js +++ b/src/browser/ui/ReactDOMIDOperations.js @@ -12,7 +12,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; var CSSPropertyOperations = require('CSSPropertyOperations'); var DOMChildrenOperations = require('DOMChildrenOperations'); diff --git a/src/browser/ui/ReactDOMSelection.js b/src/browser/ui/ReactDOMSelection.js index 1ad780676c..bdc7b3f0bc 100644 --- a/src/browser/ui/ReactDOMSelection.js +++ b/src/browser/ui/ReactDOMSelection.js @@ -9,7 +9,7 @@ * @providesModule ReactDOMSelection */ -"use strict"; +'use strict'; var ExecutionEnvironment = require('ExecutionEnvironment'); diff --git a/src/browser/ui/ReactDOMTextComponent.js b/src/browser/ui/ReactDOMTextComponent.js index 4999d750db..3e15a7863b 100644 --- a/src/browser/ui/ReactDOMTextComponent.js +++ b/src/browser/ui/ReactDOMTextComponent.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var DOMPropertyOperations = require('DOMPropertyOperations'); var ReactComponentBrowserEnvironment = diff --git a/src/browser/ui/ReactDefaultInjection.js b/src/browser/ui/ReactDefaultInjection.js index fcc9e6ba8a..3e2d21d618 100644 --- a/src/browser/ui/ReactDefaultInjection.js +++ b/src/browser/ui/ReactDefaultInjection.js @@ -9,7 +9,7 @@ * @providesModule ReactDefaultInjection */ -"use strict"; +'use strict'; var BeforeInputEventPlugin = require('BeforeInputEventPlugin'); var ChangeEventPlugin = require('ChangeEventPlugin'); diff --git a/src/browser/ui/ReactEventListener.js b/src/browser/ui/ReactEventListener.js index e51fcd9c62..41835ba928 100644 --- a/src/browser/ui/ReactEventListener.js +++ b/src/browser/ui/ReactEventListener.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var EventListener = require('EventListener'); var ExecutionEnvironment = require('ExecutionEnvironment'); @@ -123,7 +123,7 @@ var ReactEventListener = { trapBubbledEvent: function(topLevelType, handlerBaseName, handle) { var element = handle; if (!element) { - return; + return null; } return EventListener.listen( element, @@ -145,7 +145,7 @@ var ReactEventListener = { trapCapturedEvent: function(topLevelType, handlerBaseName, handle) { var element = handle; if (!element) { - return; + return null; } return EventListener.capture( element, diff --git a/src/browser/ui/ReactInjection.js b/src/browser/ui/ReactInjection.js index bea0124f4a..b959a6fdb1 100644 --- a/src/browser/ui/ReactInjection.js +++ b/src/browser/ui/ReactInjection.js @@ -9,7 +9,7 @@ * @providesModule ReactInjection */ -"use strict"; +'use strict'; var DOMProperty = require('DOMProperty'); var EventPluginHub = require('EventPluginHub'); diff --git a/src/browser/ui/ReactInputSelection.js b/src/browser/ui/ReactInputSelection.js index 023090f8f8..6ae32bed3c 100644 --- a/src/browser/ui/ReactInputSelection.js +++ b/src/browser/ui/ReactInputSelection.js @@ -9,7 +9,7 @@ * @providesModule ReactInputSelection */ -"use strict"; +'use strict'; var ReactDOMSelection = require('ReactDOMSelection'); diff --git a/src/browser/ui/ReactMount.js b/src/browser/ui/ReactMount.js index 4d51f02f65..816441faae 100644 --- a/src/browser/ui/ReactMount.js +++ b/src/browser/ui/ReactMount.js @@ -9,7 +9,7 @@ * @providesModule ReactMount */ -"use strict"; +'use strict'; var DOMProperty = require('DOMProperty'); var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter'); @@ -435,7 +435,9 @@ var ReactMount = { container, shouldReuseMarkup ).getPublicInstance(); - callback && callback.call(component); + if (callback) { + callback.call(component); + } return component; }, diff --git a/src/browser/ui/__tests__/ReactDOMComponent-test.js b/src/browser/ui/__tests__/ReactDOMComponent-test.js index b69773cd24..f66efa2877 100644 --- a/src/browser/ui/__tests__/ReactDOMComponent-test.js +++ b/src/browser/ui/__tests__/ReactDOMComponent-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; var assign = require('Object.assign'); var mocks = require('mocks'); diff --git a/src/browser/ui/__tests__/ReactDOMIDOperations-test.js b/src/browser/ui/__tests__/ReactDOMIDOperations-test.js index 47cafa9794..06bc85b021 100644 --- a/src/browser/ui/__tests__/ReactDOMIDOperations-test.js +++ b/src/browser/ui/__tests__/ReactDOMIDOperations-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; describe('ReactDOMIDOperations', function() { var DOMPropertyOperations = require('DOMPropertyOperations'); diff --git a/src/browser/ui/__tests__/ReactDOMTextComponent-test.js b/src/browser/ui/__tests__/ReactDOMTextComponent-test.js index 37a1b9822b..f8716fbdc1 100644 --- a/src/browser/ui/__tests__/ReactDOMTextComponent-test.js +++ b/src/browser/ui/__tests__/ReactDOMTextComponent-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var React; diff --git a/src/browser/ui/__tests__/ReactMount-test.js b/src/browser/ui/__tests__/ReactMount-test.js index f9d3aad8d2..8634524178 100644 --- a/src/browser/ui/__tests__/ReactMount-test.js +++ b/src/browser/ui/__tests__/ReactMount-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var mocks = require('mocks'); diff --git a/src/browser/ui/__tests__/ReactMountDestruction-test.js b/src/browser/ui/__tests__/ReactMountDestruction-test.js index 35cb05be85..a49c88da51 100644 --- a/src/browser/ui/__tests__/ReactMountDestruction-test.js +++ b/src/browser/ui/__tests__/ReactMountDestruction-test.js @@ -9,7 +9,7 @@ * @emails react-core */ -"use strict"; +'use strict'; var React = require('React'); diff --git a/src/browser/ui/__tests__/ReactRenderDocument-test.js b/src/browser/ui/__tests__/ReactRenderDocument-test.js index 2a9d9f3bed..97e5971a67 100644 --- a/src/browser/ui/__tests__/ReactRenderDocument-test.js +++ b/src/browser/ui/__tests__/ReactRenderDocument-test.js @@ -11,7 +11,7 @@ /*jslint evil: true */ -"use strict"; +'use strict'; var React; var ReactInstanceMap; diff --git a/src/browser/ui/dom/CSSProperty.js b/src/browser/ui/dom/CSSProperty.js index b93c093ed1..0b924974e8 100644 --- a/src/browser/ui/dom/CSSProperty.js +++ b/src/browser/ui/dom/CSSProperty.js @@ -9,7 +9,7 @@ * @providesModule CSSProperty */ -"use strict"; +'use strict'; /** * CSS properties which accept numbers but are not in units of "px". diff --git a/src/browser/ui/dom/CSSPropertyOperations.js b/src/browser/ui/dom/CSSPropertyOperations.js index 22f2ae0bee..f40ce5f213 100644 --- a/src/browser/ui/dom/CSSPropertyOperations.js +++ b/src/browser/ui/dom/CSSPropertyOperations.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var CSSProperty = require('CSSProperty'); var ExecutionEnvironment = require('ExecutionEnvironment'); diff --git a/src/browser/ui/dom/DOMChildrenOperations.js b/src/browser/ui/dom/DOMChildrenOperations.js index 0a566e5c00..27aa8c2438 100644 --- a/src/browser/ui/dom/DOMChildrenOperations.js +++ b/src/browser/ui/dom/DOMChildrenOperations.js @@ -10,7 +10,7 @@ * @typechecks static-only */ -"use strict"; +'use strict'; var Danger = require('Danger'); var ReactMultiChildUpdateTypes = require('ReactMultiChildUpdateTypes'); @@ -100,7 +100,8 @@ var DOMChildrenOperations = { // List of children that will be moved or removed. var updatedChildren = null; - for (var i = 0; update = updates[i]; i++) { + for (var i = 0; i < updates.length; i++) { + update = updates[i]; if (update.type === ReactMultiChildUpdateTypes.MOVE_EXISTING || update.type === ReactMultiChildUpdateTypes.REMOVE_NODE) { var updatedIndex = update.fromIndex; @@ -112,7 +113,7 @@ var DOMChildrenOperations = { 'processUpdates(): Unable to find child %s of element. This ' + 'probably means the DOM was unexpectedly mutated (e.g., by the ' + 'browser), usually due to forgetting a
when using tables, ' + - 'nesting tags like