From 52633c84e2af140466a9771e8cfa024d6bc1a8a7 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 4 Sep 2018 14:21:15 +0100 Subject: [PATCH] Try/finally --- .../ReactServerRenderingHydration.js | 28 +++++++++++-------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactServerRenderingHydration.js b/packages/react-dom/src/__tests__/ReactServerRenderingHydration.js index 054e218367..81fdb96ad1 100644 --- a/packages/react-dom/src/__tests__/ReactServerRenderingHydration.js +++ b/packages/react-dom/src/__tests__/ReactServerRenderingHydration.js @@ -283,19 +283,25 @@ describe('ReactDOMServerHydration', () => { it('should not warn when the style property differs on whitespace or order in IE', () => { document.documentMode = 11; - const element = document.createElement('div'); + try { + const element = document.createElement('div'); - // Simulate IE normalizing the style attribute. IE makes it equal to - // what's available under `node.style.cssText`. - element.innerHTML = - '
'; + // Simulate IE normalizing the style attribute. IE makes it equal to + // what's available under `node.style.cssText`. + element.innerHTML = + '
'; - ReactDOM.hydrate( -
, - element, - ); - - delete document.documentMode; + // We don't expect to see false positive warnings. + // https://github.com/facebook/react/issues/11807 + ReactDOM.hydrate( +
, + element, + ); + } finally { + delete document.documentMode; + } }); it('should warn when the style property differs on whitespace in non-IE browsers', () => {