From 4f8ffec453c41fcb6e98cb4e003f7319bb1c81b9 Mon Sep 17 00:00:00 2001
From: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Date: Sun, 15 Jan 2023 18:57:59 +0100
Subject: [PATCH] Rejct toWarnDev if given callback throws (#26003)

## Summary

Should unblock https://github.com/facebook/react/pull/25970
If the callback for `toWarnDev` was `async` and threw, we didn't
ultimately reject the await Promise from the matcher. This resulted in
tests failing even though the failure was expected due to a test gate.

## How did you test this change?

- [x] tested in https://github.com/facebook/react/pull/25970 with `yarn
test --r=stable --env=development
packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js --watch`
- [x] `yarn test`
- [x] CI
---
 scripts/jest/matchers/toWarnDev.js | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/scripts/jest/matchers/toWarnDev.js b/scripts/jest/matchers/toWarnDev.js
index 19d2dd17d8..781c0f0d4d 100644
--- a/scripts/jest/matchers/toWarnDev.js
+++ b/scripts/jest/matchers/toWarnDev.js
@@ -270,15 +270,20 @@ const createMatcherFor = (consoleMethod, matcherName) =>
           // Once `act(async () => {}).then(() => {}).then(() => {})` works
           // we can just return `result.then(onFinally, error => ...)`
           returnPromise = new Promise((resolve, reject) => {
-            result.then(
-              () => {
-                resolve(onFinally());
-              },
-              error => {
-                caughtError = error;
-                return resolve(onFinally());
-              }
-            );
+            result
+              .then(
+                () => {
+                  resolve(onFinally());
+                },
+                error => {
+                  caughtError = error;
+                  return resolve(onFinally());
+                }
+              )
+              // In case onFinally throws we need to reject from this matcher
+              .catch(error => {
+                reject(error);
+              });
           });
         }
       } catch (error) {