From 4f20847f8b655e552e60c1bc39a06d34b5e2e93d Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Sat, 14 May 2016 12:03:51 -0700 Subject: [PATCH] Make benchmark script work in React 15 (cherry picked from commit cab835d3a0b4a128ddc3e612fc05e432df20204d) --- scripts/bench/measure.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/bench/measure.py b/scripts/bench/measure.py index 1ab853ad9e..c6346139b6 100755 --- a/scripts/bench/measure.py +++ b/scripts/bench/measure.py @@ -77,6 +77,7 @@ def _measure_ssr_ms(engine, react_path, bench_name, bench_path, measure_warm): var START = now(); globalEval(reactCode); var END = now(); + ReactDOMServer = React.__SECRET_DOM_SERVER_DO_NOT_USE_OR_YOU_WILL_BE_FIRED || React; if (typeof React !== 'object') throw new Error('React not laoded'); report('factory_ms', END - START); @@ -85,7 +86,7 @@ def _measure_ssr_ms(engine, react_path, bench_name, bench_path, measure_warm): throw new Error('benchmark not loaded'); } var START = now(); - var html = React.renderToString(React.createElement(Benchmark)); + var html = ReactDOMServer.renderToString(React.createElement(Benchmark)); html.charCodeAt(0); // flatten ropes var END = now(); report('ssr_' + ENV.bench_name + '_cold_ms', END - START); @@ -94,12 +95,12 @@ def _measure_ssr_ms(engine, react_path, bench_name, bench_path, measure_warm): var trials = ENV.measure_warm ? 40 : 0; for (var i = 0; i < warmup; i++) { - React.renderToString(React.createElement(Benchmark)); + ReactDOMServer.renderToString(React.createElement(Benchmark)); } for (var i = 0; i < trials; i++) { var START = now(); - var html = React.renderToString(React.createElement(Benchmark)); + var html = ReactDOMServer.renderToString(React.createElement(Benchmark)); html.charCodeAt(0); // flatten ropes var END = now(); report('ssr_' + ENV.bench_name + '_warm_ms', END - START);