From 4af3ff1e759682c05336341f242bb886a81839f3 Mon Sep 17 00:00:00 2001 From: Joe Savona Date: Wed, 6 Mar 2024 09:28:03 -0800 Subject: [PATCH] Fixture for transitive invalidation of effect dep This fixture shows that this optimization partially improves transitive checking for validateMemoizedEffectDependencies. --- ...ffect-deps-invalidated-dep-value.expect.md | 44 +++++++++++++++++++ ...oized-effect-deps-invalidated-dep-value.js | 19 ++++++++ 2 files changed, 63 insertions(+) create mode 100644 compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.expect.md create mode 100644 compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.js diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.expect.md new file mode 100644 index 0000000000..a7c6c7d046 --- /dev/null +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.expect.md @@ -0,0 +1,44 @@ + +## Input + +```javascript +// @validateMemoizedEffectDependencies +import { useHook } from "shared-runtime"; + +function Component(props) { + const x = []; + useHook(); // intersperse a hook call to prevent memoization of x + x.push(props.value); + + const y = [x]; + + useEffect(() => { + console.log(y); + }, [y]); +} + +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ value: "sathya" }], +}; + +``` + + +## Error + +``` + 9 | const y = [x]; + 10 | +> 11 | useEffect(() => { + | ^^^^^^^^^^^^^^^^^ +> 12 | console.log(y); + | ^^^^^^^^^^^^^^^^^^^ +> 13 | }, [y]); + | ^^^^^^^^^^ [ReactForget] InvalidReact: This effect may trigger an infinite loop: one or more of its dependencies could not be memoized due to a later mutation (11:13) + 14 | } + 15 | + 16 | export const FIXTURE_ENTRYPOINT = { +``` + + \ No newline at end of file diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.js new file mode 100644 index 0000000000..420ff41738 --- /dev/null +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.validate-memoized-effect-deps-invalidated-dep-value.js @@ -0,0 +1,19 @@ +// @validateMemoizedEffectDependencies +import { useHook } from "shared-runtime"; + +function Component(props) { + const x = []; + useHook(); // intersperse a hook call to prevent memoization of x + x.push(props.value); + + const y = [x]; + + useEffect(() => { + console.log(y); + }, [y]); +} + +export const FIXTURE_ENTRYPOINT = { + fn: Component, + params: [{ value: "sathya" }], +};