From 488b973d6838610a8f651d1c812fa82d74cf8bbd Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Tue, 18 Apr 2017 15:58:18 -0700 Subject: [PATCH] Use number type for bitfields Unions don't enumerate all the possible combinations of bitfields. I'm not actually sure why this was type-checking before. number doesn't provide much safety but it's more correct. --- .../shared/fiber/ReactTypeOfInternalContext.js | 2 +- .../shared/fiber/ReactTypeOfSideEffect.js | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/renderers/shared/fiber/ReactTypeOfInternalContext.js b/src/renderers/shared/fiber/ReactTypeOfInternalContext.js index 4c0c5762c7..89a3d2938d 100644 --- a/src/renderers/shared/fiber/ReactTypeOfInternalContext.js +++ b/src/renderers/shared/fiber/ReactTypeOfInternalContext.js @@ -12,7 +12,7 @@ 'use strict'; -export type TypeOfInternalContext = 0 | 1; +export type TypeOfInternalContext = number; module.exports = { NoContext: 0, diff --git a/src/renderers/shared/fiber/ReactTypeOfSideEffect.js b/src/renderers/shared/fiber/ReactTypeOfSideEffect.js index 087cf7394d..408d1d5001 100644 --- a/src/renderers/shared/fiber/ReactTypeOfSideEffect.js +++ b/src/renderers/shared/fiber/ReactTypeOfSideEffect.js @@ -12,16 +12,16 @@ 'use strict'; -export type TypeOfSideEffect = 0 | 1 | 2 | 3 | 4 | 8 | 16 | 32 | 64; +export type TypeOfSideEffect = number; module.exports = { - NoEffect: 0, // 0b0000000 - Placement: 1, // 0b0000001 - Update: 2, // 0b0000010 + NoEffect: 0, // 0b0000000 + Placement: 1, // 0b0000001 + Update: 2, // 0b0000010 PlacementAndUpdate: 3, // 0b0000011 - Deletion: 4, // 0b0000100 - ContentReset: 8, // 0b0001000 - Callback: 16, // 0b0010000 - Err: 32, // 0b0100000 - Ref: 64, // 0b1000000 + Deletion: 4, // 0b0000100 + ContentReset: 8, // 0b0001000 + Callback: 16, // 0b0010000 + Err: 32, // 0b0100000 + Ref: 64, // 0b1000000 };