diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js index 14baa79fa6..899b70510f 100644 --- a/scripts/rollup/build.js +++ b/scripts/rollup/build.js @@ -142,8 +142,8 @@ function getCommonJsConfig(bundleType) { // wrapped in __DEV__ return { ignore: [ - 'ReactPerf', - 'ReactTestUtils', + 'react-dom/lib/ReactPerf', + 'react-dom/lib/ReactTestUtils', ], }; } @@ -153,7 +153,7 @@ function getPlugins(entry, babelOpts, paths, filename, bundleType) { const plugins = [ replace( Object.assign( - replaceInternalModules(), + replaceInternalModules(bundleType), replaceFbjsModuleAliases(bundleType) ) ), diff --git a/scripts/rollup/modules.js b/scripts/rollup/modules.js index 5ea20b389d..16f10ac898 100644 --- a/scripts/rollup/modules.js +++ b/scripts/rollup/modules.js @@ -52,13 +52,21 @@ function getInternalModules() { }; } -function replaceInternalModules() { - return { - 'react-dom/lib/ReactPerf': resolve('./src/renderers/shared/ReactPerf.js'), - 'react-dom/lib/ReactTestUtils': resolve('./src/test/ReactTestUtils.js'), - 'react-dom/lib/ReactInstanceMap': resolve('./src/renderers/shared/shared/ReactInstanceMap.js'), - 'react-dom': resolve('./src/renderers/dom/ReactDOM.js'), - }; +function replaceInternalModules(bundleType) { + switch (bundleType) { + case bundleTypes.DEV: + case bundleTypes.PROD: + case bundleTypes.NODE: + // we inline these modules in the bundles rather than leave them as external + return { + 'react-dom/lib/ReactPerf': resolve('./src/renderers/shared/ReactPerf.js'), + 'react-dom/lib/ReactTestUtils': resolve('./src/test/ReactTestUtils.js'), + 'react-dom/lib/ReactInstanceMap': resolve('./src/renderers/shared/shared/ReactInstanceMap.js'), + 'react-dom': resolve('./src/renderers/dom/ReactDOM.js'), + }; + case bundleTypes.FB: + return {}; + } } function getFbjsModuleAliases(bundleType) {