From 425f72bdd4263dcaba829cf52545309bbfde56b4 Mon Sep 17 00:00:00 2001 From: Timothy Yung Date: Fri, 29 Mar 2024 12:47:00 -0700 Subject: [PATCH] Align React Native OSS/Test Feature Flags (#28677) ## Summary Makes a few changes to align React Native feature flags for open source and internal test renderer configurations. * Enable `enableSchedulingProfiler` for profiling builds. * Align `ReactFeatureFlags.test-renderer.native.js` (with `ReactFeatureFlags.native-fb.js`). * Enable `enableUseMemoCacheHook`. * Enable `enableFizzExternalRuntime`. * Disable `alwaysThrottleRetries`. ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ``` --- packages/shared/forks/ReactFeatureFlags.native-oss.js | 2 +- .../shared/forks/ReactFeatureFlags.test-renderer.native.js | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js index 5b821ae355..710b7ed4ef 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-oss.js +++ b/packages/shared/forks/ReactFeatureFlags.native-oss.js @@ -70,7 +70,7 @@ export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__; export const enableCPUSuspense = false; export const enableDebugTracing = false; export const enableAsyncDebugInfo = false; -export const enableSchedulingProfiler = false; +export const enableSchedulingProfiler = __PROFILE__; export const enableLegacyCache = false; export const enableFetchInstrumentation = false; export const enablePostpone = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js index c854951e5c..d36d9cfb60 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js @@ -13,7 +13,7 @@ import typeof * as ExportsType from './ReactFeatureFlags.test-renderer'; export const debugRenderPhaseSideEffectsForStrictMode = false; export const enableDebugTracing = false; export const enableAsyncDebugInfo = false; -export const enableSchedulingProfiler = false; +export const enableSchedulingProfiler = __PROFILE__; export const enableProfilerTimer = __PROFILE__; export const enableProfilerCommitHooks = __PROFILE__; export const enableProfilerNestedUpdatePhase = __PROFILE__; @@ -40,7 +40,7 @@ export const enableFilterEmptyStringAttributesDOM = true; export const enableGetInspectorDataForInstanceInProduction = false; export const enableSuspenseAvoidThisFallback = false; export const enableSuspenseAvoidThisFallbackFizz = false; -export const enableCPUSuspense = false; +export const enableCPUSuspense = true; export const enableUseMemoCacheHook = true; export const enableUseEffectEventHook = false; export const favorSafetyOverHydrationPerf = true; @@ -67,11 +67,12 @@ export const enableTransitionTracing = false; export const useModernStrictMode = false; export const enableDO_NOT_USE_disableStrictPassiveEffect = false; +export const enableFizzExternalRuntime = true; export const enableDeferRootSchedulingToMicrotask = false; export const enableAsyncActions = true; -export const alwaysThrottleRetries = true; +export const alwaysThrottleRetries = false; export const passChildrenWhenCloningPersistedNodes = false; export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__;