From 413e96d0cd1b58ed95d45166d14db77c057c67b2 Mon Sep 17 00:00:00 2001 From: cpojer Date: Tue, 10 Mar 2015 17:27:19 -0700 Subject: [PATCH] Add some important `getDOMNode` tests back. --- src/browser/ui/__tests__/ReactDOMComponent-test.js | 1 + src/core/__tests__/ReactCompositeComponent-test.js | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/src/browser/ui/__tests__/ReactDOMComponent-test.js b/src/browser/ui/__tests__/ReactDOMComponent-test.js index fe979f9a10..aabc6393bc 100644 --- a/src/browser/ui/__tests__/ReactDOMComponent-test.js +++ b/src/browser/ui/__tests__/ReactDOMComponent-test.js @@ -586,6 +586,7 @@ describe('ReactDOMComponent', function() { expect( ReactBrowserEventEmitter.getListener(rootNodeID, 'onClick') ).toBe(callback); + expect(rootNode).toBe(instance.getDOMNode()); React.unmountComponentAtNode(container); diff --git a/src/core/__tests__/ReactCompositeComponent-test.js b/src/core/__tests__/ReactCompositeComponent-test.js index 5ee125c597..4c2c8e3aad 100644 --- a/src/core/__tests__/ReactCompositeComponent-test.js +++ b/src/core/__tests__/ReactCompositeComponent-test.js @@ -154,6 +154,7 @@ describe('ReactCompositeComponent', function() { var anchor = instance.getAnchor(); var actualDOMAnchorNode = React.findDOMNode(anchor); expect(actualDOMAnchorNode.className).toBe(''); + expect(actualDOMAnchorNode).toBe(anchor.getDOMNode()); }); it('should auto bind methods and values correctly', function() { @@ -926,11 +927,21 @@ describe('ReactCompositeComponent', function() { expect(React.findDOMNode(comp.refs.static0).textContent).toBe('A'); expect(React.findDOMNode(comp.refs.static1).textContent).toBe('B'); + expect(React.findDOMNode(comp.refs.static0)) + .toBe(comp.refs.static0.getDOMNode()); + expect(React.findDOMNode(comp.refs.static1)) + .toBe(comp.refs.static1.getDOMNode()); + // When flipping the order, the refs should update even though the actual // contents do not comp.setProps({flipped: true}); expect(React.findDOMNode(comp.refs.static0).textContent).toBe('B'); expect(React.findDOMNode(comp.refs.static1).textContent).toBe('A'); + + expect(React.findDOMNode(comp.refs.static0)) + .toBe(comp.refs.static0.getDOMNode()); + expect(React.findDOMNode(comp.refs.static1)) + .toBe(comp.refs.static1.getDOMNode()); }); it('should allow access to findDOMNode in componentWillUnmount', function() { @@ -939,9 +950,11 @@ describe('ReactCompositeComponent', function() { var Component = React.createClass({ componentDidMount: function() { a = React.findDOMNode(this); + expect(a).toBe(this.getDOMNode()); }, componentWillUnmount: function() { b = React.findDOMNode(this); + expect(b).toBe(this.getDOMNode()); }, render: function() { return
;