From 411e04bd71715298de564a24dbf0304e17471ce0 Mon Sep 17 00:00:00 2001 From: Sasha Aickin Date: Sat, 24 Jun 2017 22:31:42 -0700 Subject: [PATCH] Add ReactDOMNodeStream, adding streaming rendering. (#10024) * Add ReactDOMNodeStream, adding ability to stream generated HTML. * Forgot to rename a documentation page. * Tests are passing locally but failing on CI; attempt to fix that with this tweak. * Adding some debugging info to try to track down CI problem. * More debugging of CI. Yay for printf debugging. * More printf debugging of CI to figure out what is going on with includes during tests. * I made a truly stupid error with my printf debugging statements for CI. Fixing that. * And another dumb copy and paste typo. * The node-stream.js stub for tests wasn't being added because of .gitignore. * Fix for code review coment https://github.com/facebook/react/pull/10024#discussion_r123606138 . Thanks to @razh for helping me out. * Removing all the console.logs I put in to debug the build problems on the CI server. * Fix for code review coment https://github.com/facebook/react/pull/10024#discussion_r123628227 . Thanks to @aweary for the suggestion. * Response to code review comment https://github.com/facebook/react/pull/10024#discussion_r123649131 . Thanks, @gaearon. * Responding to code comments https://github.com/facebook/react/pull/10024#pullrequestreview-46104491 , https://github.com/facebook/react/pull/10024#pullrequestreview-46104616 , and https://github.com/facebook/react/pull/10024#pullrequestreview-46104822 . Thanks to @sebmarkbage for the help. * Attempt to tweak spacing to see if it makes the prettier build step happy. * Found a prettier bug that wasn't being reported by npm run prettier for some reason. * Fixed a small prettier issue --- docs/_data/nav_docs.yml | 2 + docs/docs/reference-react-dom-node-stream.md | 42 +++++ packages/react-dom/node-stream.js | 7 + scripts/fiber/tests-passing.txt | 117 ++++++++++++ scripts/rollup/bundles.js | 35 +++- scripts/rollup/results.json | 172 ++++++++++++------ src/node_modules/react-dom/node-stream.js | 14 ++ src/node_modules/react-dom/server.js | 2 +- ...eamEntry.js => ReactDOMNodeStreamEntry.js} | 12 +- .../dom/ReactDOMNodeStreamRenderer.js | 66 +++++++ src/renderers/dom/ReactDOMServerEntry.js | 24 +++ src/renderers/dom/ReactDOMStringRenderer.js | 53 ++++++ .../ReactDOMServerIntegration-test.js | 82 +++++++-- ...verRenderer.js => ReactPartialRenderer.js} | 45 +---- 14 files changed, 548 insertions(+), 125 deletions(-) create mode 100644 docs/docs/reference-react-dom-node-stream.md create mode 100644 packages/react-dom/node-stream.js create mode 100644 src/node_modules/react-dom/node-stream.js rename src/renderers/dom/{ReactDOMServerStreamEntry.js => ReactDOMNodeStreamEntry.js} (62%) create mode 100644 src/renderers/dom/ReactDOMNodeStreamRenderer.js create mode 100644 src/renderers/dom/ReactDOMServerEntry.js create mode 100644 src/renderers/dom/ReactDOMStringRenderer.js rename src/renderers/shared/server/{ReactServerRenderer.js => ReactPartialRenderer.js} (94%) diff --git a/docs/_data/nav_docs.yml b/docs/_data/nav_docs.yml index b133b36186..1a015d253d 100644 --- a/docs/_data/nav_docs.yml +++ b/docs/_data/nav_docs.yml @@ -63,6 +63,8 @@ title: ReactDOM - id: react-dom-server title: ReactDOMServer + - id: react-dom-node-stream + title: ReactDOMNodeStream - id: dom-elements title: DOM Elements - id: events diff --git a/docs/docs/reference-react-dom-node-stream.md b/docs/docs/reference-react-dom-node-stream.md new file mode 100644 index 0000000000..23cbb670cd --- /dev/null +++ b/docs/docs/reference-react-dom-node-stream.md @@ -0,0 +1,42 @@ +--- +id: react-dom-node-stream +title: ReactDOMNodeStream +layout: docs +category: Reference +permalink: docs/react-dom-node-stream.html +--- + +If you use ES6 with npm, you can write `import ReactDOMNodeStream from 'react-dom/node-stream'`. If you use ES5 with npm, you can write `var ReactDOMNodeStream = require('react-dom/node-stream')`. + +Unlike other packages in React, `ReactDOMNodeStream` depends on a package (`stream`) that is available in Node.js but not in the browser. For this reason, there is no `