Fix portal unmounting

When unmount a portal, we need to unmount *its* children from itself.
This is similar to what we would do for a root if we allowed deleting roots.
This commit is contained in:
Dan Abramov committed 2016-12-09 16:09:29 +00:00
1 parent 8eb192b92f
commit 3ba8069fef
3 files changed
+20 -5

No files matched your search

-1
View File
@@ -19,7 +19,6 @@ src/renderers/dom/__tests__/ReactDOMProduction-test.js
* should throw with an error code in production
src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
* should keep track of namespace across portals (medium)
* should unwind namespaces on caught errors in a portal
src/renderers/dom/shared/__tests__/ReactDOM-test.js
+1
View File
@@ -515,6 +515,7 @@ src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
* should render many portals
* should render nested portals
* should keep track of namespace across portals (simple)
* should keep track of namespace across portals (medium)
* should keep track of namespace across portals (complex)
* should unwind namespaces on uncaught errors
* should unwind namespaces on caught errors