From 39dbb14da321cabafe3ab67de41150672aa301fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Fri, 15 Nov 2019 11:46:07 -0800 Subject: [PATCH] [Flight] Move Flight DOM to a Webpack Specific Package (#17372) * Move Flight DOM to Webpack Specific Packagee We'll have Webpack specific coupling so we need to ensure that it can be versioned separately from various Webpack versions. We'll also have builds for other bundlers in the future. * Move to peerDep * Move DOM Flight Tests * Merge ReactFlightIntegration into ReactFlightDOM This was an integration test. We can add to it. * Fix fixture paths --- fixtures/flight-browser/index.html | 4 +- fixtures/flight/server/handler.js | 2 +- fixtures/flight/src/index.js | 2 +- .../react-dom/npm/unstable-flight-client.js | 7 -- .../npm/unstable-flight-server.browser.js | 7 -- .../react-dom/npm/unstable-flight-server.js | 3 - .../npm/unstable-flight-server.node.js | 7 -- packages/react-dom/package.json | 7 +- .../src/__tests__/ReactFlightDOM-test.js | 92 ------------------- packages/react-flight-dom-webpack/README.md | 5 + .../index.js} | 2 +- .../react-flight-dom-webpack/npm/index.js | 7 ++ .../npm/server.browser.js | 7 ++ .../react-flight-dom-webpack/npm/server.js | 3 + .../npm/server.node.js | 7 ++ .../react-flight-dom-webpack/package.json | 48 ++++++++++ .../server.browser.js} | 2 +- .../server.js} | 2 +- .../server.node.js} | 2 +- .../src}/ReactFlightDOMClient.js | 0 .../src}/ReactFlightDOMServerBrowser.js | 0 .../src}/ReactFlightDOMServerNode.js | 0 .../src/__tests__/ReactFlightDOM-test.js} | 50 +++++++++- .../__tests__/ReactFlightDOMBrowser-test.js | 4 +- .../src/ReactFlightHostConfigBrowser.js} | 0 ...ReactFlightClientHostConfig.dom-browser.js | 2 +- .../forks/ReactFlightClientHostConfig.dom.js | 2 +- .../src}/ReactDOMServerFormatConfig.js | 0 .../ReactServerFormatConfig.dom-browser.js | 2 +- .../src/forks/ReactServerFormatConfig.dom.js | 2 +- scripts/rollup/bundles.js | 10 +- scripts/shared/inlinedHostConfigs.js | 8 +- yarn.lock | 29 ++++++ 33 files changed, 177 insertions(+), 148 deletions(-) delete mode 100644 packages/react-dom/npm/unstable-flight-client.js delete mode 100644 packages/react-dom/npm/unstable-flight-server.browser.js delete mode 100644 packages/react-dom/npm/unstable-flight-server.js delete mode 100644 packages/react-dom/npm/unstable-flight-server.node.js delete mode 100644 packages/react-dom/src/__tests__/ReactFlightDOM-test.js create mode 100644 packages/react-flight-dom-webpack/README.md rename packages/{react-dom/unstable-flight-client.js => react-flight-dom-webpack/index.js} (82%) create mode 100644 packages/react-flight-dom-webpack/npm/index.js create mode 100644 packages/react-flight-dom-webpack/npm/server.browser.js create mode 100644 packages/react-flight-dom-webpack/npm/server.js create mode 100644 packages/react-flight-dom-webpack/npm/server.node.js create mode 100644 packages/react-flight-dom-webpack/package.json rename packages/{react-dom/unstable-flight-server.browser.js => react-flight-dom-webpack/server.browser.js} (81%) rename packages/{react-dom/unstable-flight-server.js => react-flight-dom-webpack/server.js} (78%) rename packages/{react-dom/unstable-flight-server.node.js => react-flight-dom-webpack/server.node.js} (81%) rename packages/{react-dom/src/client/flight => react-flight-dom-webpack/src}/ReactFlightDOMClient.js (100%) rename packages/{react-dom/src/server/flight => react-flight-dom-webpack/src}/ReactFlightDOMServerBrowser.js (100%) rename packages/{react-dom/src/server/flight => react-flight-dom-webpack/src}/ReactFlightDOMServerNode.js (100%) rename packages/{react-dom/src/__tests__/ReactFlightIntegration-test.js => react-flight-dom-webpack/src/__tests__/ReactFlightDOM-test.js} (87%) rename packages/{react-dom => react-flight-dom-webpack}/src/__tests__/ReactFlightDOMBrowser-test.js (91%) rename packages/{react-dom/src/client/flight/ReactFlightDOMHostConfig.js => react-flight/src/ReactFlightHostConfigBrowser.js} (100%) rename packages/{react-dom/src/server => react-server/src}/ReactDOMServerFormatConfig.js (100%) diff --git a/fixtures/flight-browser/index.html b/fixtures/flight-browser/index.html index b7e145732c..1fef79b182 100644 --- a/fixtures/flight-browser/index.html +++ b/fixtures/flight-browser/index.html @@ -19,8 +19,8 @@ - - + +