From 5ec387aa829d0f9bef9b1e2871491c4c30fcf188 Mon Sep 17 00:00:00 2001 From: Marvin Hagemeister Date: Mon, 1 Jul 2019 23:35:35 +0200 Subject: [PATCH 1/2] Mark reload-and-profile attach as configurable --- shells/browser/shared/src/renderer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/shells/browser/shared/src/renderer.js b/shells/browser/shared/src/renderer.js index c4cc4c6f55..98e7a0d488 100644 --- a/shells/browser/shared/src/renderer.js +++ b/shells/browser/shared/src/renderer.js @@ -15,6 +15,7 @@ Object.defineProperty( '__REACT_DEVTOOLS_ATTACH__', ({ enumerable: false, + configurable: true, get() { return attach; }, From 8e90194f7d38136be48bfebc8fc3c45d88dbc2d6 Mon Sep 17 00:00:00 2001 From: Marvin Hagemeister Date: Mon, 1 Jul 2019 23:48:52 +0200 Subject: [PATCH 2/2] Add comment about 3rd party integrations --- shells/browser/shared/src/renderer.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/shells/browser/shared/src/renderer.js b/shells/browser/shared/src/renderer.js index 98e7a0d488..0a0e74808e 100644 --- a/shells/browser/shared/src/renderer.js +++ b/shells/browser/shared/src/renderer.js @@ -15,6 +15,9 @@ Object.defineProperty( '__REACT_DEVTOOLS_ATTACH__', ({ enumerable: false, + // This property needs to be configurable to allow third-party integrations + // to attach their own renderer. Note that using third-party integrations + // is not officially supported. Use at your own risk. configurable: true, get() { return attach;