From 385eb1cef17b8babfdade6b448a618e7e1c679db Mon Sep 17 00:00:00 2001 From: Juraj Dudak Date: Fri, 18 Apr 2014 12:48:01 -0700 Subject: [PATCH] Fixed a bug in expectRenderedChildAt React components have _mountIndex, that looks like it is their order in DOM. If you swap 2 elements in DOM, their order in children array isn't changed, but their _mountIndex is --- src/test/reactComponentExpect.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/test/reactComponentExpect.js b/src/test/reactComponentExpect.js index 7c42694799..2288684440 100644 --- a/src/test/reactComponentExpect.js +++ b/src/test/reactComponentExpect.js @@ -73,17 +73,14 @@ mergeInto(reactComponentExpect.prototype, { // change soon. this.toBeDOMComponent(); var renderedChildren = this.instance()._renderedChildren || {}; - var nonEmptyCount = 0; - var name; for (name in renderedChildren) { if (!renderedChildren.hasOwnProperty(name)) { continue; } if (renderedChildren[name]) { - if (nonEmptyCount === childIndex) { + if (renderedChildren[name]._mountIndex === childIndex) { return new reactComponentExpect(renderedChildren[name]); } - nonEmptyCount++; } } throw new Error('Child:' + childIndex + ' is not found');