From 608b4e4109a1a09b8fdb0f297d07c79c9cb7a31e Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Thu, 16 Jan 2025 15:03:45 -0500 Subject: [PATCH] [ci] Only notify after labeling --- .github/workflows/compiler_discord_notify.yml | 1 + .github/workflows/runtime_discord_notify.yml | 1 + .github/workflows/shared_core_label.yml | 41 ------------------- 3 files changed, 2 insertions(+), 41 deletions(-) delete mode 100644 .github/workflows/shared_core_label.yml diff --git a/.github/workflows/compiler_discord_notify.yml b/.github/workflows/compiler_discord_notify.yml index febd55764b..b9cc3e9b9f 100644 --- a/.github/workflows/compiler_discord_notify.yml +++ b/.github/workflows/compiler_discord_notify.yml @@ -2,6 +2,7 @@ name: (Compiler) Discord Notify on: pull_request_target: + types: [labeled] paths: - compiler/** - .github/workflows/compiler_**.yml diff --git a/.github/workflows/runtime_discord_notify.yml b/.github/workflows/runtime_discord_notify.yml index 18304046d7..abf7970a1e 100644 --- a/.github/workflows/runtime_discord_notify.yml +++ b/.github/workflows/runtime_discord_notify.yml @@ -2,6 +2,7 @@ name: (Runtime) Discord Notify on: pull_request_target: + types: [labeled] paths-ignore: - compiler/** - .github/workflows/compiler_**.yml diff --git a/.github/workflows/shared_core_label.yml b/.github/workflows/shared_core_label.yml deleted file mode 100644 index da2c45465e..0000000000 --- a/.github/workflows/shared_core_label.yml +++ /dev/null @@ -1,41 +0,0 @@ -name: (Shared) Core Label - -on: - pull_request_target: - -env: - TZ: /usr/share/zoneinfo/America/Los_Angeles - # https://github.com/actions/cache/blob/main/tips-and-workarounds.md#cache-segment-restore-timeout - SEGMENT_DOWNLOAD_TIMEOUT_MINS: 1 - -jobs: - core_label: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - name: Check if actor is maintainer - id: check_maintainer - uses: actions/github-script@v7 - with: - script: | - const fs = require('fs'); - const actor = '${{ github.actor }}'; - const data = await fs.readFileSync('./MAINTAINERS', { encoding: 'utf8' }); - const maintainers = new Set(data.split('\n')); - if (maintainers.has(actor)) { - console.log(`🟢 ${actor} is a maintainer`); - return true; - } - console.log(`🔴 ${actor} is NOT a maintainer`); - return null; - - name: Label PR as React Core Team - if: ${{ steps.check_maintainer.outputs.result }} - uses: actions/github-script@v7 - with: - script: | - github.rest.issues.addLabels({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: ${{ github.event.number }}, - labels: ['React Core Team'] - });