From 335e91df7146739dcc287b638e29b068f1451bbe Mon Sep 17 00:00:00 2001 From: Miorel Palii Date: Fri, 29 Aug 2014 08:50:07 -0700 Subject: [PATCH] Fix console warning in LegacyImmutableObject It does check `hasOwnProperty`, but *after* accessing the field and therefore triggering enumerable getters in modified prototypes. --- src/utils/LegacyImmutableObject.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/utils/LegacyImmutableObject.js b/src/utils/LegacyImmutableObject.js index 2862dd47ee..e7383ae911 100644 --- a/src/utils/LegacyImmutableObject.js +++ b/src/utils/LegacyImmutableObject.js @@ -81,9 +81,11 @@ if (__DEV__) { } Object.freeze(object); // First freeze the object. for (var prop in object) { - var field = object[prop]; - if (object.hasOwnProperty(prop) && shouldRecurseFreeze(field)) { - deepFreeze(field); + if (object.hasOwnProperty(prop)) { + var field = object[prop]; + if (shouldRecurseFreeze(field)) { + deepFreeze(field); + } } } };