From 2ddf8caa9d3abd22f54304bf7650e512efb93f18 Mon Sep 17 00:00:00 2001 From: lauren Date: Wed, 16 Apr 2025 18:00:25 -0400 Subject: [PATCH] [ci] Fix check_access again (#32935) I can see the value being output and set correctly but not sure why it's skipping the 2nd job. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32935). * #32936 * __->__ #32935 --- .github/workflows/compiler_discord_notify.yml | 10 +++++----- .github/workflows/runtime_discord_notify.yml | 10 +++++----- .github/workflows/shared_label_core_team_prs.yml | 10 +++++----- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/compiler_discord_notify.yml b/.github/workflows/compiler_discord_notify.yml index 21202a8004..71aea56e84 100644 --- a/.github/workflows/compiler_discord_notify.yml +++ b/.github/workflows/compiler_discord_notify.yml @@ -13,15 +13,15 @@ jobs: check_access: runs-on: ubuntu-latest outputs: - is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }} + is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }} steps: - - name: Check access - id: check_access + - name: Check is member or collaborator + id: check_is_member_or_collaborator if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }} - run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT" + run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT" check_maintainer: - if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }} + if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }} needs: [check_access] uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main permissions: diff --git a/.github/workflows/runtime_discord_notify.yml b/.github/workflows/runtime_discord_notify.yml index c3240ef88e..44775fbe78 100644 --- a/.github/workflows/runtime_discord_notify.yml +++ b/.github/workflows/runtime_discord_notify.yml @@ -13,15 +13,15 @@ jobs: check_access: runs-on: ubuntu-latest outputs: - is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }} + is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }} steps: - - name: Check access - id: check_access + - name: Check is member or collaborator + id: check_is_member_or_collaborator if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }} - run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT" + run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT" check_maintainer: - if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }} + if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }} needs: [check_access] uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main permissions: diff --git a/.github/workflows/shared_label_core_team_prs.yml b/.github/workflows/shared_label_core_team_prs.yml index df75ff5042..73e7261f56 100644 --- a/.github/workflows/shared_label_core_team_prs.yml +++ b/.github/workflows/shared_label_core_team_prs.yml @@ -14,15 +14,15 @@ jobs: check_access: runs-on: ubuntu-latest outputs: - is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }} + is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }} steps: - - name: Check access - id: check_access + - name: Check is member or collaborator + id: check_is_member_or_collaborator if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }} - run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT" + run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT" check_maintainer: - if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }} + if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }} needs: [check_access] uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main permissions: