From 2b44565fca3f78dd825733f218858f0c178a7dd5 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 30 May 2017 15:49:32 +0100 Subject: [PATCH] Don't build some stack bundles (#9812) * Don't build ReactDOMStack and ReactARTStack bundles * Regenerate results.json --- scripts/rollup/bundles.js | 62 ------------------------------------- scripts/rollup/results.json | 8 ++--- src/fb/ReactDOMFBEntry.js | 52 ------------------------------- 3 files changed, 4 insertions(+), 118 deletions(-) delete mode 100644 src/fb/ReactDOMFBEntry.js diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js index b6b5d40de7..07f9acf5ea 100644 --- a/scripts/rollup/bundles.js +++ b/scripts/rollup/bundles.js @@ -65,33 +65,6 @@ const bundles = [ }, /******* React DOM *******/ - { - babelOpts: babelOptsReact, - bundleTypes: [FB_DEV, FB_PROD], - config: { - destDir: 'build/', - globals: { - react: 'React', - }, - moduleName: 'ReactDOM', - sourceMap: false, - }, - entry: 'src/renderers/dom/ReactDOM.js', - externals: ['prop-types', 'prop-types/checkPropTypes'], - fbEntry: 'src/fb/ReactDOMFBEntry.js', - hasteName: 'ReactDOMStack', - isRenderer: true, - label: 'dom-stack', - manglePropertiesOnProd: false, - name: 'react-dom-stack', - paths: [ - 'src/renderers/dom/**/*.js', - 'src/renderers/shared/**/*.js', - - 'src/ReactVersion.js', - 'src/shared/**/*.js', - ], - }, { babelOpts: babelOptsReact, bundleTypes: [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD, FB_DEV, FB_PROD], @@ -209,41 +182,6 @@ const bundles = [ }, /******* React ART *******/ - { - babelOpts: babelOptsReactART, - // TODO: we merge react-art repo into this repo so the NODE_DEV and NODE_PROD - // builds sync up to the building of the package directories - bundleTypes: [FB_DEV, FB_PROD], - config: { - destDir: 'build/', - globals: { - react: 'React', - }, - moduleName: 'ReactART', - sourceMap: false, - }, - entry: 'src/renderers/art/ReactARTStack.js', - externals: [ - 'art/modes/current', - 'art/modes/fast-noSideEffects', - 'art/core/transform', - 'prop-types/checkPropTypes', - 'react-dom', - ], - fbEntry: 'src/renderers/art/ReactARTStack.js', - hasteName: 'ReactARTStack', - isRenderer: true, - label: 'art-stack', - manglePropertiesOnProd: false, - name: 'react-art', - paths: [ - 'src/renderers/art/**/*.js', - 'src/renderers/shared/**/*.js', - - 'src/ReactVersion.js', - 'src/shared/**/*.js', - ], - }, { babelOpts: babelOptsReactART, // TODO: we merge react-art repo into this repo so the NODE_DEV and NODE_PROD diff --git a/scripts/rollup/results.json b/scripts/rollup/results.json index d2b51d9c2f..0787402e94 100644 --- a/scripts/rollup/results.json +++ b/scripts/rollup/results.json @@ -165,12 +165,12 @@ "gzip": 85249 }, "ReactNativeStack-dev.js (RN_DEV)": { - "size": 182305, - "gzip": 35469 + "size": 182421, + "gzip": 35496 }, "ReactNativeStack-prod.js (RN_PROD)": { - "size": 134072, - "gzip": 25710 + "size": 134188, + "gzip": 25741 }, "ReactNativeFiber-dev.js (RN_DEV)": { "size": 278278, diff --git a/src/fb/ReactDOMFBEntry.js b/src/fb/ReactDOMFBEntry.js deleted file mode 100644 index c4e8c003fc..0000000000 --- a/src/fb/ReactDOMFBEntry.js +++ /dev/null @@ -1,52 +0,0 @@ -/** - * Copyright 2013-present, Facebook, Inc. - * All rights reserved. - * - * This source code is licensed under the BSD-style license found in the - * LICENSE file in the root directory of this source tree. An additional grant - * of patent rights can be found in the PATENTS file in the same directory. - */ - -'use strict'; - -var ReactDOM = require('ReactDOM'); - -Object.assign(ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, { - // These should be easy to copy into react_contrib and remove from here: - adler32: require('adler32'), - getVendorPrefixedEventName: require('getVendorPrefixedEventName'), - getEventCharCode: require('getEventCharCode'), - getEventKey: require('getEventKey'), - getEventTarget: require('getEventTarget'), - isEventSupported: require('isEventSupported'), - setInnerHTML: require('setInnerHTML'), - setTextContent: require('setTextContent'), - PooledClass: require('PooledClass'), - ReactDOMSelection: require('ReactDOMSelection'), - ReactInputSelection: require('ReactInputSelection'), - // These are mostly used in incorrect Flow typings and are codemoddable: - SyntheticEvent: require('SyntheticEvent'), - SyntheticKeyboardEvent: require('SyntheticKeyboardEvent'), - SyntheticMouseEvent: require('SyntheticMouseEvent'), - // These are real internal dependencies that are trickier to remove: - ReactBrowserEventEmitter: require('ReactBrowserEventEmitter'), - ReactErrorUtils: require('ReactErrorUtils'), - ReactDOMComponentTree: require('ReactDOMComponentTree'), - ReactInstanceMap: require('ReactInstanceMap'), - // This is used for ajaxify on www: - DOMProperty: require('DOMProperty'), - // These are dependencies of TapEventPlugin: - EventPluginUtils: require('EventPluginUtils'), - EventPropagators: require('EventPropagators'), - SyntheticUIEvent: require('SyntheticUIEvent'), -}); - -if (__DEV__) { - Object.assign(ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, { - // ReactPerf currently only works with the DOM renderer - // so we expose it here, but only in DEV mode. - ReactPerf: require('ReactPerf'), - }); -} - -module.exports = ReactDOM;