From 28fcf2f1c7065cf91bb5fe336de618b59a052af4 Mon Sep 17 00:00:00 2001 From: acdlite Date: Fri, 23 Feb 2024 21:56:58 +0000 Subject: [PATCH] Delete use of `source` in JSX runtime (#28433) Only remaining place it was being used was in a warning message. DiffTrain build for [16d3f7833d25b1ea026add83dd109601b60f138e](https://github.com/facebook/react/commit/16d3f7833d25b1ea026add83dd109601b60f138e) --- .../facebook-www/JSXDEVRuntime-dev.classic.js | 20 ---------- .../facebook-www/JSXDEVRuntime-dev.modern.js | 20 ---------- compiled/facebook-www/REVISION | 2 +- compiled/facebook-www/React-dev.classic.js | 38 +------------------ compiled/facebook-www/React-dev.modern.js | 38 +------------------ compiled/facebook-www/React-prod.modern.js | 2 +- .../facebook-www/ReactServer-dev.modern.js | 38 +------------------ 7 files changed, 5 insertions(+), 153 deletions(-) diff --git a/compiled/facebook-www/JSXDEVRuntime-dev.classic.js b/compiled/facebook-www/JSXDEVRuntime-dev.classic.js index 7be7a0eea0..cb6c350af2 100644 --- a/compiled/facebook-www/JSXDEVRuntime-dev.classic.js +++ b/compiled/facebook-www/JSXDEVRuntime-dev.classic.js @@ -1104,14 +1104,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendum(source); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1301,18 +1293,6 @@ if (__DEV__) { return ""; } } - - function getSourceInfoErrorAddendum(source) { - { - if (source !== undefined) { - var fileName = source.fileName.replace(/^.*[\\\/]/, ""); - var lineNumber = source.lineNumber; - return "\n\nCheck your code at " + fileName + ":" + lineNumber + "."; - } - - return ""; - } - } /** * Ensure that every element either is passed in a static location, in an * array with an explicit keys property defined, or in an object literal diff --git a/compiled/facebook-www/JSXDEVRuntime-dev.modern.js b/compiled/facebook-www/JSXDEVRuntime-dev.modern.js index e840f3f6a5..d900e92320 100644 --- a/compiled/facebook-www/JSXDEVRuntime-dev.modern.js +++ b/compiled/facebook-www/JSXDEVRuntime-dev.modern.js @@ -1104,14 +1104,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendum(source); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1301,18 +1293,6 @@ if (__DEV__) { return ""; } } - - function getSourceInfoErrorAddendum(source) { - { - if (source !== undefined) { - var fileName = source.fileName.replace(/^.*[\\\/]/, ""); - var lineNumber = source.lineNumber; - return "\n\nCheck your code at " + fileName + ":" + lineNumber + "."; - } - - return ""; - } - } /** * Ensure that every element either is passed in a static location, in an * array with an explicit keys property defined, or in an object literal diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION index 007f153c5c..5cded15609 100644 --- a/compiled/facebook-www/REVISION +++ b/compiled/facebook-www/REVISION @@ -1 +1 @@ -d579e7748218920331252b0528850943d5e2dd31 +16d3f7833d25b1ea026add83dd109601b60f138e diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js index cd5fadb049..25dbe7c0fe 100644 --- a/compiled/facebook-www/React-dev.classic.js +++ b/compiled/facebook-www/React-dev.classic.js @@ -24,7 +24,7 @@ if (__DEV__) { ) { __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error()); } - var ReactVersion = "18.3.0-www-classic-7910dce1"; + var ReactVersion = "18.3.0-www-classic-bce6b49b"; // ATTENTION // When adding new symbols to this file, @@ -1509,14 +1509,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendum(source); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1717,14 +1709,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendumForProps(config); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -2042,26 +2026,6 @@ if (__DEV__) { return ""; } } - - function getSourceInfoErrorAddendumForProps(elementProps) { - if (elementProps !== null && elementProps !== undefined) { - return getSourceInfoErrorAddendum(elementProps.__source); - } - - return ""; - } - - function getSourceInfoErrorAddendum(source) { - { - if (source !== undefined) { - var fileName = source.fileName.replace(/^.*[\\\/]/, ""); - var lineNumber = source.lineNumber; - return "\n\nCheck your code at " + fileName + ":" + lineNumber + "."; - } - - return ""; - } - } /** * Ensure that every element either is passed in a static location, in an * array with an explicit keys property defined, or in an object literal diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js index c73d59b67a..5951a9e7d7 100644 --- a/compiled/facebook-www/React-dev.modern.js +++ b/compiled/facebook-www/React-dev.modern.js @@ -24,7 +24,7 @@ if (__DEV__) { ) { __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error()); } - var ReactVersion = "18.3.0-www-modern-a1866c69"; + var ReactVersion = "18.3.0-www-modern-93c46cbf"; // ATTENTION // When adding new symbols to this file, @@ -1509,14 +1509,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendum(source); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1717,14 +1709,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendumForProps(config); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1998,26 +1982,6 @@ if (__DEV__) { return ""; } } - - function getSourceInfoErrorAddendumForProps(elementProps) { - if (elementProps !== null && elementProps !== undefined) { - return getSourceInfoErrorAddendum(elementProps.__source); - } - - return ""; - } - - function getSourceInfoErrorAddendum(source) { - { - if (source !== undefined) { - var fileName = source.fileName.replace(/^.*[\\\/]/, ""); - var lineNumber = source.lineNumber; - return "\n\nCheck your code at " + fileName + ":" + lineNumber + "."; - } - - return ""; - } - } /** * Ensure that every element either is passed in a static location, in an * array with an explicit keys property defined, or in an object literal diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js index 6989633383..472e0d9ef7 100644 --- a/compiled/facebook-www/React-prod.modern.js +++ b/compiled/facebook-www/React-prod.modern.js @@ -625,4 +625,4 @@ exports.useSyncExternalStore = function ( exports.useTransition = function () { return ReactCurrentDispatcher.current.useTransition(); }; -exports.version = "18.3.0-www-modern-9a917e2a"; +exports.version = "18.3.0-www-modern-9b3a58e1"; diff --git a/compiled/facebook-www/ReactServer-dev.modern.js b/compiled/facebook-www/ReactServer-dev.modern.js index 3d7a46feee..f4388562f6 100644 --- a/compiled/facebook-www/ReactServer-dev.modern.js +++ b/compiled/facebook-www/ReactServer-dev.modern.js @@ -1222,14 +1222,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendum(source); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1430,14 +1422,6 @@ if (__DEV__) { "it's defined in, or you might have mixed up default and named imports."; } - var sourceInfo = getSourceInfoErrorAddendumForProps(config); - - if (sourceInfo) { - info += sourceInfo; - } else { - info += getDeclarationErrorAddendum(); - } - var typeString; if (type === null) { @@ -1711,26 +1695,6 @@ if (__DEV__) { return ""; } } - - function getSourceInfoErrorAddendumForProps(elementProps) { - if (elementProps !== null && elementProps !== undefined) { - return getSourceInfoErrorAddendum(elementProps.__source); - } - - return ""; - } - - function getSourceInfoErrorAddendum(source) { - { - if (source !== undefined) { - var fileName = source.fileName.replace(/^.*[\\\/]/, ""); - var lineNumber = source.lineNumber; - return "\n\nCheck your code at " + fileName + ":" + lineNumber + "."; - } - - return ""; - } - } /** * Ensure that every element either is passed in a static location, in an * array with an explicit keys property defined, or in an object literal @@ -2836,7 +2800,7 @@ if (__DEV__) { console["error"](error); }; - var ReactVersion = "18.3.0-www-modern-915264c7"; + var ReactVersion = "18.3.0-www-modern-c59d517b"; // Patch fetch var Children = {