From 25dbb3556ee9802c18f45c278abf3c33711237eb Mon Sep 17 00:00:00 2001 From: Timothy Yung Date: Thu, 22 Feb 2024 15:40:12 -0800 Subject: [PATCH] Dynamic `enableComponentStackLocations` Flag for React Native (FB) (#28400) ## Summary Changes the `enableComponentStackLocations` feature flag to be dynamic for React Native (FB), so that it can be evaluated for compatibility before eventually being enabled for React Native. ## How did you test this change? I'll be importing this PR to test it. --- packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js | 1 + packages/shared/forks/ReactFeatureFlags.native-fb.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js b/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js index c87bda1f57..ccaa927e65 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js @@ -21,6 +21,7 @@ import typeof * as DynamicFlagsType from 'ReactNativeInternalFeatureFlags'; // update the test configuration. export const alwaysThrottleRetries = __VARIANT__; +export const enableComponentStackLocations = __VARIANT__; export const enableDeferRootSchedulingToMicrotask = __VARIANT__; export const enableUseRefAccessWarning = __VARIANT__; export const passChildrenWhenCloningPersistedNodes = __VARIANT__; diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index f62604774e..42d7a0bbcf 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -19,6 +19,7 @@ import * as dynamicFlags from 'ReactNativeInternalFeatureFlags'; // the exports object every time a flag is read. export const { alwaysThrottleRetries, + enableComponentStackLocations, enableDeferRootSchedulingToMicrotask, enableUseRefAccessWarning, passChildrenWhenCloningPersistedNodes, @@ -62,7 +63,6 @@ export const enableCPUSuspense = true; export const enableUseMemoCacheHook = true; export const enableUseEffectEventHook = false; export const enableClientRenderFallbackOnTextMismatch = true; -export const enableComponentStackLocations = false; export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = true; export const enableGetInspectorDataForInstanceInProduction = true;