From 1d3558965f691ca8c01387e5b620fd7263fbcd19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Wed, 2 Jun 2021 14:28:06 -0400 Subject: [PATCH] Disable deferRenderPhaseUpdateToNextBatch by default (#21605) We're still experimenting with this and it causes a breaking behavior for setState in componentWillMount/componentWillReceiveProps atm. --- packages/shared/ReactFeatureFlags.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-fb.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-oss.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.native.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.www.js | 2 +- packages/shared/forks/ReactFeatureFlags.testing.js | 2 +- packages/shared/forks/ReactFeatureFlags.testing.www.js | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js index 29232d83a5..d9ea72340c 100644 --- a/packages/shared/ReactFeatureFlags.js +++ b/packages/shared/ReactFeatureFlags.js @@ -158,7 +158,7 @@ export const enableLegacyFBSupport = false; // not currently rendering. We treat them the same as if they came from an // interleaved event. Remove this flag once we have migrated to the // new behavior. -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableUseRefAccessWarning = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index 27d10c9f0f..2fc1faa80c 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -50,7 +50,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = __DEV__; export const createRootStrictEffectsByDefault = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js index 1f8722560c..28bd6d0e07 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-oss.js +++ b/packages/shared/forks/ReactFeatureFlags.native-oss.js @@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = false; export const createRootStrictEffectsByDefault = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js index 888bedb396..4dc6686c61 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.js @@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = false; export const createRootStrictEffectsByDefault = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js index 7eb2c151d1..600eb80153 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js @@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = false; export const createRootStrictEffectsByDefault = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js index 7699c52b14..506c778765 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js @@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = true; export const createRootStrictEffectsByDefault = false; diff --git a/packages/shared/forks/ReactFeatureFlags.testing.js b/packages/shared/forks/ReactFeatureFlags.testing.js index 7af17d70fa..0556a6e494 100644 --- a/packages/shared/forks/ReactFeatureFlags.testing.js +++ b/packages/shared/forks/ReactFeatureFlags.testing.js @@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = false; export const createRootStrictEffectsByDefault = false; diff --git a/packages/shared/forks/ReactFeatureFlags.testing.www.js b/packages/shared/forks/ReactFeatureFlags.testing.www.js index 01f184c1e4..06cc9bed8f 100644 --- a/packages/shared/forks/ReactFeatureFlags.testing.www.js +++ b/packages/shared/forks/ReactFeatureFlags.testing.www.js @@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; -export const deferRenderPhaseUpdateToNextBatch = true; +export const deferRenderPhaseUpdateToNextBatch = false; export const enableStrictEffects = false; export const createRootStrictEffectsByDefault = false;