From 1b5ef83b783530ac7ccafea0208921080cd2f2d6 Mon Sep 17 00:00:00 2001 From: Joe Savona Date: Mon, 11 Dec 2023 11:34:21 -0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=8C=B2=20Separate=20flag=20for=20jsx=20co?= =?UTF-8?q?mpilation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per discussion w @pieterv we'd like to have a mode where we compile JSX separately, so splitting this flag into two variants. --- .../packages/babel-plugin-react-forget/src/HIR/Environment.ts | 2 ++ compiler/packages/sprout/src/SproutTodoFilter.ts | 1 + 2 files changed, 3 insertions(+) diff --git a/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts b/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts index 67c1e7d702..aa3c523985 100644 --- a/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts +++ b/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts @@ -104,6 +104,8 @@ const EnvironmentConfigSchema = z.object({ // 🌲 enableForest: z.boolean().default(false), + // <🌲> + enableForestJsx: z.boolean().default(false), /* * Enable memoization of JSX elements in addition to other types of values. When disabled, diff --git a/compiler/packages/sprout/src/SproutTodoFilter.ts b/compiler/packages/sprout/src/SproutTodoFilter.ts index 7990cc08ea..c3e91bd76e 100644 --- a/compiler/packages/sprout/src/SproutTodoFilter.ts +++ b/compiler/packages/sprout/src/SproutTodoFilter.ts @@ -423,6 +423,7 @@ const skipFilter = new Set([ // TODO: 🌲 "forest-basic", + "forest-basic-jsx", // TODO: we probably want to always skip these "rules-of-hooks/rules-of-hooks-0592bd574811",