From 19b4abed69643be0c6410c6d4a4fdb23c276ef0e Mon Sep 17 00:00:00 2001 From: Joe Savona Date: Tue, 13 Feb 2024 16:45:17 -0800 Subject: [PATCH] [be] Remove unused validateRefAccessDuringRenderFunctionExpressions flag I had split this up from the main validation since function validation was less precise; now that previous PRs fix the false positives we can remove this extra flag. --- .../babel-plugin-react-forget/src/HIR/Environment.ts | 8 -------- ...iased-ref-in-callback-invoked-during-render-.expect.md | 2 +- ...alid-aliased-ref-in-callback-invoked-during-render-.js | 2 +- ...nvalid-ref-in-callback-invoked-during-render.expect.md | 2 +- ...error.invalid-ref-in-callback-invoked-during-render.js | 2 +- 5 files changed, 4 insertions(+), 12 deletions(-) diff --git a/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts b/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts index 08817866b9..0eef92fef7 100644 --- a/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts +++ b/compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts @@ -172,14 +172,6 @@ const EnvironmentConfigSchema = z.object({ // Validate that ref values (`ref.current`) are not accessed during render. validateRefAccessDuringRender: z.boolean().default(false), - /** - * Extension of validateRefAccessDuringRender that validates that refs are not accessed during - * render indirectly by calling function expressions which access the ref. - * - * This validation has known issues and is not yet recommended - */ - validateRefAccessDuringRenderFunctionExpressions: z.boolean().default(false), - /* * Validates that setState is not unconditionally called during render, as it can lead to * infinite loops. diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.expect.md index 9f76b4e299..2574646185 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.expect.md +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.expect.md @@ -2,7 +2,7 @@ ## Input ```javascript -// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions +// @validateRefAccessDuringRender function Component(props) { const ref = useRef(null); const renderItem = (item) => { diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.js index 4a73445e92..0c87668c66 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.js +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.js @@ -1,4 +1,4 @@ -// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions +// @validateRefAccessDuringRender function Component(props) { const ref = useRef(null); const renderItem = (item) => { diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.expect.md index bc2278d7ec..de3dadecb6 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.expect.md +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.expect.md @@ -2,7 +2,7 @@ ## Input ```javascript -// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions +// @validateRefAccessDuringRender function Component(props) { const ref = useRef(null); const renderItem = (item) => { diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.js index 04f48326be..df786b271a 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.js +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.js @@ -1,4 +1,4 @@ -// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions +// @validateRefAccessDuringRender function Component(props) { const ref = useRef(null); const renderItem = (item) => {