mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Refactor some event tests (#11517)
* Use dispatchEvent() directly Don't fear repetition in tests. It is clearer what's going on. * Clean up the container after tests * Add a comment to container code
This commit is contained in:
1 parent
b4b09cb8bb
commit
13c491a828
4 files changed
+54
-40
No files matched your search
@@ -12,27 +12,28 @@
|
||||
var React;
|
||||
var ReactDOM;
|
||||
|
||||
const simulateMouseEvent = (node, type, relatedTarget) => {
|
||||
node.dispatchEvent(
|
||||
new MouseEvent(type, {
|
||||
bubbles: true,
|
||||
cancelable: true,
|
||||
relatedTarget,
|
||||
}),
|
||||
);
|
||||
};
|
||||
|
||||
describe('EnterLeaveEventPlugin', () => {
|
||||
var container;
|
||||
|
||||
beforeEach(() => {
|
||||
jest.resetModules();
|
||||
|
||||
React = require('react');
|
||||
ReactDOM = require('react-dom');
|
||||
|
||||
// The container has to be attached for events to fire.
|
||||
container = document.createElement('div');
|
||||
document.body.appendChild(container);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
document.body.removeChild(container);
|
||||
container = null;
|
||||
});
|
||||
|
||||
it('should set onMouseLeave relatedTarget properly in iframe', () => {
|
||||
const iframe = document.createElement('iframe');
|
||||
document.body.appendChild(iframe);
|
||||
container.appendChild(iframe);
|
||||
const iframeDocument = iframe.contentDocument;
|
||||
iframeDocument.write(
|
||||
'<!DOCTYPE html><html><head></head><body><div></div></body></html>',
|
||||
@@ -50,7 +51,14 @@ describe('EnterLeaveEventPlugin', () => {
|
||||
iframeDocument.body.getElementsByTagName('div')[0],
|
||||
);
|
||||
|
||||
simulateMouseEvent(node, 'mouseout', iframe.contentWindow);
|
||||
node.dispatchEvent(
|
||||
new MouseEvent('mouseout', {
|
||||
bubbles: true,
|
||||
cancelable: true,
|
||||
relatedTarget: iframe.contentWindow,
|
||||
}),
|
||||
);
|
||||
|
||||
expect(leaveEvents.length).toBe(1);
|
||||
expect(leaveEvents[0].target).toBe(node);
|
||||
expect(leaveEvents[0].relatedTarget).toBe(iframe.contentWindow);
|
||||
@@ -58,7 +66,7 @@ describe('EnterLeaveEventPlugin', () => {
|
||||
|
||||
it('should set onMouseEnter relatedTarget properly in iframe', () => {
|
||||
const iframe = document.createElement('iframe');
|
||||
document.body.appendChild(iframe);
|
||||
container.appendChild(iframe);
|
||||
const iframeDocument = iframe.contentDocument;
|
||||
iframeDocument.write(
|
||||
'<!DOCTYPE html><html><head></head><body><div></div></body></html>',
|
||||
@@ -76,7 +84,14 @@ describe('EnterLeaveEventPlugin', () => {
|
||||
iframeDocument.body.getElementsByTagName('div')[0],
|
||||
);
|
||||
|
||||
simulateMouseEvent(node, 'mouseover', null);
|
||||
node.dispatchEvent(
|
||||
new MouseEvent('mouseover', {
|
||||
bubbles: true,
|
||||
cancelable: true,
|
||||
relatedTarget: null,
|
||||
}),
|
||||
);
|
||||
|
||||
expect(enterEvents.length).toBe(1);
|
||||
expect(enterEvents[0].target).toBe(node);
|
||||
expect(enterEvents[0].relatedTarget).toBe(iframe.contentWindow);
|
||||
@@ -87,6 +102,7 @@ describe('EnterLeaveEventPlugin', () => {
|
||||
let parentEnterCalls = 0;
|
||||
let childEnterCalls = 0;
|
||||
let parent = null;
|
||||
|
||||
class Parent extends React.Component {
|
||||
render() {
|
||||
return (
|
||||
@@ -101,15 +117,18 @@ describe('EnterLeaveEventPlugin', () => {
|
||||
}
|
||||
}
|
||||
|
||||
const div = document.createElement('div');
|
||||
ReactDOM.render(<Parent />, div);
|
||||
ReactDOM.render(<Parent />, container);
|
||||
// The issue only reproduced on insertion during the first update.
|
||||
ReactDOM.render(<Parent showChild={true} />, div);
|
||||
|
||||
document.body.appendChild(div);
|
||||
ReactDOM.render(<Parent showChild={true} />, container);
|
||||
|
||||
// Enter from parent into the child.
|
||||
simulateMouseEvent(parent, 'mouseout', parent.firstChild);
|
||||
parent.dispatchEvent(
|
||||
new MouseEvent('mouseout', {
|
||||
bubbles: true,
|
||||
cancelable: true,
|
||||
relatedTarget: parent.firstChild,
|
||||
}),
|
||||
);
|
||||
|
||||
// Entering a child should fire on the child, not on the parent.
|
||||
expect(childEnterCalls).toBe(1);
|
||||
|
||||
@@ -19,6 +19,7 @@ describe('SyntheticClipboardEvent', () => {
|
||||
React = require('react');
|
||||
ReactDOM = require('react-dom');
|
||||
|
||||
// The container has to be attached for events to fire.
|
||||
container = document.createElement('div');
|
||||
document.body.appendChild(container);
|
||||
});
|
||||
|
||||
@@ -19,6 +19,7 @@ describe('SyntheticWheelEvent', () => {
|
||||
React = require('react');
|
||||
ReactDOM = require('react-dom');
|
||||
|
||||
// The container has to be attached for events to fire.
|
||||
container = document.createElement('div');
|
||||
document.body.appendChild(container);
|
||||
});
|
||||
|
||||
+13
-20
@@ -9,13 +9,24 @@
|
||||
|
||||
'use strict';
|
||||
|
||||
var React;
|
||||
var ReactDOM;
|
||||
|
||||
describe('getEventKey', () => {
|
||||
var React;
|
||||
var ReactDOM;
|
||||
var container;
|
||||
|
||||
beforeEach(() => {
|
||||
React = require('react');
|
||||
ReactDOM = require('react-dom');
|
||||
|
||||
// The container has to be attached for events to fire.
|
||||
container = document.createElement('div');
|
||||
document.body.appendChild(container);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
document.body.removeChild(container);
|
||||
container = null;
|
||||
});
|
||||
|
||||
describe('when key is implemented in a browser', () => {
|
||||
@@ -28,9 +39,7 @@ describe('getEventKey', () => {
|
||||
}
|
||||
}
|
||||
|
||||
var container = document.createElement('div');
|
||||
ReactDOM.render(<Comp />, container);
|
||||
document.body.appendChild(container);
|
||||
|
||||
var nativeEvent = new KeyboardEvent('keydown', {
|
||||
key: 'Del',
|
||||
@@ -39,7 +48,6 @@ describe('getEventKey', () => {
|
||||
});
|
||||
container.firstChild.dispatchEvent(nativeEvent);
|
||||
expect(key).toBe('Delete');
|
||||
document.body.removeChild(container);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -52,9 +60,7 @@ describe('getEventKey', () => {
|
||||
}
|
||||
}
|
||||
|
||||
var container = document.createElement('div');
|
||||
ReactDOM.render(<Comp />, container);
|
||||
document.body.appendChild(container);
|
||||
|
||||
var nativeEvent = new KeyboardEvent('keydown', {
|
||||
key: 'f',
|
||||
@@ -63,7 +69,6 @@ describe('getEventKey', () => {
|
||||
});
|
||||
container.firstChild.dispatchEvent(nativeEvent);
|
||||
expect(key).toBe('f');
|
||||
document.body.removeChild(container);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -79,9 +84,7 @@ describe('getEventKey', () => {
|
||||
}
|
||||
}
|
||||
|
||||
var container = document.createElement('div');
|
||||
ReactDOM.render(<Comp />, container);
|
||||
document.body.appendChild(container);
|
||||
|
||||
var nativeEvent = new KeyboardEvent('keypress', {
|
||||
charCode: 13,
|
||||
@@ -90,7 +93,6 @@ describe('getEventKey', () => {
|
||||
});
|
||||
container.firstChild.dispatchEvent(nativeEvent);
|
||||
expect(key).toBe('Enter');
|
||||
document.body.removeChild(container);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -103,9 +105,7 @@ describe('getEventKey', () => {
|
||||
}
|
||||
}
|
||||
|
||||
var container = document.createElement('div');
|
||||
ReactDOM.render(<Comp />, container);
|
||||
document.body.appendChild(container);
|
||||
|
||||
var nativeEvent = new KeyboardEvent('keypress', {
|
||||
charCode: 65,
|
||||
@@ -114,7 +114,6 @@ describe('getEventKey', () => {
|
||||
});
|
||||
container.firstChild.dispatchEvent(nativeEvent);
|
||||
expect(key).toBe('A');
|
||||
document.body.removeChild(container);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -129,9 +128,7 @@ describe('getEventKey', () => {
|
||||
}
|
||||
}
|
||||
|
||||
var container = document.createElement('div');
|
||||
ReactDOM.render(<Comp />, container);
|
||||
document.body.appendChild(container);
|
||||
|
||||
var nativeEvent = new KeyboardEvent('keydown', {
|
||||
keyCode: 45,
|
||||
@@ -140,7 +137,6 @@ describe('getEventKey', () => {
|
||||
});
|
||||
container.firstChild.dispatchEvent(nativeEvent);
|
||||
expect(key).toBe('Insert');
|
||||
document.body.removeChild(container);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -153,9 +149,7 @@ describe('getEventKey', () => {
|
||||
}
|
||||
}
|
||||
|
||||
var container = document.createElement('div');
|
||||
ReactDOM.render(<Comp />, container);
|
||||
document.body.appendChild(container);
|
||||
|
||||
var nativeEvent = new KeyboardEvent('keydown', {
|
||||
keyCode: 1337,
|
||||
@@ -164,7 +158,6 @@ describe('getEventKey', () => {
|
||||
});
|
||||
container.firstChild.dispatchEvent(nativeEvent);
|
||||
expect(key).toBe('Unidentified');
|
||||
document.body.removeChild(container);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user