From 0e10ee906e3ea55e4d717d4db498e1159235b06b Mon Sep 17 00:00:00 2001 From: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> Date: Fri, 12 Sep 2025 12:20:39 +0100 Subject: [PATCH] [Reconciler] Set ProfileMode for Host Root Fiber by default in dev (#34432) Requiring DevTools to be present for dev builds seems like an overkill, let's enable the instrumentation by default. Nothing changes for profiling or production artifacts. --- packages/react-reconciler/src/ReactFiber.js | 8 ++++---- .../react/src/__tests__/ReactProfiler-test.internal.js | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiber.js b/packages/react-reconciler/src/ReactFiber.js index 0af7ffb767..fb2c734701 100644 --- a/packages/react-reconciler/src/ReactFiber.js +++ b/packages/react-reconciler/src/ReactFiber.js @@ -532,10 +532,10 @@ export function createHostRootFiber( mode = NoMode; } - if (enableProfilerTimer && isDevToolsPresent) { - // Always collect profile timings when DevTools are present. - // This enables DevTools to start capturing timing at any point– - // Without some nodes in the tree having empty base times. + if (__DEV__ || (enableProfilerTimer && isDevToolsPresent)) { + // dev: Enable profiling instrumentation by default. + // profile: enabled if DevTools is present or subtree is wrapped in . + // production: disabled. mode |= ProfileMode; } diff --git a/packages/react/src/__tests__/ReactProfiler-test.internal.js b/packages/react/src/__tests__/ReactProfiler-test.internal.js index d51b037c18..a8c00b2b56 100644 --- a/packages/react/src/__tests__/ReactProfiler-test.internal.js +++ b/packages/react/src/__tests__/ReactProfiler-test.internal.js @@ -125,6 +125,7 @@ describe(`onRender`, () => { expect(callback).toHaveBeenCalledTimes(1); }); + // @gate !__DEV__ it('does not record times for components outside of Profiler tree', async () => { // Mock the Scheduler module so we can track how many times the current // time is read