From 0d3fc9de1019fcc69d3be0add555ea47f364059c Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Fri, 31 Aug 2018 16:09:29 +0100 Subject: [PATCH] Add regression test for #6119 --- .../src/__tests__/DOMPropertyOperations-test.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js b/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js index b42e4a7b1a..c4438a3bdd 100644 --- a/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js +++ b/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js @@ -139,6 +139,15 @@ describe('DOMPropertyOperations', () => { ReactDOM.render(, container); expect(container.firstChild.setAttribute).toHaveBeenCalledTimes(2); }); + + it('should return the progress to intermediate state on null value', () => { + const container = document.createElement('div'); + ReactDOM.render(, container); + ReactDOM.render(, container); + // Ensure we move progress back to an indeterminate state. + // Regression test for https://github.com/facebook/react/issues/6119 + expect(container.firstChild.hasAttribute('value')).toBe(false); + }); }); describe('deleteValueForProperty', () => {