Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[rhir] Visit DoWhile's test as a conditional dependency

Browse Source 
Missed this in the prior PR!
This commit is contained in:
Lauren Tan
2023-03-03 00:31:37 -05:00
parent de6444b4f5
commit 0ad0f8cf43
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/ReactiveScopes/PropagateScopeDependencies.ts
+3 -1
View File
@@ -576,7 +576,9 @@ function visit(context: Context, block: ReactiveBlock): void {
}
case "do-while": {
visit(context, terminal.loop);
visitReactiveValue(context, terminal.id, terminal.test);
context.enterConditional(() => {
visitReactiveValue(context, terminal.id, terminal.test);
});
break;
}
case "while": {
compiler/forget/src/__tests__/fixtures/hir/do-while-conditional-break.expect.md
+2 -2
View File
@@ -20,7 +20,7 @@ function Component(props) {
```javascript
function Component(props) {
const $ = React.unstable_useMemoCache(2);
const c_0 = $[0] !== props.cond;
const c_0 = $[0] !== props;
let x;
if (c_0) {
x = [0, 1, 2, 3];
@@ -31,7 +31,7 @@ function Component(props) {
mutate(x);
} while (props.cond);
$[0] = props.cond;
$[0] = props;
$[1] = x;
} else {
x = $[1];