From 0892e305bc8397fee6db6e8e14d36fcb99b49de9 Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Wed, 28 Jun 2023 11:43:56 -0400 Subject: [PATCH] [eslint-plugin] Clean up error message Omits some unncessary details from the error message surfaced in eslint --- .../__tests__/ReactForgetDiagnostics-test.ts | 4 ++-- .../src/rules/ReactForgetDiagnostics.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/compiler/forget/packages/eslint-plugin-react-forget/__tests__/ReactForgetDiagnostics-test.ts b/compiler/forget/packages/eslint-plugin-react-forget/__tests__/ReactForgetDiagnostics-test.ts index e207a35736..c517ffe366 100644 --- a/compiler/forget/packages/eslint-plugin-react-forget/__tests__/ReactForgetDiagnostics-test.ts +++ b/compiler/forget/packages/eslint-plugin-react-forget/__tests__/ReactForgetDiagnostics-test.ts @@ -72,7 +72,7 @@ const tests: ForgetTestCases = { errors: [ { message: - "[ReactForget] InvalidReact: Ref values (the `current` property) may not be accessed during render. (https://react.dev/reference/react/useRef). Cannot access ref value at freeze $22:TObject (6:6)", + "[ReactForget] Ref values (the `current` property) may not be accessed during render. (https://react.dev/reference/react/useRef)", line: 6, column: 10, endColumn: 15, @@ -92,7 +92,7 @@ const tests: ForgetTestCases = { errors: [ { message: - "[ReactForget] InvalidReact: React Forget has bailed out of optimizing this component as one or more React eslint rules were disabled. React Forget only works when your components follow all the rules of React, disabling them may result in undefined behavior. eslint-disable-next-line react-hooks/rules-of-hooks (4:4)", + "[ReactForget] React Forget has bailed out of optimizing this component as one or more React eslint rules were disabled. React Forget only works when your components follow all the rules of React, disabling them may result in undefined behavior", suggestions: [ { output: normalizeIndent` diff --git a/compiler/forget/packages/eslint-plugin-react-forget/src/rules/ReactForgetDiagnostics.ts b/compiler/forget/packages/eslint-plugin-react-forget/src/rules/ReactForgetDiagnostics.ts index 683db0073b..40a278d591 100644 --- a/compiler/forget/packages/eslint-plugin-react-forget/src/rules/ReactForgetDiagnostics.ts +++ b/compiler/forget/packages/eslint-plugin-react-forget/src/rules/ReactForgetDiagnostics.ts @@ -157,7 +157,7 @@ const rule: Rule.RuleModule = { } } context.report({ - message: detail.toString(), + message: `[ReactForget] ${detail.reason}`, loc: detail.loc, suggest, });